10 Mar, 2011

1 commit

  • The rtc-test driver is meant to provide a test/debug code for the RTC
    subsystem.

    The rtc-test driver simulates specific interrupts by echoing to the
    sys interface. Those were the update, alarm and periodic interrupts.

    As a side effect of the new implementation, any interrupt generated in
    the rtc-test driver would trigger the same code path in the generic
    code, and thus the distinction among interrupts gets lost.

    This patch preserves the previous behaviour of the rtc-test driver,
    where e.g. an update interrupt would not trigger an alarm or periodic
    interrupt, and vice-versa. In real world RTC drivers, this is not an
    issue, but in the rtc-test driver it may be interesting to distinguish
    these interrupts for testing purposes.

    CC: Thomas Gleixner
    CC: Alessandro Zummo
    CC: Marcelo Roberto Jimenez
    CC: rtc-linux@googlegroups.com
    Signed-off-by: Marcelo Roberto Jimenez
    Signed-off-by: John Stultz

    Marcelo Roberto Jimenez
     

04 Feb, 2011

1 commit

  • Some rtc drivers use the ioctl method instead of the alarm_irq_enable
    method for enabling alarm interupts. With the new virtualized RTC
    rework, its important for drivers to use the alarm_irq_enable instead.

    This patch converts the drivers that use the AIE ioctl method to
    use the alarm_irq_enable method. Other ioctl cmds are left untouched.

    I have not been able to test or even compile most of these drivers.
    Any help to make sure this change is correct would be appreciated!

    CC: Alessandro Zummo
    CC: Thomas Gleixner
    CC: Marcelo Roberto Jimenez
    Reported-by: Marcelo Roberto Jimenez
    Tested-by: Marcelo Roberto Jimenez
    Signed-off-by: John Stultz

    John Stultz
     

20 Jun, 2009

1 commit

  • The rtc_update_irq() might be called with irqs enabled, if a interrupt
    handler was registered without IRQF_DISABLED. Use
    spin_lock_irqsave/spin_unlock_irqrestore instead of spin_lock/spin_unlock.

    Also update kerneldoc and drivers which do extra work to follow the
    current interface spec, as suggestted by David Brownell.

    Signed-off-by: Atsushi Nemoto
    Cc: Alessandro Zummo
    Cc: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Atsushi Nemoto
     

07 Jan, 2009

1 commit

  • Drivers should only need to implement either set_mmss (counter based RTCs)
    or set_time (most RTCs). The RTC subsystem will handle them
    appropriately.

    Signed-off-by: Alessandro Zummo
    Cc: Kumar Gala
    Cc: David Brownell
    Cc: Lennert Buytenhek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alessandro Zummo
     

28 Apr, 2008

1 commit

  • Fix following warning:
    WARNING: vmlinux.o(.data+0x253e28): Section mismatch in reference from the variable test_drv to the function .devexit.text:test_remove()

    Fix by renaming the platfrom_driver variable from *_drv to *_driver
    so modpost ignore the reference to an __devexit section.

    Signed-off-by: Sam Ravnborg
    Cc: Alessandro Zummo
    Cc: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sam Ravnborg
     

09 May, 2007

1 commit

  • This patch removes class_device from the programming interface that the RTC
    framework exposes to the rest of the kernel. Now an rtc_device is passed,
    which is more type-safe and streamlines all the relevant code.

    Signed-off-by: David Brownell
    Acked-by: Greg Kroah-Hartman
    Acked-By: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

08 Dec, 2006

1 commit


26 Nov, 2006

1 commit

  • I got a lockdep warning when running "rtctest" so I though it'd be good
    to see what was up.

    - The warning was for rtc->irq_task_lock, gotten from rtc_update_irq()
    by irq handlerss ... but in a handful of other cases, grabbed without
    blocking IRQs.

    - Some callers to rtc_update_irq() were not ensuring IRQs were blocked,
    yet the routine expects that; make sure all callers block IRQs.

    It would appear that RTC API tests haven't been part of anyone's kernel
    regression test suite recently, at least not with lockdep running.

    Signed-off-by: David Brownell
    Acked-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

01 Oct, 2006

1 commit


22 May, 2006

1 commit


11 Apr, 2006

2 commits


28 Mar, 2006

1 commit