22 Jul, 2011

1 commit

  • Inspired by Nat Gurumoorthy's recent patches for cleaning up the it87
    drivers to use request_muxed_region for accessing the SuperIO area on
    these chips, and the fact I have a GPIO driver for the pc8741x basically
    ready for submission, here is a patch to cleanup the pc87413 watchdog
    driver to use request_muxed_region for accessing the SuperIO area.

    It also pulls out the details about the SWC IO area on initial driver
    load, and properly does a request_region for that area - there's no
    requirement to touch the SuperIO area after doing the initial watchdog
    enable and IO base retrieval.

    While I have hardware with a pc87413 on it it is not wired in a way that
    allows the watchdog to reboot the machine, so I have not been able to
    fully test these changes - I have checked that the driver correctly
    initialises itself still and requests the SWC io region ok.

    Signed-Off-By: Jonathan McDowell
    Signed-Off-By: Wim Van Sebroeck

    Jonathan McDowell
     

31 Mar, 2011

1 commit


16 Mar, 2011

1 commit


25 May, 2010

1 commit

  • Fix MODULE_PARM_DESC() strings in several watchdog drivers.
    Some are simple as add a parenthesis.
    Others are problems from __stringify() being used on a
    variable name instead of a macro name, so the variable name
    is produced in the string instead of its build-time value.
    In these cases, create a macro for the value so that the
    module param description string is useful.

    Only pc87413_wdt has been built (due to toolchains).

    Signed-off-by: Randy Dunlap
    Signed-off-by: Wim Van Sebroeck

    Randy Dunlap
     

07 Mar, 2010

1 commit


25 Mar, 2009

1 commit


27 Aug, 2008

1 commit


07 Aug, 2008

1 commit


06 Aug, 2008

1 commit

  • This brings the watchdog drivers into line with coding style.
    This patch takes cares of the indentation as described in chapter 1.
    Main changes:
    * Re-structure the ioctl switch call for all drivers as follows:
    switch (cmd) {
    case WDIOC_GETSUPPORT:
    case WDIOC_GETSTATUS:
    case WDIOC_GETBOOTSTATUS:
    case WDIOC_GETTEMP:
    case WDIOC_SETOPTIONS:
    case WDIOC_KEEPALIVE:
    case WDIOC_SETTIMEOUT:
    case WDIOC_GETTIMEOUT:
    case WDIOC_GETTIMELEFT:
    default:
    }

    This to make the migration from the drivers to the uniform watchdog
    device driver easier in the future.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

14 Jun, 2008

1 commit


03 Nov, 2007

1 commit

  • Some watchdog drivers initialize global spinlocks in module's init function
    which is tolerable, but some do it in PCI probe function. So, switch to
    static initialization to fix theoretical bugs and, more importantly, stop
    giving people bad examples.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Wim Van Sebroeck
    Signed-off-by: Andrew Morton

    Alexey Dobriyan
     

18 Oct, 2007

1 commit