04 Jul, 2011

2 commits

  • This patch introduces helper functions for all debugging checks, so instead of
    doing

    if (!(ubifs_chk_flags & UBIFS_CHK_GEN))

    we now do

    if (!dbg_is_chk_gen(c))

    This is a preparation to further changes where the flags will go away, and
    we'll need to only change the helper functions, but the code which utilizes
    them won't be touched.

    At the same time this patch removes 'dbg_force_in_the_gaps()',
    'dbg_force_in_the_gaps_enabled()', and dbg_failure_mode helpers for
    consistency.

    Signed-off-by: Artem Bityutskiy

    Artem Bityutskiy
     
  • The UBIFS lpt tree is in many aspects similar to the TNC tree, and we have
    similar flags for these trees. And by mistake we use the COW_ZNODE flag for
    LPT in some places, instead of the right flag COW_CNODE. And this works
    only because these two constants have the same value.

    This patch makes all the LPT code to use COW_CNODE and also changes COW_CNODE
    constant value to make sure we do not misuse the flags any more.

    Signed-off-by: Artem Bityutskiy

    Artem Bityutskiy
     

16 May, 2011

4 commits


24 Mar, 2011

1 commit

  • This patch fixes a brown-paperbag bug which was introduced by me:
    I used incorrect "GFP_KERNEL | GFP_NOFS" allocation flags to make
    sure my allocations do not cause write-back. But the correct form
    is "GFP_NOFS".

    Signed-off-by: Artem Bityutskiy

    Artem Bityutskiy
     

16 Mar, 2011

1 commit

  • Instead of using pre-allocated 'c->dbg->buf' buffer in
    'scan_check_cb()', dynamically allocate it when needed. The intend
    is to get rid of the pre-allocated 'c->dbg->buf' buffer and save
    128KiB of RAM (or more if PEB size is larger). Indeed, currently we
    allocate this memory even if the user never enables any self-check,
    which is wasteful.

    Signed-off-by: Artem Bityutskiy

    Artem Bityutskiy
     

15 Sep, 2009

2 commits


10 Sep, 2009

1 commit

  • At the moment UBIFS print large and scary error messages and
    flash dumps in case of nearly any corruption, even if it is
    a recoverable corruption. For example, if the master node is
    corrupted, ubifs_scan() prints error dumps, then UBIFS recovers
    just fine and goes on.

    This patch makes UBIFS print scary error messages only in
    real cases, which are not recoverable. It adds 'quiet' argument
    to the 'ubifs_scan()' function, so the caller may ask 'ubi_scan()'
    not to print error messages if the caller is able to do recovery.

    Signed-off-by: Artem Bityutskiy
    Reviewed-by: Adrian Hunter

    Artem Bityutskiy
     

26 Jan, 2009

2 commits


23 Dec, 2008

1 commit


03 Dec, 2008

1 commit


30 Sep, 2008

2 commits

  • 'ubifs_get_lprops()' and 'ubifs_release_lprops()' basically wrap
    mutex lock and unlock. We have them because we want lprops subsystem
    be separate and as independent as possible. And we planned better
    locking rules for lprops.

    Anyway, because they are short, it is better to inline them.

    Signed-off-by: Artem Bityutskiy

    Artem Bityutskiy
     
  • This commit adds a reserved pool size print and tweaks the
    prints to make them look nicer.

    It also fixes and cleans-up some comments.

    Additionally, it deletes some blank lines to make the code look
    a little nicer.

    In other words, nothing essential.

    Signed-off-by: Artem Bityutskiy

    Artem Bityutskiy
     

15 Jul, 2008

1 commit