30 Dec, 2011

2 commits


25 Jun, 2011

3 commits

  • Gets rid of a pair of checks to see if a name sequence entry in
    TIPC's name table has an empty zone list. These checks are pointless
    since the zone list can never be empty (i.e. as soon as the list
    becomes empty the associated name sequence entry is deleted).

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker

    Allan Stephens
     
  • Modifies the main circular linked lists of publications used in TIPC's
    name table to use the standard kernel linked list type. This change
    simplifies the deletion of an existing publication by eliminating
    the need to search up to three lists to locate the publication.
    The use of standard list routines also helps improve the readability
    of the name table code by make it clearer what each list operation
    being performed is actually doing.

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker

    Allan Stephens
     
  • Modifies the name table array structure that contains the name
    sequence instances for a given name type so that the publication
    lists associated with a given instance are stored in a dynamically
    allocated structure, rather than being embedded within the array
    entry itself. This change is being done for several reasons:

    1) It reduces the amount of data that needs to be copied whenever
    a given array is expanded or contracted to accommodate the first
    publication of a new name sequence or the removal of the last
    publication of an existing name sequence.

    2) It reduces the amount of memory associated with array entries that
    are currently unused.

    3) It facilitates the upcoming conversion of the publication lists
    from TIPC-specific circular lists to standard kernel lists. (Standard
    lists cannot be used with the former array structure because the
    relocation of array entries during array expansion and contraction
    would corrupt the lists.)

    Note that, aside from introducing a small amount of code to dynamically
    allocate and free the structure that now holds publication list info,
    this change is largely a simple renaming exercise that replaces
    references to "sseq->LIST" with "sseq->info->LIST" (or "info->LIST").

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker

    Allan Stephens
     

02 Jan, 2011

4 commits


03 Dec, 2010

1 commit


14 Oct, 2010

1 commit

  • Remove all instances of legacy, or as yet to be implemented code
    that is currently living within an #if 0 ... #endif block.
    In the rare instance that some of it be needed in the future,
    it can still be dragged out of history, but there is no need
    for it to sit in mainline.

    Signed-off-by: Paul Gortmaker
    Acked-by: Neil Horman
    Signed-off-by: David S. Miller

    Paul Gortmaker
     

24 Sep, 2010

1 commit


07 Sep, 2010

1 commit

  • Optimizes TIPC's name table translation code to avoid unnecessary
    manipulation of the node address field of the resulting port id when
    name translation fails. This change is possible because a valid port
    id cannot have a reference field of zero, so examining the reference
    only is sufficient to determine if the translation was successful.

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker
    Signed-off-by: David S. Miller

    Allan Stephens
     

18 Aug, 2010

1 commit

  • Eliminate printing of dashes after name table column headers
    (to adhere more closely to the standard format used in tipc-config),
    and simplify name table display logic using array lookups rather
    than if-then-else logic.

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker
    Signed-off-by: David S. Miller

    Allan Stephens
     

13 May, 2010

1 commit

  • These functions have enough code in them such that they
    seem like sensible targets for un-inlining. Prior to doing
    that, this adds the tipc_ prefix to the functions, so that
    in the event of a panic dump or similar, the subsystem from
    which the functions come from is immediately clear.

    Signed-off-by: Allan Stephens
    Signed-off-by: Paul Gortmaker
    Signed-off-by: David S. Miller

    Allan Stephens
     

08 Nov, 2008

1 commit


15 Jul, 2008

2 commits

  • This patch simplifies and speeds up TIPC's algorithm for identifying
    on-node and off-node destinations that overlap a multicast name
    sequence range. Rather than traversing the list of all known name
    publications within the cluster, it now traverses the (potentially
    much shorter) list of name publications made by the node itself, and
    determines if any off-node destinations exist by comparing the sizes
    of the two lists. (Since the node list must be a subset of the
    cluster list, a difference in sizes means that at least one off-node
    destination must exist.)

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     
  • This patch ensures that TIPC's multicast message name lookup
    algorithm does individualized scope checking for each published
    name it examines. Previously, scope checking was only done for
    the first name in a name table publication list, which could
    result in incoming multicast messages being delivered to ports
    publishing names with "node" scope, or not being delivered to
    ports publishing names with "cluster" or "zone" scope.

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     

05 Jun, 2008

2 commits


13 May, 2008

1 commit


03 Aug, 2007

1 commit


20 Jul, 2007

1 commit

  • Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).

    Here is a short excerpt of the semantic patch performing
    this transformation:

    @@
    type T2;
    expression x;
    identifier f,fld;
    expression E;
    expression E1,E2;
    expression e1,e2,e3,y;
    statement S;
    @@

    x =
    - kmalloc
    + kzalloc
    (E1,E2)
    ... when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
    - memset((T2)x,0,E1);

    @@
    expression E1,E2,E3;
    @@

    - kzalloc(E1 * E2,E3)
    + kcalloc(E1,E2,E3)

    [akpm@linux-foundation.org: get kcalloc args the right way around]
    Signed-off-by: Yoann Padioleau
    Cc: Richard Henderson
    Cc: Ivan Kokshaysky
    Acked-by: Russell King
    Cc: Bryan Wu
    Acked-by: Jiri Slaby
    Cc: Dave Airlie
    Acked-by: Roland Dreier
    Cc: Jiri Kosina
    Acked-by: Dmitry Torokhov
    Cc: Benjamin Herrenschmidt
    Acked-by: Mauro Carvalho Chehab
    Acked-by: Pierre Ossman
    Cc: Jeff Garzik
    Cc: "David S. Miller"
    Acked-by: Greg KH
    Cc: James Bottomley
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoann Padioleau
     

11 Feb, 2007

1 commit


22 Jul, 2006

1 commit


28 Jun, 2006

1 commit

  • locking init cleanups:

    - convert " = SPIN_LOCK_UNLOCKED" to spin_lock_init() or DEFINE_SPINLOCK()
    - convert rwlocks in a similar manner

    this patch was generated automatically.

    Motivation:

    - cleanliness
    - lockdep needs control of lock initialization, which the open-coded
    variants do not give
    - it's also useful for -rt and for lock debugging in general

    Signed-off-by: Ingo Molnar
    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

26 Jun, 2006

3 commits


21 Mar, 2006

3 commits

  • This patch contains the following possible cleanups:
    - make needlessly global code static
    - #if 0 the following unused global functions:
    - name_table.c: tipc_nametbl_print()
    - name_table.c: tipc_nametbl_dump()
    - net.c: tipc_net_next_node()

    Signed-off-by: Adrian Bunk
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Adrian Bunk
     
  • With reference to latest discussions on linux-kernel with respect to
    inline here is a patch for tipc to remove all inlines as used in
    the .c files. See also chapter 14 in Documentation/CodingStyle.

    Before:
    text data bss dec hex filename
    102990 5292 1752 110034 1add2 tipc.o

    Now:
    text data bss dec hex filename
    101190 5292 1752 108234 1a6ca tipc.o

    This is a nice text size reduction which will improve icache usage.
    In some cases bigger (> 4 lines) functions where declared inline
    and used in many places, they are most probarly no longer inlined by gcc
    resulting in the size reduction.
    There are several one liners that no longer are declared inline, but gcc
    should inline these just fine without the inline hint.

    With this patch applied one warning is added about an unused static
    function - that was hidded by utilising inline before.
    The function in question were kept so this patch is solely a
    inline removal patch.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Sam Ravnborg
     
  • Tried to run the new tipc stack through sparse.
    Following patch fixes all cases where 0 was used
    as replacement of NULL.
    Use NULL to document this is a pointer and to silence sparse.

    This brough sparse warning count down with 127 to 24 warnings.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: Per Liden
    Signed-off-by: David S. Miller

    Sam Ravnborg
     

18 Jan, 2006

1 commit


13 Jan, 2006

4 commits