12 Mar, 2021

6 commits

  • Introduce an extra parameter is_iomem to da_to_va, then the caller
    could take the memory as normal memory or io mapped memory.

    Reviewed-by: Bjorn Andersson
    Reviewed-by: Mathieu Poirier
    Reported-by: kernel test robot
    Signed-off-by: Peng Fan
    Link: https://lore.kernel.org/r/1615029865-23312-5-git-send-email-peng.fan@oss.nxp.com
    Signed-off-by: Bjorn Andersson

    Peng Fan
     
  • Introduce is_iomem to indicate this piece memory is iomem or not.

    Reviewed-by: Bjorn Andersson
    Reviewed-by: Mathieu Poirier
    Signed-off-by: Peng Fan
    Link: https://lore.kernel.org/r/1615029865-23312-4-git-send-email-peng.fan@oss.nxp.com
    Signed-off-by: Bjorn Andersson

    Peng Fan
     
  • Add i.MX8MQ/M support, also include mailbox for rpmsg/virtio usage.

    Reviewed-by: Rob Herring
    Signed-off-by: Peng Fan
    Link: https://lore.kernel.org/r/1615029865-23312-3-git-send-email-peng.fan@oss.nxp.com
    Signed-off-by: Bjorn Andersson

    Peng Fan
     
  • Convert the imx rproc binding to DT schema format using json-schema.

    Reviewed-by: Rob Herring
    Signed-off-by: Peng Fan
    Link: https://lore.kernel.org/r/1615029865-23312-2-git-send-email-peng.fan@oss.nxp.com
    Signed-off-by: Bjorn Andersson

    Peng Fan
     
  • There are four different callback functions that are used for the
    rproc_handle_resource_t callback that all have different second
    parameter types.

    rproc_handle_vdev -> struct fw_rsc_vdev
    rproc_handle_trace -> struct fw_rsc_trace
    rproc_handle_devmem -> struct fw_rsc_devmem
    rproc_handle_carveout -> struct fw_rsc_carveout

    These callbacks are cast to rproc_handle_resource_t so that there is no
    error about incompatible pointer types. Unfortunately, this is a Clang's
    Control-Flow Integrity checking violation, which verifies that the
    callback function's types match the prototypes exactly before jumping.

    [ 7.275750] Kernel panic - not syncing: CFI failure (target: rproc_handle_vdev+0x0/0x4)
    [ 7.283763] CPU: 2 PID: 1 Comm: init Tainted: G C O 5.4.70-03301-g527af2c96672 #17
    [ 7.292463] Hardware name: NXP i.MX8MPlus EVK board (DT)
    [ 7.297779] Call trace:
    [ 7.300232] dump_backtrace.cfi_jt+0x0/0x4
    [ 7.304337] show_stack+0x18/0x24
    [ 7.307660] dump_stack+0xb8/0x114
    [ 7.311069] panic+0x164/0x3d4
    [ 7.314130] __ubsan_handle_cfi_check_fail_abort+0x0/0x14
    [ 7.319533] perf_proc_update_handler+0x0/0xcc
    [ 7.323983] __cfi_check+0x63278/0x6a290
    [ 7.327913] rproc_boot+0x3f8/0x738
    [ 7.331404] rproc_add+0x68/0x110
    [ 7.334738] imx_rproc_probe+0x5e4/0x708 [imx_rproc]
    [ 7.339711] platform_drv_probe+0xac/0xf0
    [ 7.343726] really_probe+0x260/0x65c
    [ 7.347393] driver_probe_device+0x64/0x100
    [ 7.351580] device_driver_attach+0x6c/0xac
    [ 7.355766] __driver_attach+0xdc/0x184
    [ 7.359609] bus_for_each_dev+0x98/0x104
    [ 7.363537] driver_attach+0x24/0x30
    [ 7.367117] bus_add_driver+0x100/0x1e0
    [ 7.370958] driver_register+0x78/0x114
    [ 7.374800] __platform_driver_register+0x44/0x50
    [ 7.379514] init_module+0x20/0xfe8 [imx_rproc]
    [ 7.384049] do_one_initcall+0x190/0x348
    [ 7.387979] do_init_module+0x5c/0x210
    [ 7.391731] load_module+0x2fbc/0x3590
    [ 7.395485] __arm64_sys_finit_module+0xb8/0xec
    [ 7.400025] el0_svc_common+0xb4/0x19c
    [ 7.403777] el0_svc_handler+0x74/0x98
    [ 7.407531] el0_svc+0x8/0xc
    [ 7.410419] SMP: stopping secondary CPUs
    [ 7.414648] Kernel Offset: disabled
    [ 7.418142] CPU features: 0x00010002,2000200c
    [ 7.422501] Memory Limit: none

    To fix this, change the second parameter of all functions to void * and
    use a local variable with the correct type so that everything works
    properly. With this, we can remove casting to rproc_handle_resource_t
    for these functions.

    Signed-off-by: Jindong Yue
    Reviewed-by: Peng Fan
    Reviewed-by: Sami Tolvanen
    Reviewed-by: Mathieu Poirier
    Link: https://lore.kernel.org/r/20210224055825.7417-1-jindong.yue@nxp.com
    Signed-off-by: Bjorn Andersson

    Jindong Yue
     
  • Fix the following coccicheck warning:
    ./drivers/remoteproc/pru_rproc.c:247:0-23: WARNING:
    pru_rproc_debug_ss_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE

    Reviewed-by: Mathieu Poirier
    Reported-by: Abaci Robot
    Signed-off-by: Yang Li
    Link: https://lore.kernel.org/r/1614154829-42461-1-git-send-email-yang.lee@linux.alibaba.com
    Signed-off-by: Bjorn Andersson

    Yang Li
     

09 Mar, 2021

1 commit


06 Mar, 2021

18 commits

  • Linus Torvalds
     
  • Pull rdma fixes from Jason Gunthorpe:
    "Nothing special here, though Bob's regression fixes for rxe would have
    made it before the rc cycle had there not been such strong winter
    weather!

    - Fix corner cases in the rxe reference counting cleanup that are
    causing regressions in blktests for SRP

    - Two kdoc fixes so W=1 is clean

    - Missing error return in error unwind for mlx5

    - Wrong lock type nesting in IB CM"

    * tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma:
    RDMA/rxe: Fix errant WARN_ONCE in rxe_completer()
    RDMA/rxe: Fix extra deref in rxe_rcv_mcast_pkt()
    RDMA/rxe: Fix missed IB reference counting in loopback
    RDMA/uverbs: Fix kernel-doc warning of _uverbs_alloc
    RDMA/mlx5: Set correct kernel-doc identifier
    IB/mlx5: Add missing error code
    RDMA/rxe: Fix missing kconfig dependency on CRYPTO
    RDMA/cm: Fix IRQ restore in ib_send_cm_sidr_rep

    Linus Torvalds
     
  • Pull gcc-plugins fixes from Kees Cook:
    "Tiny gcc-plugin fixes for v5.12-rc2. These issues are small but have
    been reported a couple times now by static analyzers, so best to get
    them fixed to reduce the noise. :)

    - Fix coding style issues (Jason Yan)"

    * tag 'gcc-plugins-v5.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
    gcc-plugins: latent_entropy: remove unneeded semicolon
    gcc-plugins: structleak: remove unneeded variable 'ret'

    Linus Torvalds
     
  • Pull pstore fixes from Kees Cook:

    - Rate-limit ECC warnings (Dmitry Osipenko)

    - Fix error path check for NULL (Tetsuo Handa)

    * tag 'pstore-v5.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
    pstore/ram: Rate-limit "uncorrectable error in header" message
    pstore: Fix warning in pstore_kill_sb()

    Linus Torvalds
     
  • …evice-mapper/linux-dm

    Pull device mapper fixes from Mike Snitzer:
    "Fix DM verity target's optional Forward Error Correction (FEC) for
    Reed-Solomon roots that are unaligned to block size"

    * tag 'for-5.12/dm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm:
    dm verity: fix FEC for RS roots unaligned to block size
    dm bufio: subtract the number of initial sectors in dm_bufio_get_device_size

    Linus Torvalds
     
  • Pull block fixes from Jens Axboe:

    - NVMe fixes:
    - more device quirks (Julian Einwag, Zoltán Böszörményi, Pascal
    Terjan)
    - fix a hwmon error return (Daniel Wagner)
    - fix the keep alive timeout initialization (Martin George)
    - ensure the model_number can't be changed on a used subsystem
    (Max Gurtovoy)

    - rsxx missing -EFAULT on copy_to_user() failure (Dan)

    - rsxx remove unused linux.h include (Tian)

    - kill unused RQF_SORTED (Jean)

    - updated outdated BFQ comments (Joseph)

    - revert work-around commit for bd_size_lock, since we removed the
    offending user in this merge window (Damien)

    * tag 'block-5.12-2021-03-05' of git://git.kernel.dk/linux-block:
    nvmet: model_number must be immutable once set
    nvme-fabrics: fix kato initialization
    nvme-hwmon: Return error code when registration fails
    nvme-pci: add quirks for Lexar 256GB SSD
    nvme-pci: mark Kingston SKC2000 as not supporting the deepest power state
    nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.
    rsxx: Return -EFAULT if copy_to_user() fails
    block/bfq: update comments and default value in docs for fifo_expire
    rsxx: remove unused including
    block: Drop leftover references to RQF_SORTED
    block: revert "block: fix bd_size_lock use"

    Linus Torvalds
     
  • Pull io_uring fixes from Jens Axboe:
    "A bit of a mix between fallout from the worker change, cleanups and
    reductions now possible from that change, and fixes in general. In
    detail:

    - Fully serialize manager and worker creation, fixing races due to
    that.

    - Clean up some naming that had gone stale.

    - SQPOLL fixes.

    - Fix race condition around task_work rework that went into this
    merge window.

    - Implement unshare. Used for when the original task does unshare(2)
    or setuid/seteuid and friends, drops the original workers and forks
    new ones.

    - Drop the only remaining piece of state shuffling we had left, which
    was cred. Move it into issue instead, and we can drop all of that
    code too.

    - Kill f_op->flush() usage. That was such a nasty hack that we had
    out of necessity, we no longer need it.

    - Following from ->flush() removal, we can also drop various bits of
    ctx state related to SQPOLL and cancelations.

    - Fix an issue with IOPOLL retry, which originally was fallout from a
    filemap change (removing iov_iter_revert()), but uncovered an issue
    with iovec re-import too late.

    - Fix an issue with system suspend.

    - Use xchg() for fallback work, instead of cmpxchg().

    - Properly destroy io-wq on exec.

    - Add create_io_thread() core helper, and use that in io-wq and
    io_uring. This allows us to remove various silly completion events
    related to thread setup.

    - A few error handling fixes.

    This should be the grunt of fixes necessary for the new workers, next
    week should be quieter. We've got a pending series from Pavel on
    cancelations, and how tasks and rings are indexed. Outside of that,
    should just be minor fixes. Even with these fixes, we're still killing
    a net ~80 lines"

    * tag 'io_uring-5.12-2021-03-05' of git://git.kernel.dk/linux-block: (41 commits)
    io_uring: don't restrict issue_flags for io_openat
    io_uring: make SQPOLL thread parking saner
    io-wq: kill hashed waitqueue before manager exits
    io_uring: clear IOCB_WAITQ for non -EIOCBQUEUED return
    io_uring: don't keep looping for more events if we can't flush overflow
    io_uring: move to using create_io_thread()
    kernel: provide create_io_thread() helper
    io_uring: reliably cancel linked timeouts
    io_uring: cancel-match based on flags
    io-wq: ensure all pending work is canceled on exit
    io_uring: ensure that threads freeze on suspend
    io_uring: remove extra in_idle wake up
    io_uring: inline __io_queue_async_work()
    io_uring: inline io_req_clean_work()
    io_uring: choose right tctx->io_wq for try cancel
    io_uring: fix -EAGAIN retry with IOPOLL
    io-wq: fix error path leak of buffered write hash map
    io_uring: remove sqo_task
    io_uring: kill sqo_dead and sqo submission halting
    io_uring: ignore double poll add on the same waitqueue head
    ...

    Linus Torvalds
     
  • Pull power management fixes from Rafael Wysocki:
    "These fix the usage of device links in the runtime PM core code and
    update the DTPM (Dynamic Thermal Power Management) feature added
    recently.

    Specifics:

    - Make the runtime PM core code avoid attempting to suspend supplier
    devices before updating the PM-runtime status of a consumer to
    'suspended' (Rafael Wysocki).

    - Fix DTPM (Dynamic Thermal Power Management) root node
    initialization and label that feature as EXPERIMENTAL in Kconfig
    (Daniel Lezcano)"

    * tag 'pm-5.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
    powercap/drivers/dtpm: Add the experimental label to the option description
    powercap/drivers/dtpm: Fix root node initialization
    PM: runtime: Update device status before letting suppliers suspend

    Linus Torvalds
     
  • Pull ACPI fix from Rafael Wysocki:
    "Make the empty stubs of some helper functions used when CONFIG_ACPI is
    not set actually match those functions (Andy Shevchenko)"

    * tag 'acpi-5.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
    ACPI: bus: Constify is_acpi_node() and friends (part 2)

    Linus Torvalds
     
  • Pull iommu fixes from Joerg Roedel:

    - Fix a sleeping-while-atomic issue in the AMD IOMMU code

    - Disable lazy IOTLB flush for untrusted devices in the Intel VT-d
    driver

    - Fix status code definitions for Intel VT-d

    - Fix IO Page Fault issue in Tegra IOMMU driver

    * tag 'iommu-fixes-v5.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu:
    iommu/vt-d: Fix status code for Allocate/Free PASID command
    iommu: Don't use lazy flush for untrusted device
    iommu/tegra-smmu: Fix mc errors on tegra124-nyan
    iommu/amd: Fix sleeping in atomic in increase_address_space()

    Linus Torvalds
     
  • Pull btrfs fixes from David Sterba:
    "More regression fixes and stabilization.

    Regressions:

    - zoned mode
    - count zone sizes in wider int types
    - fix space accounting for read-only block groups

    - subpage: fix page tail zeroing

    Fixes:

    - fix spurious warning when remounting with free space tree

    - fix warning when creating a directory with smack enabled

    - ioctl checks for qgroup inheritance when creating a snapshot

    - qgroup
    - fix missing unlock on error path in zero range
    - fix amount of released reservation on error
    - fix flushing from unsafe context with open transaction,
    potentially deadlocking

    - minor build warning fixes"

    * tag 'for-5.12-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
    btrfs: zoned: do not account freed region of read-only block group as zone_unusable
    btrfs: zoned: use sector_t for zone sectors
    btrfs: subpage: fix the false data csum mismatch error
    btrfs: fix warning when creating a directory with smack enabled
    btrfs: don't flush from btrfs_delayed_inode_reserve_metadata
    btrfs: export and rename qgroup_reserve_meta
    btrfs: free correct amount of space in btrfs_delayed_inode_reserve_metadata
    btrfs: fix spurious free_space_tree remount warning
    btrfs: validate qgroup inherit for SNAP_CREATE_V2 ioctl
    btrfs: unlock extents in btrfs_zero_range in case of quota reservation errors
    btrfs: ref-verify: use 'inline void' keyword ordering

    Linus Torvalds
     
  • Pull devicetree fixes from Rob Herring:

    - Another batch of graph and video-interfaces schema conversions

    - Drop DT header symlink for dropped C6X arch

    - Fix bcm2711-hdmi schema error

    * tag 'devicetree-fixes-for-5.12-1' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux:
    dt-bindings: media: Use graph and video-interfaces schemas, round 2
    dts: drop dangling c6x symlink
    dt-bindings: bcm2711-hdmi: Fix broken schema

    Linus Torvalds
     
  • Pull tracing fixes from Steven Rostedt:
    "Functional fixes:

    - Fix big endian conversion for arm64 in recordmcount processing

    - Fix timestamp corruption in ring buffer on discarding events

    - Fix memory leak in __create_synth_event()

    - Skip selftests if tracing is disabled as it will cause them to
    fail.

    Non-functional fixes:

    - Fix help text in Kconfig

    - Remove duplicate prototype for trace_empty()

    - Fix stale comment about the trace_event_call flags.

    Self test update:

    - Add more information to the validation output of when a corrupt
    timestamp is found in the ring buffer, and also trigger a warning
    to make sure that tests catch it"

    * tag 'trace-v5.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
    tracing: Fix comment about the trace_event_call flags
    tracing: Skip selftests if tracing is disabled
    tracing: Fix memory leak in __create_synth_event()
    ring-buffer: Add a little more information and a WARN when time stamp going backwards is detected
    ring-buffer: Force before_stamp and write_stamp to be different on discard
    tracing: Fix help text of TRACEPOINT_BENCHMARK in Kconfig
    tracing: Remove duplicate declaration from trace.h
    ftrace: Have recordmcount use w8 to read relp->r_info in arm64_is_fake_mcount

    Linus Torvalds
     
  • In rxe_comp.c in rxe_completer() the function free_pkt() did not clear skb
    which triggered a warning at 'done:' and could possibly at 'exit:'. The
    WARN_ONCE() calls are not actually needed. The call to free_pkt() is
    moved to the end to clearly show that all skbs are freed.

    Fixes: 899aba891cab ("RDMA/rxe: Fix FIXME in rxe_udp_encap_recv()")
    Link: https://lore.kernel.org/r/20210304192048.2958-1-rpearson@hpe.com
    Signed-off-by: Bob Pearson
    Signed-off-by: Jason Gunthorpe

    Bob Pearson
     
  • rxe_rcv_mcast_pkt() dropped a reference to ib_device when no error
    occurred causing an underflow on the reference counter. This code is
    cleaned up to be clearer and easier to read.

    Fixes: 899aba891cab ("RDMA/rxe: Fix FIXME in rxe_udp_encap_recv()")
    Link: https://lore.kernel.org/r/20210304192048.2958-1-rpearson@hpe.com
    Signed-off-by: Bob Pearson
    Signed-off-by: Jason Gunthorpe

    Bob Pearson
     
  • When the noted patch below extending the reference taken by
    rxe_get_dev_from_net() in rxe_udp_encap_recv() until each skb is freed it
    was not matched by a reference in the loopback path resulting in
    underflows.

    Fixes: 899aba891cab ("RDMA/rxe: Fix FIXME in rxe_udp_encap_recv()")
    Link: https://lore.kernel.org/r/20210304192048.2958-1-rpearson@hpe.com
    Signed-off-by: Bob Pearson
    Signed-off-by: Jason Gunthorpe

    Bob Pearson
     
  • 45d189c606292 ("io_uring: replace force_nonblock with flags") did
    something strange for io_openat() slicing all issue_flags but
    IO_URING_F_NONBLOCK. Not a bug for now, but better to just forward the
    flags.

    Signed-off-by: Pavel Begunkov
    Signed-off-by: Jens Axboe

    Pavel Begunkov
     
  • Pull NVMe fixes from Christoph:

    "nvme fixes for 5.12:

    - more device quirks (Julian Einwag, Zoltán Böszörményi, Pascal Terjan)
    - fix a hwmon error return (Daniel Wagner)
    - fix the keep alive timeout initialization (Martin George)
    - ensure the model_number can't be changed on a used subsystem
    (Max Gurtovoy)"

    * tag 'nvme-5.12-2021-03-05' of git://git.infradead.org/nvme:
    nvmet: model_number must be immutable once set
    nvme-fabrics: fix kato initialization
    nvme-hwmon: Return error code when registration fails
    nvme-pci: add quirks for Lexar 256GB SSD
    nvme-pci: mark Kingston SKC2000 as not supporting the deepest power state
    nvme-pci: mark Seagate Nytro XM1440 as QUIRK_NO_NS_DESC_LIST.

    Jens Axboe
     

05 Mar, 2021

15 commits

  • We have this weird true/false return from parking, and then some of the
    callers decide to look at that. It can lead to unbalanced parks and
    sqd locking. Have the callers check the thread status once it's parked.
    We know we have the lock at that point, so it's either valid or it's NULL.

    Fix race with parking on thread exit. We need to be careful here with
    ordering of the sdq->lock and the IO_SQ_THREAD_SHOULD_PARK bit.

    Rename sqd->completion to sqd->parked to reflect that this is the only
    thing this completion event doesn.

    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • If we race with shutting down the io-wq context and someone queueing
    a hashed entry, then we can exit the manager with it armed. If it then
    triggers after the manager has exited, we can have a use-after-free where
    io_wqe_hash_wake() attempts to wake a now gone manager process.

    Move the killing of the hashed write queue into the manager itself, so
    that we know we've killed it before the task exits.

    Fixes: e941894eae31 ("io-wq: make buffered file write hashed work map per-ctx")
    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • The callback can only be armed, if we get -EIOCBQUEUED returned. It's
    important that we clear the WAITQ bit for other cases, otherwise we can
    queue for async retry and filemap will assume that we're armed and
    return -EAGAIN instead of just blocking for the IO.

    Cc: stable@vger.kernel.org # 5.9+
    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • It doesn't make sense to wait for more events to come in, if we can't
    even flush the overflow we already have to the ring. Return -EBUSY for
    that condition, just like we do for attempts to submit with overflow
    pending.

    Cc: stable@vger.kernel.org # 5.11
    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • This allows us to do task creation and setup without needing to use
    completions to try and synchronize with the starting thread. Get rid of
    the old io_wq_fork_thread() wrapper, and the 'wq' and 'worker' startup
    completion events - we can now do setup before the task is running.

    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • * powercap:
    powercap/drivers/dtpm: Add the experimental label to the option description
    powercap/drivers/dtpm: Fix root node initialization

    Rafael J. Wysocki
     
  • In case we have already established connection to nvmf target, it
    shouldn't be allowed to change the model_number. E.g. if someone will
    identify ctrl and get model_number of "my_model" later on will change
    the model_numbel via configfs to "my_new_model" this will break the NVMe
    specification for "Get Log Page – Persistent Event Log" that refers to
    Model Number as: "This field contains the same value as reported in the
    Model Number field of the Identify Controller data structure, bytes
    63:24."

    Although it doesn't mentioned explicitly that this field can't be
    changed, we can assume it.

    So allow setting this field only once: using configfs or in the first
    identify ctrl operation.

    Signed-off-by: Max Gurtovoy
    Signed-off-by: Christoph Hellwig

    Max Gurtovoy
     
  • Currently kato is initialized to NVME_DEFAULT_KATO for both
    discovery & i/o controllers. This is a problem specifically
    for non-persistent discovery controllers since it always ends
    up with a non-zero kato value. Fix this by initializing kato
    to zero instead, and ensuring various controllers are assigned
    appropriate kato values as follows:

    non-persistent controllers - kato set to zero
    persistent controllers - kato set to NVMF_DEV_DISC_TMO
    (or any positive int via nvme-cli)
    i/o controllers - kato set to NVME_DEFAULT_KATO
    (or any positive int via nvme-cli)

    Signed-off-by: Martin George
    Signed-off-by: Christoph Hellwig

    Martin George
     
  • The hwmon pointer wont be NULL if the registration fails. Though the
    exit code path will assign it to ctrl->hwmon_device. Later
    nvme_hwmon_exit() will try to free the invalid pointer. Avoid this by
    returning the error code from hwmon_device_register_with_info().

    Fixes: ed7770f66286 ("nvme/hwmon: rework to avoid devm allocation")
    Signed-off-by: Daniel Wagner
    Signed-off-by: Christoph Hellwig

    Daniel Wagner
     
  • Add the NVME_QUIRK_NO_NS_DESC_LIST and NVME_QUIRK_IGNORE_DEV_SUBNQN
    quirks for this buggy device.

    Reported and tested in https://bugs.mageia.org/show_bug.cgi?id=28417

    Signed-off-by: Pascal Terjan
    Signed-off-by: Christoph Hellwig

    Pascal Terjan
     
  • My 2TB SKC2000 showed the exact same symptoms that were provided
    in 538e4a8c57 ("nvme-pci: avoid the deepest sleep state on
    Kingston A2000 SSDs"), i.e. a complete NVME lockup that needed
    cold boot to get it back.

    According to some sources, the A2000 is simply a rebadged
    SKC2000 with a slightly optimized firmware.

    Adding the SKC2000 PCI ID to the quirk list with the same workaround
    as the A2000 made my laptop survive a 5 hours long Yocto bootstrap
    buildfest which reliably triggered the SSD lockup previously.

    Signed-off-by: Zoltán Böszörményi
    Signed-off-by: Christoph Hellwig

    Zoltán Böszörményi
     
  • The kernel fails to fully detect these SSDs, only the character devices
    are present:

    [ 10.785605] nvme nvme0: pci function 0000:04:00.0
    [ 10.876787] nvme nvme1: pci function 0000:81:00.0
    [ 13.198614] nvme nvme0: missing or invalid SUBNQN field.
    [ 13.198658] nvme nvme1: missing or invalid SUBNQN field.
    [ 13.206896] nvme nvme0: Shutdown timeout set to 20 seconds
    [ 13.215035] nvme nvme1: Shutdown timeout set to 20 seconds
    [ 13.225407] nvme nvme0: 16/0/0 default/read/poll queues
    [ 13.233602] nvme nvme1: 16/0/0 default/read/poll queues
    [ 13.239627] nvme nvme0: Identify Descriptors failed (8194)
    [ 13.246315] nvme nvme1: Identify Descriptors failed (8194)

    Adding the NVME_QUIRK_NO_NS_DESC_LIST fixes this problem.

    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205679
    Signed-off-by: Julian Einwag
    Signed-off-by: Christoph Hellwig
    Reviewed-by: Keith Busch

    Julian Einwag
     
  • Pull drm fixes from Dave Airlie:
    "More may show up but this is what I have at this stage: just a single
    nouveau regression fix, and a bunch of amdgpu fixes.

    amdgpu:
    - S0ix fix
    - Handle new NV12 SKU
    - Misc power fixes
    - Display uninitialized value fix
    - PCIE debugfs register access fix

    nouveau:
    - regression fix for gk104"

    * tag 'drm-fixes-2021-03-05' of git://anongit.freedesktop.org/drm/drm:
    drm/amdgpu: fix parameter error of RREG32_PCIE() in amdgpu_regs_pcie
    drm/amd/display: fix the return of the uninitialized value in ret
    drm/amdgpu: enable BACO runpm by default on sienna cichlid and navy flounder
    drm/amd/pm: correct Arcturus mmTHM_BACO_CNTL register address
    drm/amdgpu/swsmu/vangogh: Only use RLCPowerNotify msg for disable
    drm/amdgpu/pm: make unsupported power profile messages debug
    drm/amdgpu:disable VCN for Navi12 SKU
    drm/amdgpu: Only check for S0ix if AMD_PMC is configured
    drm/nouveau/fifo/gk104-gp1xx: fix creation of sw class

    Linus Torvalds
     
  • Pull iSCSI fixes from Martin Petersen:
    "Three fixes for missed iSCSI verification checks (and make the sysfs
    files use "sysfs_emit()" - that's what it is there for)"

    * tag 'mkp-scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi:
    scsi: iscsi: Verify lengths on passthrough PDUs
    scsi: iscsi: Ensure sysfs attributes are limited to PAGE_SIZE
    scsi: iscsi: Restrict sessions and handles to admin capabilities

    Linus Torvalds
     
  • …f/linux into drm-fixes

    amd-drm-fixes-5.12-2021-03-03:

    amdgpu:
    - S0ix fix
    - Handle new NV12 SKU
    - Misc power fixes
    - Display uninitialized value fix
    - PCIE debugfs register access fix

    Signed-off-by: Dave Airlie <airlied@redhat.com>
    From: Alex Deucher <alexander.deucher@amd.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210304043255.3792-1-alexander.deucher@amd.com

    Dave Airlie