25 Jan, 2008

2 commits

  • This moves the block devices to /sys/class/block. It will create a
    flat list of all block devices, with the disks and partitions in one
    directory. For compatibility /sys/block is created and contains symlinks
    to the disks.

    /sys/class/block
    |-- sda -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda
    |-- sda1 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1
    |-- sda10 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda10
    |-- sda5 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda5
    |-- sda6 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda6
    |-- sda7 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda7
    |-- sda8 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda8
    |-- sda9 -> ../../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda9
    `-- sr0 -> ../../devices/pci0000:00/0000:00:1f.2/host1/target1:0:0/1:0:0:0/block/sr0

    /sys/block/
    |-- sda -> ../devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda
    `-- sr0 -> ../devices/pci0000:00/0000:00:1f.2/host1/target1:0:0/1:0:0:0/block/sr0

    Signed-off-by: Kay Sievers
    Signed-off-by: Greg Kroah-Hartman

    Kay Sievers
     
  • Signed-off-by: Tony Jones
    Cc: Gadi Oxman
    Cc: Kay Sievers
    Signed-off-by: Greg Kroah-Hartman

    Tony Jones
     

12 Jan, 2008

1 commit


11 Jan, 2008

3 commits

  • Using default methods caused the chip's DMA PRD count registers, inadvertently
    starting DMA! While fixing it, also do:

    - get rid of the 'ide_' prefixes in several functions for which the prefix in
    the method's name has been 'ide_' ectomized already;

    - align the code hooking the IDE DMA methods in init_hwif_trm290()...

    Signed-off-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Sergei Shtylyov
     
  • Signed-off-by: George Kibardin
    Signed-off-by: Bartlomiej Zolnierkiewicz

    George Kibardin
     
  • http://bugzilla.kernel.org/show_bug.cgi?id=9673

    ACPI _PS3 cause S4 breaks in the second attempt. The system has a _PS3
    method for IDE, which will call into SMM mode. Currently we haven't clue
    why just the second attempt fails, as it's totally in BIOS code, so
    blacklist the system so far for 2.6.24.

    A possible suspect is ACPI NVS isn't save/restore, we will revisit the
    bug after linux does ACPI NVS save/restore.

    Bart:
    - fix scripts/checkpatch.pl complaints
    - const-ify ide_acpi_dmi_table[]

    Signed-off-by: Shaohua Li
    Cc: "Rafael J. Wysocki"
    Reported-by: Mikko Vinni
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Shaohua Li
     

24 Dec, 2007

11 commits


13 Dec, 2007

13 commits

  • set_io_32bit() (ide_procset_t function) can race against running
    PIO transfers. Fix it by using ide_spin_wait_hwgroup().

    Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • After looking into the HPT370 manual (now that I have it) and re-checking all
    the timing tables, here's what I have discovered:

    - at 33 MHz clock, PIO mode 0 timings turned to be overclocked, and all other
    PIO modes underclocked;

    - at 50 MHz clock, PIO modes 0 to 2 turned to be overclocked;

    - at 66 MHz clock, PIO mode 0 was overclocked too.

    Finally, the taskfile timing (matching PIO mode 0) turned to be overclocked at
    all clock frequencies (and in all manuals)...

    The new timings have been tested on HPT370 chip (at 33 MHz PCI clock) and on
    HPT371N chip (at both 50 and 66 MHz DPLL clock).

    Signed-off-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Sergei Shtylyov
     
  • In case of Promise TX4 the first PCI device is located at slot 1
    and the second one is at slot 2 so the offset used by pci_get_slot()
    should be "+1" and not "+2".

    Thanks goes out to Markus Dietz for bugreport and testing this patch.

    Cc: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • post_transform_command() call in cdrom_newpc_intr() has no effect because
    it is done after the request has already been fully completed (rq->bio and
    rq->data are always NULL). It was verified to be true regardless whether
    INQUIRY command is using DMA or PIO to transfer data (by using modified
    Tejun Heo's test-shortsg.c utility and adding a few printk()-s to ide-cd).

    This was uncovered thanks to the "blk_end_request: full I/O completion
    handler (take 3)" patch series from Kiyoshi Ueda.

    Cc: jens.axboe@oracle.com
    Cc: bharrosh@panasas.com
    Cc: Kiyoshi Ueda
    Cc: Tejun Heo
    Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • * ide_xfer_verbose() fixups:
    - beautify returned mode names
    - fix PIO5 reporting
    - make it return 'const char *'

    * Change printk() level from KERN_DEBUG to KERN_INFO in ide_find_dma_mode().

    * Add ide_id_dma_bug() helper based on ide_dma_verbose() to check for invalid
    DMA info in identify block.

    * Use ide_id_dma_bug() in ide_tune_dma() and ide_driveid_update().

    As a result DMA won't be tuned or will be disabled after tuning if device
    reports inconsistent info about enabled DMA mode (ide_dma_verbose() does the
    same checks while the IDE device is probed by ide-{cd,disk} device driver).

    * Remove no longer needed ide_dma_verbose().

    This patch should fix the following problem with out-of-sync IDE messages
    reported by Nick Warne:

    hdd: ATAPI 48X DVD-ROM DVD-R-RAM CD-R/RW drive, 2048kB Cachehdd:
    skipping word 93 validity check
    , UDMA(66)

    and later debugged by Mark Lord to be caused by:

    ide_dma_verbose()
    printk( ... "2048kB Cache");
    eighty_ninty_three()
    printk(KERN_DEBUG "%s: skipping word 93 validity check\n");
    ide_dma_verbose()
    printk(", UDMA(66)"

    Please note that as a result ide-{cd,disk} device drivers won't report the
    DMA speed used but this is intended since now DMA mode being used is always
    reported by IDE core code.

    v2:
    * fixes suggested by Randy:
    - use KERN_CONT for printk()-s in ide-{cd,disk}.c
    - don't remove argument name from ide_xfer_verbose() declaration

    v3:
    * Remove incorrect check for (id->field_valid & 1) from ide_id_dma_bug()
    (spotted by Sergei).

    * "XFER SLOW" -> "PIO SLOW" in ide_xfer_verbose() (suggested by Sergei).

    * Fix ide_find_dma_mode() to report the correct mode ('mode' after being
    limited by 'req_mode').

    Cc: Sergei Shtylyov
    Cc: Nick Warne
    Cc: Mark Lord
    Cc: Randy Dunlap
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Cc: Dan Kegel
    Cc: Kay Sievers
    Cc: Xavier Bestel
    Cc: Andrey Borzenkov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • * remove trailing whitespaces
    * 'if()' -> 'if ()'
    * remove extra new-line before EXPORT_SYMBOL_GPL()
    * add extra new-line after 'id' definition
    * respect 80-columns limit

    There should be no functionality changes caused by this patch.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Add missing checks for control register existence (some legacy m68k specific
    IDE controllers don't have it). Also use drive->ctl while at it.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

28 Nov, 2007

10 commits