27 Jul, 2010
9 commits
-
If the function is exported, the EXPORT* macro for it should follow immediately
after the closing function brace line.Signed-off-by: Changli Gao
----
net/netlink/genetlink.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
Signed-off-by: David S. Miller -
Signed-off-by: Jonas Bonn
Signed-off-by: David S. Miller -
On a reset the MDICNFG.Destination and MDICNFG.COM_MDIO
register fields are not restored to the EEPROM default.
This patch modifies the reset code to read the EEPROM
and restore the default values.Signed-off-by: Nicholas Nunley
Tested-by: Jeff Pieper
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
This patch adds support for external MDIO PHYs, in addition to
the standard SFP support for SGMII PHYs over the I2C interface.Signed-off-by: Nicholas Nunley
Tested-by: Jeff Pieper
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
err is set again a few lines below.
Cc: Jesse Brandeburg
Signed-off-by: Jean Delvare
Acked-by: Bruce Allan
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Remove typedefs
Indentation and spacing
Use a temporary for a very long pointer variable
More 80 column compatible
Convert a switch to if/else ifCompile tested only, depends on patch "Update logging message style"
(old)
$ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
total: 209 errors, 82 warnings, 3995 lines checked(new)
$ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
total: 2 errors, 0 warnings, 3970 lines checked$ size drivers/net/qla3xxx.o.*
text data bss dec hex filename
50413 212 13864 64489 fbe9 drivers/net/qla3xxx.o.old
49959 212 13728 63899 f99b drivers/net/qla3xxx.o.newSigned-off-by: Joe Perches
Signed-off-by: David S. Miller -
Use pr_
Use netdev_
Use netif_
Remove #define PFX
Improve a couple of loops to avoid deep indentation.Compile tested only
$ size drivers/net/qla3xxx.o.*
text data bss dec hex filename
51603 212 13864 65679 1008f drivers/net/qla3xxx.o.old
50413 212 13864 64489 fbe9 drivers/net/qla3xxx.o.newSigned-off-by: Joe Perches
Signed-off-by: David S. Miller -
WIRELESS_EXT is not the correct dependency.
Signed-off-by: David S. Miller
-
commit 1dacc76d0014
(net/compat/wext: send different messages to compat tasks)
introduced a race condition on netlink, in case MSG_PEEK is used.An skb given by skb_recv_datagram() might be shared, we must copy it
before any modification, or risk fatal corruption.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
26 Jul, 2010
5 commits
-
The macros for the values of the bit field describing the four
different versions of statistics supported by different hardware
variants were being misused. Where the code was trying to test if the
hardware implements V3, it was actually testing whether it implements
any of V1, V2, or V3, causing the driver to report statistics that
don't really exist in the hardware, with bogus values.Signed-off-by: Mike Ditto
Signed-off-by: David S. Miller -
Fix an overflow bug in vmxnet3 Tx descriptor
This patch fixes a bug where a 16K buffer on a Tx descriptor was overflowing
into the 'gen' bit in the descriptor thereby corrupting the descriptor and
stalling the transmit ring.Signed-off-by: Bhavesh Davda
Signed-off-by: Shreyas Bhatewara
Signed-off-by: Matthew Delco
Signed-off-by: Ronghua Zhang
Signed-off-by: David S. Miller -
This patch adds wrappers for ethtool to get or set wake-on-LAN
setting without re-inserting the kernel module.Signed-off-by: Andrew O. Shadoura
Signed-off-by: David S. Miller -
netif_device_attach missing from error path in qlcnic_diag_alloc_res
Signed-off-by: Sony Chacko
Signed-off-by: Amit Kumar Salecha
Signed-off-by: David S. Miller -
o Loopback not supported for virtual function.
Signed-off-by: Amit Kumar Salecha
Signed-off-by: David S. Miller
25 Jul, 2010
4 commits
-
Move frags[] at the end of struct skb_shared_info, and make
pskb_expand_head() copy only the used part of it instead of whole array.This should avoid kmemcheck warnings and speedup pskb_expand_head() as
well, avoiding a lot of cache misses.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
Add addr_assign_type to struct net_device and expose it via sysfs.
This new attribute has the purpose of giving user-space the ability to
distinguish between different assignment types of MAC addresses.For example user-space can treat NICs with randomly generated MAC
addresses differently than NICs that have permanent (locally assigned)
MAC addresses.
For the former udev could write a persistent net rule by matching the
device path instead of the MAC address.
There's also the case of devices that 'steal' MAC addresses from slave
devices. In which it is also be beneficial for user-space to be aware
of the fact.This patch also introduces a helper function to assist adoption of
drivers that generate MAC addresses randomly.Signed-off-by: Stefan Assmann
Signed-off-by: David S. Miller -
In latest changes about 64bit stats on 32bit arches,
[commit 28172739f0a276eb8 (net: fix 64 bit counters on 32 bit arches)],
I missed ixgbe uses a bit of magic in its ixgbe_gstrings_stats
definition.IXGBE_NETDEV_STAT() must now assume offsets relative to
rtnl_link_stats64, not relative do dev->stats.As a bonus, we also get 64bit stats on ethtool -S
Signed-off-by: Eric Dumazet
Tested-by: Stephen Ko
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Fix maximum and minmum bandwith value.
Signed-off-by: Rajesh Borundia
Signed-off-by: Amit Kumar Salecha
Signed-off-by: David S. Miller
24 Jul, 2010
22 commits
-
Conflicts:
drivers/net/wireless/iwlwifi/iwl-commands.h -
commit a095cfc40ec7ebe63e9532383c5b5c2a27b14075
"3c59x: Specify window explicitly for access to windowed registers"
changed the first parameter to mdio_sync(), from a pointer to the
register mapping, to a pointer to the vortex_private structure,
and changed all but one of the call sites. Fix that last one.Reported-by: Luca Falavigna
Signed-off-by: Ben Hutchings
Signed-off-by: David S. Miller -
vpd_data[] is allocated as kmalloc(256, GFP_KERNEL), so if cnt = 255
then (cnt + 3) overflows 256. memset() is executed without checking.
vpd_data[cnt+2] must be less than 256-cnt-2 as the latter is number of
vpd_data[] elements to copy.Do not fill with zero the beginning of nic->serial_num as it will
be filled with vpd_data[].String in product_name[] should be terminated by '\0'.
Signed-off-by: Kulikov Vasiliy
Signed-off-by: David S. Miller -
We assume that "pd" can be null on the previous line, and throughout the
function so we should check it here as well. This was introduced by
9b2c2ff7a1c0 "mv643xx_eth: use sw csum for big packets"Signed-off-by: Dan Carpenter
Acked-by: Lennert Buytenhek
Signed-off-by: David S. Miller -
If vortex_probe1() fails we should unmap ioaddr mapped earlier.
Signed-off-by: Kulikov Vasiliy
Signed-off-by: David S. Miller -
Signed-off-by: Andy Shevchenko
Signed-off-by: David S. Miller -
Signed-off-by: Andy Shevchenko
Cc: Corey Thomas
Cc: "John W. Linville"
Cc: linux-wireless@vger.kernel.org
Signed-off-by: David S. Miller -
Signed-off-by: Andy Shevchenko
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Signed-off-by: David S. Miller -
Signed-off-by: Andy Shevchenko
Signed-off-by: David S. Miller -
Signed-off-by: Andy Shevchenko
Cc: Chas Williams
Cc: linux-atm-general@lists.sourceforge.net
Signed-off-by: David S. Miller -
Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
This patch changes names of some variables.
Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
When a virtual function driver in initialized, the network mac
query command can fail. Skip display of error message in that case.Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
If a mac address has not been configured for a VF,
there is no need to call be_cmd_pmac_del.Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
Function qeth_l2_remove_device invokes qeth_l2_del_all_mc at the end.
This is needless, because it is already called in the offline function.
And even more this is invalid, because multicast addresses cannot be
removed in DOWN state. Thus this patch deletes invocation of
qeth_l2_del_all_mc in function qeth_l2_remove_device.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)//
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@- to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+ to = memdup_user(from,size);
if (
- to==NULL
+ IS_ERR(to)
|| ...) {
}
- if (copy_from_user(to, from, size) != 0) {
-
- }
//Signed-off-by: Julia Lawall
Signed-off-by: Andrew Morton
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
Reply callback functions in qeth should return zero if command
response consists of one part only, otherwise qeth continues
waiting for further parts of the command response.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
When creating a claw device, just 2 subchannels have to be grouped.
Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
If qeth issues an ipa command, but for some reasons the response
never comes back, qeth reaches a timeout.
Reset the irq_pending flag of the write channel in timeout handling
code and trigger a recovery to avoid endless looping for the following
ipa command.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller
