25 Feb, 2010

1 commit

  • To fix a bug and address the reviewers' comments regarding the ACPI
    GPE refcounting patch, do the following additional changes:

    o Remove the second argument of acpi_ev_enable_gpe(),
    'write_to_hardware', because it is not necessary any more.

    o Add the "bad parameter" test against 'type' in
    acpi_enable_gpe() and acpi_disable_gpe().

    o Make acpi_enable_gpe() only check 'status' for runtime GPEs if
    acpi_ev_enable_gpe() was actually called.

    o Make acpi_disable_gpe() return 'status' returned by
    acpi_ev_disable_gpe() and fix a bug where ACPI_GPE_TYPE_WAKE
    and ACPI_GPE_TYPE_RUNTIME were exchanged by mistake.

    o Add comments explaining why acpi_set_gpe() is used by the ACPI EC
    driver.

    Signed-off-by: Rafael J. Wysocki
    Signed-off-by: Jesse Barnes

    Rafael J. Wysocki
     

23 Feb, 2010

1 commit

  • ACPI GPEs may map to multiple devices. The current GPE interface
    only provides a mechanism for enabling and disabling GPEs, making
    it difficult to change the state of GPEs at runtime without extensive
    cooperation between devices.

    Add an API to allow devices to indicate whether or not they want
    their device's GPE to be enabled for both runtime and wakeup events.

    Remove the old GPE type handling entirely, which gets rid of various
    quirks, like the implicit disabling with GPE type setting. This
    requires a small amount of rework in order to ensure that non-wake
    GPEs are enabled by default to preserve existing behaviour.

    Based on patches from Matthew Garrett .

    Signed-off-by: Matthew Garrett
    Signed-off-by: Rafael J. Wysocki
    Signed-off-by: Jesse Barnes

    Rafael J. Wysocki
     

27 Aug, 2009

1 commit


28 Mar, 2009

1 commit


09 Jan, 2009

2 commits