09 Feb, 2010
1 commit
-
Test the value that was just allocated rather than the previously tested one.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@r@
expression *x;
expression e;
identifier l;
@@if (x == NULL || ...) {
... when forall
return ...; }
... when != goto l;
when != x = e
when != &x
*x == NULL
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller
25 Mar, 2009
2 commits
-
Implement a way to provide the MAC address for ax88796 devices from
their platform data. Boards might decide to set the address
programmatically, taken from boot tags or other sources.Signed-off-by: Daniel Mack
Signed-off-by: David S. Miller -
This patch adds support to the ax88796 ethernet driver to take IRQ flags
given by the platform_device definition.Signed-off-by: Daniel Mack
Signed-off-by: David S. Miller
15 Jan, 2009
1 commit
-
This patch hooks up the start_xmit/tx_timeout/get_stats callbacks
in the ax88796 driver since they no longer are installed by the
lib8390 code. Without this patch the function dev_hard_start_xmit()
crashes due to a start_xmit callback with the value NULL.While at it, update the ax88796 driver to make use of use of struct
net_device_ops.Signed-off-by: Magnus Damm
Signed-off-by: David S. Miller
28 Oct, 2008
1 commit
-
This converts pretty much everything to print_mac. There were
a few things that had conflicts which I have just dropped for
now, no harm done.I've built an allyesconfig with this and looked at the files
that weren't built very carefully, but it's a huge patch.Signed-off-by: Johannes Berg
Signed-off-by: David S. Miller
22 Oct, 2008
1 commit
-
dev->irq is unsigned
Signed-off-by: Roel Kluin
Signed-off-by: Jeff Garzik
25 Sep, 2008
1 commit
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik
14 Aug, 2008
1 commit
-
Fix a pair of nasty locking problems in the ax88796 driver
spotted by a sparse check:warning: context imbalance in 'ax_get_settings' - wrong count at exit
warning: context imbalance in 'ax_set_settings' - wrong count at exitSigned-off-by: Ben Dooks
Signed-off-by: Jeff Garzik
25 Apr, 2008
1 commit
-
Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is
prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable network
platform drivers, to re-enable auto loading.NOTE: didn't change drivers/net/fs_enet/fs_enet-main.c "old binding" support.
That looks problematic in the first place (it even uses the ancient "struct
device_driver" binding scheme for platform_bus!) and I suspect it will vanish
soonish when arch/powerpc rules the world. Also, drivers/net/ne.c would have
needed more thought to sort out.[akpm@linux-foundation.org: fix sgiseeq.c]
[dbrownell@users.sourceforge.net: more drivers, registration fixes]
Signed-off-by: Kay Sievers
Signed-off-by: David Brownell
Cc: Scott Wood
Cc: Vitaly Bordug
Cc: Dale Farnsworth
Cc: Ben Dooks
Cc: Ralf Baechle
Cc: Andrew Victor
Cc: Bryan Wu
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik
03 Feb, 2008
1 commit
-
Change to using dev_dbg() and the other dev_xxx()
macros instead of printk, and update to use the
print_mac() helper.Signed-off-by: Ben Dooks
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller
19 Oct, 2007
1 commit
-
Found these while looking at printk uses.
Add missing newlines to dev_ uses
Add missing KERN_ prefixes to multiline dev_s
Fixed a wierd->weird spelling typo
Added a newline to a printkSigned-off-by: Joe Perches
Cc: "Luck, Tony"
Cc: Jens Axboe
Cc: Mark M. Hoffman
Cc: Roland Dreier
Cc: Tilman Schmidt
Cc: David Woodhouse
Cc: Jeff Garzik
Cc: Stephen Hemminger
Cc: Greg KH
Cc: Jeremy Fitzhardinge
Cc: Geert Uytterhoeven
Cc: Alessandro Zummo
Cc: David Brownell
Cc: James Smart
Cc: Andrew Vasquez
Cc: "Antonino A. Daplas"
Cc: Evgeniy Polyakov
Cc: Russell King
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Oct, 2007
1 commit
-
Hook up the 93cx6 eeprom code to the ax88796 driver and modify the ax88796
driver to read out the mac address from the eeprom. We need this for the
ax88796 on certain SuperH boards. The pin configuration used to connect
the eeprom to the ax88796 on these boards is the same as pointed out by the
ax88796 datasheet, so we can probably reuse this code for multiple
platforms in the future.Signed-off-by: Magnus Damm
Cc: Ben Dooks
Cc: Paul Mundt
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik
14 Aug, 2007
1 commit
-
drivers/net/ax88796.c: In function `ax_probe':
drivers/net/ax88796.c:825: warning: size_t format, different type arg (arg 4)
drivers/net/ax88796.c:825: warning: size_t format, different type arg (arg 5)resource_size_t isn't size_t.
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik
01 Aug, 2007
1 commit
-
All drivers implement ethtool get_perm_addr the same way -- by calling
the generic function. So we can inline the generic function into the
caller and avoid going through the drivers.Signed-off-by: Matthew Wilcox
Signed-off-by: David S. Miller
27 Jul, 2007
1 commit
-
Signed-off-by: Al Viro
Acked-by: Jeff Garzik
Signed-off-by: Linus Torvalds
16 Jul, 2007
1 commit
-
Signed-off-by: Al Viro
Acked-by: Jeff Garzik
Signed-off-by: Linus Torvalds
11 Jul, 2007
1 commit
-
Support for the Asix AX88796 network controller, an
NE2000 compatible 10/100 ethernet device with internal
PHY.The driver supports PHY settings via either ioctl() or
the ethtool driver ops.Signed-off-by: Ben Dooks
Signed-off-by: Jeff Garzik