04 Dec, 2009

1 commit

  • Only files where David Miller is the primary git-signer.
    wireless, wimax, ixgbe, etc are not modified.

    Compile tested x86 allyesconfig only
    Not all files compiled (not x86 compatible)

    Added a few > 80 column lines, which I ignored.
    Existing checkpatch complaints ignored.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

17 Jul, 2009

1 commit


13 Jul, 2009

2 commits


06 Jul, 2009

1 commit


13 Jun, 2009

1 commit


08 Jan, 2009

1 commit


26 Dec, 2008

2 commits

  • Fix this sparse warnings:

    drivers/net/3c523.c:350:6: warning: symbol 'alloc586' was not declared. Should it be static?
    drivers/net/cs89x0.c:1029:14: warning: symbol 'reset_chip' was not declared. Should it be static?
    drivers/net/eepro.c:1399:1: warning: symbol 'read_eeprom' was not declared. Should it be static?
    drivers/net/plip.c:1020:5: warning: symbol 'plip_hard_header_cache' was not declared. Should it be static?
    drivers/net/s2io.c:5116:6: warning: symbol 'do_s2io_store_unicast_mc' was not declared. Should it be static?
    drivers/net/smc9194.c:767:12: warning: symbol 'smc_findirq' was not declared. Should it be static?

    Signed-off-by: Hannes Eder
    Signed-off-by: David S. Miller

    Hannes Eder
     
  • While at it insert some extra curly braces and fix formatting.

    Fix this sparse warnings:

    drivers/net/atp.c:811:8: warning: do-while statement is not a compound statement
    drivers/net/atp.c:813:8: warning: do-while statement is not a compound statement
    drivers/net/atp.c:815:11: warning: do-while statement is not a compound statement
    drivers/net/atp.c:817:11: warning: do-while statement is not a compound statement
    drivers/net/plip.c:642:4: warning: do-while statement is not a compound statement
    drivers/net/plip.c:647:4: warning: do-while statement is not a compound statement
    drivers/net/plip.c:820:4: warning: do-while statement is not a compound statement
    drivers/net/plip.c:825:4: warning: do-while statement is not a compound statement
    drivers/net/starfire.c:886:3: warning: do-while statement is not a compound statement

    Signed-off-by: Hannes Eder
    Signed-off-by: David S. Miller

    Hannes Eder
     

04 Dec, 2008

1 commit


13 Nov, 2008

1 commit

  • We have some reasons to kill netdev->priv:
    1. netdev->priv is equal to netdev_priv().
    2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
    netdev_priv() is more flexible than netdev->priv.
    But we cann't kill netdev->priv, because so many drivers reference to it
    directly.

    This patch is a safe convert for netdev->priv to netdev_priv(netdev).
    Since all of the netdev->priv is only for read.
    But it is too big to be sent in one mail.
    I split it to 4 parts and make every part smaller than 100,000 bytes,
    which is max size allowed by vger.

    Signed-off-by: Wang Chen
    Signed-off-by: David S. Miller

    Wang Chen
     

04 Nov, 2008

1 commit


02 Apr, 2008

1 commit

  • Plip uses spin_lock_irq/spin_unlock_irq in its IRQ handler (called from
    parport IRQ handler), the latter enables interrupts without parport
    subsystem IRQ handler expecting it.

    The bug can be seen if you compile kernel with lock dependency checking
    and use plip --- it produces a warning.

    This patch changes it to spin_lock_irqsave/spin_lock_irqrestore, so that
    it doesn't enable interrupts when already disabled.

    Signed-off-by: Linus Torvalds

    Mikulas Patocka
     

29 Jan, 2008

1 commit


27 Nov, 2007

2 commits

  • Plip passes a string "name" that is allocated on stack to
    parport_register_device. parport_register_device holds the pointer to
    "name" and when the registering function exits, it points nowhere.

    On some machine, this bug causes bad names to appear in /proc, such as
    /proc/sys/dev/parport/parport0/devices/T^/�X^/�, on others, the plip
    proc node is completely missing.

    The patch also fixes documentation to note this requirement.

    Signed-off-by: Mikulas Patocka
    Signed-off-by: Linus Torvalds

    Mikulas Patocka
     
  • netif_rx is meant to be called from interrupts because it doesn't wake
    up ksoftirqd. For calling from outside interrupts, netif_rx_ni exists.

    This fixes plip to use netif_rx_ni. It fixes the infamous error "NOHZ:
    local_softirq_panding 08" that happens on some machines with NOHZ and
    plip --- it is caused by the fact that softirq is pending and ksoftirqd
    is sleeping.

    Signed-off-by: Mikulas Patocka
    Signed-off-by: Linus Torvalds

    Mikulas Patocka
     

24 Oct, 2007

1 commit


11 Oct, 2007

3 commits

  • Since hardware header operations are part of the protocol class
    not the device instance, make them into a separate object and
    save memory.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     
  • We now have struct net_device_stats embedded in struct net_device,
    and the default ->get_stats() hook does the obvious thing for us.

    Run through drivers/net/* and remove the driver-local storage of
    statistics, and driver-local ->get_stats() hook where applicable.

    This was just the low-hanging fruit in drivers/net; plenty more drivers
    remain to be updated.

    [ Resolved conflicts with napi_struct changes and fix sunqe build
    regression... -DaveM ]

    Signed-off-by: Jeff Garzik
    Signed-off-by: David S. Miller

    Jeff Garzik
     
  • It's been a useless no-op for long enough in 2.6 so I figured it's time to
    remove it. The number of people that could object because they're
    maintaining unified 2.4 and 2.6 drivers is probably rather small.

    [ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ]

    Signed-off-by: Ralf Baechle
    Signed-off-by: Jeff Garzik
    Signed-off-by: David S. Miller

    Ralf Baechle
     

26 Apr, 2007

1 commit

  • For the places where we need a pointer to the mac header, it is still legal to
    touch skb->mac.raw directly if just adding to, subtracting from or setting it
    to another layer header.

    This one also converts some more cases to skb_reset_mac_header() that my
    regex missed as it had no spaces before nor after '=', ugh.

    Signed-off-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Arnaldo Carvalho de Melo