08 Sep, 2020

1 commit

  • regulator_notifier_call_chain() doesn't need rdev lock and rdev's
    existence is assumed in the code anyway. Remove the locks from drivers.

    Signed-off-by: Michał Mirosław
    Acked-by: Adam Thomson
    Reviewed-by: Dmitry Osipenko
    Link: https://lore.kernel.org/r/42393f66dcc4d80dcd9797be45216b4035aa96cb.1597032945.git.mirq-linux@rere.qmqm.pl
    Signed-off-by: Mark Brown

    Michał Mirosław
     

13 Jan, 2020

1 commit

  • Use the new .probe_new for i2c drivers.
    These drivers do not use const struct i2c_device_id * argument, so convert
    them to utilise the simplified i2c driver registration.

    Signed-off-by: Axel Lin
    Link: https://lore.kernel.org/r/20200109155808.22003-1-axel.lin@ingics.com
    Signed-off-by: Mark Brown

    Axel Lin
     

03 May, 2019

1 commit


13 Mar, 2019

1 commit

  • The mutex for the regulator_dev must be controlled by the caller of
    the regulator_notifier_call_chain(), as described in the comment
    for that function.

    Failure to mutex lock and unlock surrounding the notifier call results
    in a kernel WARN_ON_ONCE() which will dump a backtrace for the
    regulator_notifier_call_chain() when that function call is first made.
    The mutex can be controlled using the regulator_lock/unlock() API.

    Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver")
    Suggested-by: Adam Thomson
    Signed-off-by: Steve Twiss
    Signed-off-by: Mark Brown

    Steve Twiss
     

04 Mar, 2019

2 commits


19 Feb, 2019

2 commits

  • Fix off-by-one while iterating current_limits array.
    The valid index should be 0 ~ n_current_limits -1.

    Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver")
    Signed-off-by: Axel Lin
    Signed-off-by: Mark Brown

    Axel Lin
     
  • There is no vsel_reg/vsel_mask settings for PV88060_ID_SWx, so don't use
    pv88060_ldo_ops for PV88060_SW. The PV88060_ID_SWx is fixed voltage,
    set .fixed_uV instead of .min_uV then regulator core will automatically
    support get_voltage and list_voltage.

    Signed-off-by: Axel Lin
    Signed-off-by: Mark Brown

    Axel Lin
     

01 Feb, 2017

1 commit

  • Declare regulator_ops structure as const as it is only stored in the ops
    field of a regulator_desc structure. This field is of type const, so
    regulator_ops structures having this property can be made const too.

    File size before: drivers/regulator/pv88060-regulator.o
    text data bss dec hex filename
    6195 752 8 6955 1b2b regulator/pv88060-regulator.o

    File size after: drivers/regulator/pv88060-regulator.o
    text data bss dec hex filename
    6739 240 8 6987 1b4b regulator/pv88060-regulator.o

    Signed-off-by: Bhumika Goyal
    Signed-off-by: Mark Brown

    Bhumika Goyal
     

30 May, 2016

1 commit


08 Mar, 2016

1 commit


01 Dec, 2015

1 commit


25 Nov, 2015

1 commit


21 Nov, 2015

1 commit