30 Sep, 2020

1 commit

  • autofs got broken in some configurations by commit 13c164b1a186
    ("autofs: switch to kernel_write") because there is now an extra LSM
    permission check done by security_file_permission() in rw_verify_area().

    autofs is one if the few places that really does want the much more
    limited __kernel_write(), because the write is an internal kernel one
    that shouldn't do any user permission checks (it also doesn't need the
    file_start_write/file_end_write logic, since it's just a pipe).

    There are a couple of other cases like that - accounting, core dumping,
    and splice - but autofs stands out because it can be built as a module.

    As a result, we need to export this internal __kernel_write() function
    again.

    We really don't want any other module to use this, but we don't have a
    "EXPORT_SYMBOL_FOR_AUTOFS_ONLY()". But we can mark it GPL-only to at
    least approximate that "internal use only" for licensing.

    While in this area, make autofs pass in NULL for the file position
    pointer, since it's always a pipe, and we now use a NULL file pointer
    for streaming file descriptors (see file_ppos() and commit 438ab720c675:
    "vfs: pass ppos=NULL to .read()/.write() of FMODE_STREAM files")

    This effectively reverts commits 9db977522449 ("fs: unexport
    __kernel_write") and 13c164b1a186 ("autofs: switch to kernel_write").

    Fixes: 13c164b1a186 ("autofs: switch to kernel_write")
    Reported-by: Ondrej Mosnacek
    Acked-by: Christoph Hellwig
    Acked-by: Acked-by: Ian Kent
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

08 Jul, 2020

1 commit


24 May, 2019

1 commit

  • Based on 1 normalized pattern(s):

    this file is part of the linux kernel and is made available under
    the terms of the gnu general public license version 2 or at your
    option any later version incorporated herein by reference

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 18 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Richard Fontana
    Reviewed-by: Allison Randal
    Reviewed-by: Armijn Hemel
    Reviewed-by: Kate Stewart
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190520075211.321157221@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

05 Jan, 2019

1 commit

  • Change the superblock info. catatonic setting to be part of a flags bit
    field.

    Link: http://lkml.kernel.org/r/154296973142.9889.17275721668508589639.stgit@pluto-themaw-net
    Signed-off-by: Ian Kent
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ian Kent
     

08 Jun, 2018

3 commits

  • We don't set "*name" so it's slightly nicer to just pass "name" instead
    of "&name".

    Link: http://lkml.kernel.org/r/20180531064736.lnisb55eajwjynvk@kili.mountain
    Signed-off-by: Dan Carpenter
    Acked-by: "Eric W. Biederman"
    Acked-by: Ian Kent
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dan Carpenter
     
  • Remove includes that aren't needed from autofs (and fs/compat_ioctl.c).

    Link: http://lkml.kernel.org/r/152635085258.5968.9743527195522188148.stgit@pluto.themaw.net
    Signed-off-by: Ian Kent
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ian Kent
     
  • Copy source files from the autofs4 directory to the autofs directory.

    Link: http://lkml.kernel.org/r/152626705013.28589.931913083997578251.stgit@pluto.themaw.net
    Signed-off-by: Ian Kent
    Cc: Al Viro
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ian Kent
     

06 Oct, 2010

1 commit

  • Nobody appears to be interested in fixing autofs3 bugs
    any more and it uses the BKL, which is going away.

    Move this to staging for retirement. Unless someone
    complains until 2.6.38, we can remove it for good.

    The include/linux/auto_fs.h header file is still used
    by autofs4, so it remains in place.

    Signed-off-by: Arnd Bergmann
    Cc: Ian Kent
    Cc: autofs@linux.kernel.org
    Cc: "H. Peter Anvin"
    Acked-by: H. Peter Anvin
    Signed-off-by: Greg Kroah-Hartman

    Arnd Bergmann
     

19 Oct, 2007

1 commit

  • Get rid of sparse related warnings from places that use integer as NULL
    pointer.

    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: Stephen Hemminger
    Cc: Andi Kleen
    Cc: Jeff Garzik
    Cc: Matt Mackall
    Cc: Ian Kent
    Cc: Arnd Bergmann
    Cc: Davide Libenzi
    Cc: Stephen Smalley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Stephen Hemminger
     

15 Nov, 2006

1 commit

  • Resolve the panic on failed mount of an autofs filesystem originally
    reported by Mao Bibo.

    It addresses two issues that happen after the mount fail. The first a NULL
    pointer reference to a field (pipe) in the autofs superblock info structure
    and second the lack of super block cleanup by the autofs and autofs4
    modules.

    Signed-off-by: Ian Kent
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ian Kent
     

07 Nov, 2005

1 commit

  • This is the fs/ part of the big kfree cleanup patch.

    Remove pointless checks for NULL prior to calling kfree() in fs/.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds