Eric Lee / smarc-fsl-linux-kernel

19 Jan, 2017

1 commit

  • 4a7c97264   net: Remove usage of net_device last_rx member ... Browse Code »

    The network stack no longer uses the last_rx member of struct net_device
    since the bonding driver switched to use its own private last_rx in
    commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").

    However, some drivers still (ab)use the field for their own purposes and
    some driver just update it without actually using it.

    Previously, there was an accompanying comment for the last_rx member
    added in commit 4dc89133f49b ("net: add a comment on netdev->last_rx")
    which asked drivers not to update is, unless really needed. However,
    this commend was removed in commit f8ff080dacec ("bonding: remove
    useless updating of slave->dev->last_rx"), so some drivers added later
    on still did update last_rx.

    Remove all usage of last_rx and switch three drivers (sky2, atp and
    smc91c92_cs) which actually read and write it to use their own private
    copy in netdev_priv.

    Compile-tested with allyesconfig and allmodconfig on x86 and arm.

    Cc: Eric Dumazet
    Cc: Jay Vosburgh
    Cc: Veaceslav Falico
    Cc: Andy Gospodarek
    Cc: Mirko Lindner
    Cc: Stephen Hemminger
    Signed-off-by: Tobias Klauser
    Acked-by: Eric Dumazet
    Reviewed-by: Jay Vosburgh
    Signed-off-by: David S. Miller

    Tobias Klauser
     

30 Apr, 2014

1 commit

10 Jan, 2014

1 commit

  • 4acb4d6c9   irda: sh_sir: use devm_request_irq() ... Browse Code »

    Huqiu reported current sh_sir driver doesn't
    call free_irq() in spite of using request_irq().
    This patch replaces request_irq() into devm_request_irq()
    to solve this issue

    Reported-by: Huqiu Liu
    Signed-off-by: Kuninori Morimoto
    Signed-off-by: David S. Miller

    Kuninori Morimoto
     

08 Oct, 2013

1 commit

28 May, 2013

1 commit

  • bf3a33cec   net: irda: remove unnecessary platform_set_drvdata() ... Browse Code »

    The driver core clears the driver data to NULL after device_release
    or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
    (device-core: Ensure drvdata = NULL when no driver is bound).
    Thus, it is not needed to manually clear the device driver data to NULL.

    Signed-off-by: Jingoo Han
    Acked-by: Kuninori Morimoto
    Signed-off-by: David S. Miller

    Jingoo Han
     

04 Dec, 2012

1 commit

  • 45ac936c3   irda: remove __dev* attributes ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Cc: Samuel Ortiz
    Signed-off-by: Greg Kroah-Hartman

    Bill Pemberton
     

08 Oct, 2012

1 commit

  • 14834540c   drivers/net/irda/sh_sir.c: fix error return code ... Browse Code »

    The function sh_sir_probe() return 0 for success and negative value
    for most of its internal tests failures. There are two exceptions
    that are error cases going to err_mem_*:. For this two cases, the
    function abort its success execution path, but returns non negative
    value, making it dificult for a caller function to notice the error.

    This patch fixes the error cases that do not return negative values.

    This was found by Coccinelle, but the code change was made by hand.
    This patch is not robot generated.

    A simplified version of the semantic match that finds this problem is
    as follows: (http://coccinelle.lip6.fr/)

    //
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }
    //

    Signed-off-by: Peter Senna Tschudin
    Signed-off-by: David S. Miller

    Peter Senna Tschudin
     

22 Sep, 2012

1 commit

15 Apr, 2012

1 commit

28 Nov, 2011

1 commit

11 Aug, 2011

2 commits

  • 2eed7982d   net/irda: sh_sir: tidyup compile warning ... Browse Code »

    This patch tidyup below warning

    ${LINUX}/drivers/net/irda/sh_sir.c:514:6: warning:
    'val' may be used uninitialized in this function

    Signed-off-by: Kuninori Morimoto
    Signed-off-by: David S. Miller

    Kuninori Morimoto
     
  • 86d0aff0e   net/irda: sh_sir: add missing header ... Browse Code »

    This patch fixup below build error on sh_sir

    sh_sir.c: In function 'sh_sir_write':
    sh_sir.c:127:2: error: implicit declaration of function 'iowrite16'
    sh_sir.c: In function 'sh_sir_read':
    sh_sir.c:132:2: error: implicit declaration of function 'ioread16'
    sh_sir.c: At top level:
    sh_sir.c:561:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_sir_irq'
    sh_sir.c: In function 'sh_sir_probe':
    sh_sir.c:727:2: error: implicit declaration of function 'ioremap_nocache'
    sh_sir.c:727:16: warning: assignment makes pointer from integer without a cast
    sh_sir.c:762:2: error: implicit declaration of function 'request_irq'
    sh_sir.c:762:23: error: 'sh_sir_irq' undeclared (first use in this function)
    sh_sir.c:762:23: note: each undeclared identifier is reported only once for each function it appears in
    sh_sir.c:762:35: error: 'IRQF_DISABLED' undeclared (first use in this function)
    sh_sir.c:776:2: error: implicit declaration of function 'iounmap'
    sh_sir.c: At top level:
    sh_sir.c:436:13: warning: 'sh_sir_clear_all_err' defined but not used
    sh_sir.c:474:12: warning: 'sh_sir_is_which_phase' defined but not used
    sh_sir.c:490:13: warning: 'sh_sir_tx' defined but not used
    sh_sir.c:540:13: warning: 'sh_sir_rx' defined but not used

    Signed-off-by: Kuninori Morimoto
    Signed-off-by: David S. Miller

    Kuninori Morimoto
     

22 Nov, 2010

1 commit

16 Jul, 2010

1 commit

12 Apr, 2010

1 commit

07 Apr, 2010

2 commits

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

02 Feb, 2010

1 commit