18 Mar, 2010
1 commit
-
Cosmetic fix: the path in the Makefile is wrong
Signed-off-by: Matteo Croce
Signed-off-by: David Woodhouse
12 Mar, 2010
2 commits
-
... instead of comparing with DMA_ERROR_CODE, which will only work on
powerpc/sparc/x86.Reported-by: Geert Uytterhoeven
Signed-off-by: David Woodhouse -
r852 fails to build when CONFIG_PCI is not enabled since it uses
pci_*() calls and is a PCI driver, so it should depend on PCI
to prevent build errors.
It should also #include .drivers/mtd/nand/r852.c:1053: error: implicit declaration of function 'pci_prepare_to_sleep'
drivers/mtd/nand/r852.c:1062: error: implicit declaration of function 'pci_back_from_sleep'Signed-off-by: Randy Dunlap
Cc: Maxim Levitsky
Signed-off-by: David Woodhouse
09 Mar, 2010
6 commits
-
I was calling it in del_mtd_blktrans_dev, but ->request_fn could
still be running at that point, thus defer this call
to blktrans_dev_releaseSigned-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
Randy Dunlap observed a build problem with the following config:
CONFIG_SM_FTL=y
CONFIG_SM_FTL_MUSEUM=yCONFIG_MTD_NAND=m
The ECC calculation routines are then built as a module, but referenced
by the sm_ftl code in the kernel, resulting in a build failure. The
simple fix is to make CONFIG_SM_FTL depend on MTD_NAND unconditionally
-- it's pointless without hardware support anyway.Fix some typos which Randy pointed out, too.
Reported-By: Randy Dunlap
Signed-off-by: David Woodhouse -
Signed-off-by: Stephen Rothwell
Signed-off-by: David Woodhouse -
and include delay.h for msleep().
Signed-off-by: Stephen Rothwell
Signed-off-by: David Woodhouse -
Fix r852 build for the case of CONFIG_PM=n.
drivers/mtd/nand/r852.c:1039: error: implicit declaration of function 'pci_prepare_to_sleep'
drivers/mtd/nand/r852.c:1048: error: implicit declaration of function 'pci_back_from_sleep'This patch leaves r852_pm_ops untouched.
Signed-off-by: Randy Dunlap
Acked-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
First don't enable card detection logic to early. Second be very careful with
DMA engine, to be sure it doesn't write to kernel memory driver doesn't own.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse
27 Feb, 2010
26 commits
-
The PCI_DEVICE_ID_RICOH_R5C852 was missed in the edited commit, and on
second thought I just open code it.This fixes compile error.
Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
* Test results of few functions that were declared with __must_check
* Fix bogus gcc warning about uinitialized variable 'ret'
* Remove unused variable from mtdblock_remove_dev
* Don't use deprecated DMA_32BIT_MASKSigned-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This adds a driver for Ricoh R5C852 xD card reader.
This reader is a part of larger mulifunction chip
and found at least in R5C832Driver is complete, but bewere of the fact that some
(probably only type M) xD cards are 'fake' which means that
they have an on board CPU and expose emulated nand command setThese cards don't even store the oob area on the flash,
but generate it on the fly from something else.Thus they demand to have proper values written in the oob area,
and therefore only useful with SmartMedia FTL.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This implements new readwrite SmartMedia/xd FTL.
mtd driver must have support proper ECC and badblock verification
based on oob parts for 512 bytes nand.Also mtd driver must define read_oob and write_oob, which are used
to read and write both data and oob together.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
The SmartMedia FTL code depends on new kfifo bits from 2.6.33
-
(and remove the CONFIG_MTD_NAND_SMARTMEDIA option which isn't going to be
used now that we're doing it this way)Signed-off-by: David Woodhouse
-
Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
Signed-off-by: David Woodhouse
-
This small module implements few helpers that are usefull
for nand drivers for SmartMedia/xD card readers.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This can be used to protect against bitflips in that field, but now mostly
for smartmedia.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This changes the behavier of MTD_OOB_RAW. It used to read both OOB and
data to the data buffer, however you would still need to specify the
dummy oob buffer.This is only used in one place, but makes it hard to read data+oob
without ECC test, thus I removed that behavier, and fixed the user.Now MTD_OOB_RAW behaves just like MTD_OOB_PLACE, but doesn't do ECC
validationSigned-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
nand_do_write_ops was broken in regard to writing several pages, each
with its own oob.Although nand_do_write_ops intends to allow such mode, it fails do do so
Probably this was never tested.Also add missing checks for attempts to write at illegal offsets.
Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
MTD_OOB_PLACE is supposed to read/write the raw oob data similiar to the
MTD_OOB_RAW however due to a bug, currently it is not possible to read
more data that is specified by the oob 'free' regions.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
Since all userspace threads are frozen at the time the nand_suspend is called,
they aren't inside any nand function.We don't call try_to_freeze in nand ether. Thus the only user that can
be inside the nand functions is an non freezeable kernel thread. Thus we
can safely wait for it to finish.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This patch adds an ability to export sysfs attributes below
the block disk device.This can be used to pass the udev an information about the FTL
and could include the vendor, serial, version, etc...Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
Now that mtd block common layer is prepared for proper hotplug support,
enable it hereNow all users of the mtd device have a chance to put the mtd device
when they are notified to do so, and they have to do so to make hotplug work.[dwmw2: There's more work to be done to fix hotplug in the general case, but
this is a reasonable start]Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This prevents a memory leak
Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
* Add locking where it was missing.
* Don't do a get_mtd_device in blktrans_open because it would lead to a
deadlock; instead do that in add_mtd_blktrans_dev.* Only free the mtd_blktrans_dev structure when the last user exits.
* Flush request queue on device removal.
* Track users, and call tr->release in del_mtd_blktrans_dev
Due to that ->open and release aren't called more that once.Now it is safe to call del_mtd_blktrans_dev while the device is still in use.
Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
This is the biggest change. To make hotplug possible, and this layer
clean, the mtd_blktrans_dev now contains everything for a single mtd
block translation device. Also removed some very old leftovers.Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
Use these only if you know that you already hold mtd_table_mutex
Signed-off-by: Maxim Levitsky
Signed-off-by: David Woodhouse -
Adds NAND Flash Controller driver for MPC5121 Revision 2.
All device features, except hardware ECC and power management,
are supported.Signed-off-by: Piotr Ziecik
Signed-off-by: Wolfgang Denk
Signed-off-by: Anatolij Gustschin
Acked-by: Grant Likely
Signed-off-by: David Woodhouse -
In the branch where pagesize equalled NAND_DATA_ACCESS_SIZE, NumToRead
wasn't decremented in the `while (numToRead > 11)' loop.
Also the first and last while loops were duplicated in both branches.Signed-off-by: Roel Kluin
Acked-by: Leo Chen
Signed-off-by: David Woodhouse -
There is a bug in nand prefetch read routine, which comes into effect
only if nand device is a 16-bit device (as we have in zoom boards).
This bug is effective only with below combination of conditions:
1. nand deivce, in use, is a 16 bit device
2. nand driver supports 'subpage' read
3. SW ECC is in useThis was not seen old kernel (ex: .23), because when, in early days,
we tested this (nand prefetch read in LDP boards) there was no
'subpage read' support.
Later when we had subpage read in (.27) kernel, we had hw ecc enabled
always in our internal tree. So, we missed this bug.This patch fixes the issue.
Signed-off-by: Vimal Singh
Signed-off-by: David Woodhouse -
Removing OMAP NAND driver, when loaded as a module, gives error and
does not get success. This fixes this and makes driver loadable and
removable run time.Signed-off-by: Vimal Singh
Signed-off-by: David Woodhouse -
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target typeSigned-off-by: Vimal Singh
Signed-off-by: David Woodhouse -
Move MANUFACTURER_MACRONIX and MANUFACTURER_SST definitions to the
include/linux/mtd/cfi.h header file and rename them to CFI_MFR_MACRONIX and
CFI_MFR_SST.All references in drivers/mtd/chips/cfi_cmdset_0002.c are updated to reflect
this.Signed-off-by: Guillaume LECERF
Signed-off-by: David Woodhouse
26 Feb, 2010
5 commits
-
mxc_nand driver must support the RESET Command in order to support
Micron NAND which need a reset before any other command.Signed-off-by: Eric Benard
Acked-by: Sascha Hauer
Signed-off-by: David Woodhouse -
The parenthesis was misplaced, upon error a one was shown.
[dwmw2: Fix the code not to do the assignment within the if() statement]
Signed-off-by: Roel Kluin
Signed-off-by: Artem Bityutskiy
Signed-off-by: David Woodhouse -
Otherwise we may hang if we are called from panic() through mtdoops.
Signed-off-by: Aaro Koskinen
Signed-off-by: Artem Bityutskiy
Signed-off-by: David Woodhouse -
Add nand lock / unlock routines. At least 'micron' parts
support this.Signed-off-by: Vimal Singh
Signed-off-by: Artem Bityutskiy
Signed-off-by: David Woodhouse -
... verification for 'nand_erase_nand'
These checks are expected to be used by 'nand_lock' and 'nand_unlock'
routines too. As all these three are block aligned operations.
So, creating a helper function for this makes sense.Signed-off-by: Vimal Singh
Signed-off-by: Artem Bityutskiy
Signed-off-by: David Woodhouse
