15 Nov, 2007

24 commits

  • This patch fixes a memory leak spotted by the Coverity checker.

    Signed-off-by: Adrian Bunk
    Cc: Rusty Russell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • A relatively recent version of the Geode LX datasheet listed the wrong
    address for one of the MSRs that controls TFT panels, resulting in
    breakage. This patch corrects the MSR address.

    Signed-off-by: Jordan Crouse
    Cc: "Antonino A. Daplas"
    Cc: "H. Peter Anvin"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jordan Crouse
     
  • Forbid user from changing file flags on quota files. User has no bussiness
    in playing with these flags when quota is on. Furthermore there is a
    remote possibility of deadlock due to a lock inversion between quota file's
    i_mutex and transaction's start (i_mutex for quota file is locked only when
    trasaction is started in quota operations) in ext3 and ext4.

    Signed-off-by: Jan Kara
    Cc: LIOU Payphone
    Cc:
    Acked-by: Dave Kleikamp
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Kara
     
  • Attached patch fixes two compilation problems of s1d13xxxfb.c:

    - Fixes outdated dbg() message to fix compilation error with debugging enabled.

    - Do not read kernel command line options when compiled as module.

    Signed-off-by: Stanislav Brabec
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Stanislav Brabec
     
  • When I boot with the 'quiet' parameter, I see on the screen:

    [ 0.000000] Initializing cgroup subsys cpuset
    [ 0.000000] Initializing cgroup subsys cpu
    [ 39.036026] Initializing cgroup subsys cpuacct
    [ 39.036080] Initializing cgroup subsys debug
    [ 39.036118] Initializing cgroup subsys ns

    This patch lowers the priority of those messages, adds a "cgroup: " prefix
    to another couple of printks and kills the useless reference to the source
    file.

    Signed-off-by: Diego Calleja
    Cc: Paul Menage
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Diego Calleja
     
  • pud_clear wasn't setting the _PAGE_NEWPAGE bit, fooling tlb_flush into
    thinking that this area of the address space was up-to-date and not unmapping
    whatever was covered by the pud.

    This manifested itself as ldconfig on x86_64 complaining about the first
    library it looked at not being a valid ELF file. A config file is mapped at
    0x4000000, as the only thing mapped under its pud, and unmapped. The
    unmapping caused a pud_clear, which, due to this bug, didn't actually unmap
    the config file data on the host. The first library is then mapped at the
    same location, but is not actually mapped on the host because accesses to it
    cause no page faults. As a result, ldconfig sees the old config file data.

    [akpm@linux-foundation.org: coding-style cleanups]
    Signed-off-by: Jeff Dike
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     
  • Stupid bug - we need to compare the return value of recvmsg to the value of
    iov_len, not its size. This caused port_helper processes not to be killed on
    shutdown on x86_64 because the pids weren't being passed out properly.

    Signed-off-by: Jeff Dike
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     
  • Instruction pointer returned by profile_pc() can be a random value. This
    break the assumption than we can safely set struct op_sample.eip field to a
    magic value to signal to the per-cpu buffer reader side special event like
    task switch ending up in a segfault in get_task_mm() when profile_pc()
    return ~0UL. Fixed by sanitizing the sampled eip and reject/log invalid
    eip.

    Problem reported by Sami Farin, patch tested by him.

    Signed-off-by: Philippe Elie
    Tested-by: Sami Farin
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Philippe Elie
     
  • Variables that are only used in #ifdef CONFIG_X86 should also only be
    declared there.

    Signed-off-by: Frank Lichtenheld
    Cc: Michal Januszewski
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Frank Lichtenheld
     
  • chipsfb uses PCI interfaces and should depend on PCI.

    CC drivers/video/chipsfb.o
    drivers/video/chipsfb.c: In function 'chipsfb_pci_init':
    drivers/video/chipsfb.c:378: error: implicit declaration of function 'pci_request_region'
    drivers/video/chipsfb.c:435: error: implicit declaration of function 'pci_release_region'
    make[2]: *** [drivers/video/chipsfb.o] Error 1
    make[1]: *** [drivers/video] Error 2
    make: *** [drivers] Error 2

    !CONFIG_PCI causes the build to fail.

    Signed-off-by: Randy Dunlap
    Cc: Kamalesh Babulal
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • The max_user_freq member is not really meant for RTC drivers to modify, so
    update the rtc documentation so drivers writers know what is expected of
    them when handling periodic events.

    Signed-off-by: Mike Frysinger
    Acked-by: Alessandro Zummo
    Cc: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mike Frysinger
     
  • symlinks to directories in the non-O= case were lacking -n, which meant
    that, when the link already existed, a new link pointing at itself was
    created in the target directory.

    Signed-off-by: Jeff Dike
    Cc: Sam Ravnborg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     
  • mac80211 has a reference to __bitmap_empty() via bitmap_empty(). In
    lib/bitmap.c this is flagged with an EXPORT_SYMBOL(), but this is
    ultimately ineffective due to bitmap.o being linked in lib-y, resulting in:

    ERROR: "__bitmap_empty" [net/mac80211/mac80211.ko] undefined!

    Moving bitmap.o to obj-y fixes this up.

    Signed-off-by: Paul Mundt
    Cc: "John W. Linville"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Paul Mundt
     
  • When PCMCIA_DEBUG is set, cm40x0_cs.c and cm4000_cs.c don't build because the
    definition of reader_to_dev uses a non-existent handle field of the struct
    pcmcia_device in the call to handle_to_dev. As handle_to_dev works on struct
    pcmcia_device, the fix is quite trivial.

    Signed-off-by: Pascal Terjan
    Cc: Harald Welte
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Pascal Terjan
     
  • Original patch assumed args->nlen < CTL_MAXNAME, but it can be false.

    Signed-off-by: Tetsuo Handa
    Cc: "Eric W. Biederman"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tetsuo Handa
     
  • This should resolve these bug reports of the modem not working:
    http://bugzilla.kernel.org/show_bug.cgi?id=4355
    http://www.linuxquestions.org/questions/linux-newbie-8/connect-script-failed-on-ppp-go-123975/

    I don't have hardware to test this, but the initial report in the kernel
    bugzilla indicates that this change fixed the problem.

    Signed-off-by: Bjorn Helgaas
    Cc: Dmitry Vavilov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bjorn Helgaas
     
  • This patch fixes wrong array index in allocation failure handling.

    Cc: Pekka Enberg
    Acked-by: Christoph Lameter
    Signed-off-by: Akinobu Mita
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita
     
  • The size argument passed to memset is wrong.

    Signed-off-by Li Zefan
    Acked-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Li Zefan
     
  • The size passed to memset is wrong.

    Signed-off-by Li Zefan
    Acked-by: Geert Uytterhoeven
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Li Zefan
     
  • Export the NVRAM on DS1307 and DS1338 chips, like several of the
    other drivers do for such combination RTC-and-NVRAM chips.

    Signed-off-by: David Brownell
    Acked-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • Several of the RTC drivers are exporting binary "nvram" files in sysfs. Such
    NVRAM (or on many systems, EEPROM) data is often initialized during system
    manufacture to hold data about identity (serial numbers, Ethernet addresses,
    etc), configuration, calibration, and so forth.

    This patch improves integrity and security of those files:

    - Correctly initializes the size in one of the two cases where
    that was not yet being done.

    - Improves system security/integrity by making this state not
    be world-writable by default.

    Letting arbitrary userspace code mangle such state by default is at least Not
    A Good Thing; and it could sometimes be worse, depending on the particular
    data that might be corrupted. (I disregard the paranoiac "don't let anyone
    read it either" approach. Anyone storing passwords in such memory doesn't
    really care about security.)

    Signed-off-by: David Brownell
    Acked-by: Atsushi Nemoto
    Cc: Torsten Ertbjerg Rasmussen
    Cc: Mark Zhan
    Cc: Thomas Hommel
    Acked-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • The RTC "hctosys" mechanism expects that RTC clock will use UTC, not local
    time (e.g. PST). Say so in Kconfig and in the kernel message.

    (Strictly speaking, the RTC clock should be tracking the POSIX epoch. That's
    not worth going into here. Goofing timezones means clocks are wrong by many
    hours; the POSIX-v-UTC differences just cost seconds.)

    Signed-off-by: David Brownell
    Acked-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • When backlight_device_register() fails, return after undo initialization, do
    not try to use pointer that just was reset to NULL

    This fixes this oops:

    [ 1595.177672] [] show_trace_log_lvl+0x1a/0x30
    [ 1595.177706] [] show_trace+0x12/0x20
    [ 1595.177718] [] dump_stack+0x15/0x20
    [ 1595.177728] [] kobject_shadow_add+0x125/0x1c0
    [ 1595.177754] [] kobject_add+0xa/0x10
    [ 1595.177764] [] device_add+0x97/0x5d0
    [ 1595.177776] [] device_register+0x12/0x20
    [ 1595.177786] [] backlight_device_register+0x9f/0x110 [backlight]
    [ 1595.177814] [] toshiba_acpi_init+0x117/0x15e [toshiba_acpi]
    [ 1595.177834] [] sys_init_module+0xfd/0x14e0
    [ 1595.177871] [] sysenter_past_esp+0x5f/0x99
    [ 1595.177883] =======================
    [ 1595.177890] Could not register toshiba backlight device
    [ 1595.177985] BUG: unable to handle kernel NULL pointer dereference at virtual address 00000004
    ...
    [ 1595.394097] EIP: 0060:[] Not tainted VLI
    [ 1595.394101] EFLAGS: 00010282 (2.6.23-rc9-1avb #24)
    [ 1595.480081] EIP is at toshiba_acpi_init+0x143/0x15e [toshiba_acpi]

    Signed-off-by: Andrey Borzenkov
    Cc: John Belmonte
    Acked-by: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrey Borzenkov
     
  • page->index should be cast to loff_t instead of off_t.

    Signed-off-by: Michael Halcrow
    Reported-by: Eric Sandeen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Michael Halcrow
     

14 Nov, 2007

13 commits

  • Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Fix ide-cris, cs5530, sc1200 and sis5513 host drivers to just return instead
    of OOPS-ing for unsupported modes in ->set_dma_mode methods.

    Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Use drive->select.all for REQ_TYPE_ATA_TASK requests in execute_drive_cmd()
    (the obsolete bits 7 and 5 of the Device register need to be set).

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • We can skip conservative PIO "downgrade" (PIO3 becomes PIO2 etc.) on PMAC.

    Problem reported by Mikael.

    Cc: Mikael Pettersson
    Acked-by: Benjamin Herrenschmidt
    Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • LILO version 16 was released on 26-02-1995 (sic), so telling people to not use
    older versions no longer has any value.

    Signed-off-by: Adrian Bunk
    Cc: Jens Axboe
    Signed-off-by: Andrew Morton
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Adrian Bunk
     
  • Make sure to not clear the other IDE channel's interrupt when clearing an IDE
    interrupt via the MRDMODE register.

    Thanks to Bart for finding a coding mistake.

    Bart:

    This fixes regression from commit 66602c83dcb6a5d82772d88ae7a32cd4a1213528
    ("cmd64x: use interrupt status from MRDMODE register (take 2)").

    Extra thanks to Martin for reporting and bisecting the issue.

    From: Sergei Shtylyov
    Tested-by: Martin Rogge
    Tested-by: Milan Kocian
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Sergei Shtylyov
     
  • * 'release' of git://lm-sensors.org/kernel/mhoffman/hwmon-2.6:
    hwmon: (i5k_amb) Convert macros to C functions
    hwmon: (w83781d) Add missing curly braces
    hwmon: (abituguru3) Identify ABit IP35 Pro as such
    hwmon: (f75375s) pwmX_mode sysfs files writable for f75375 variant
    hwmon: (f75375s) On n2100 systems, set fans to full speed on boot
    hwmon: (f75375s) Allow setting up fans with platform_data
    hwmon: (f75375s) Add new style bindings
    hwmon: (lm70) Convert semaphore to mutex
    hwmon: (applesmc) Add support for Mac Pro 2 x Quad-Core
    hwmon: (abituguru3) Add support for 2 new motherboards
    hwmon: (ibmpex) Change printk to dev_{info,err} macros
    hwmon: (i5k_amb) New memory temperature sensor driver
    hwmon: (f75375s) fix pwm mode setting
    hwmon: (ibmpex.c) fix NULL dereference
    hwmon: (sis5595) Split sis5595_attributes_opt
    hwmon: (sis5595) Add individual alarm files
    hwmon: (w83627hf) push nr+1 offset into *_REG_FAN macros and simplify
    hwmon: (w83627hf) hoist nr-1 offset out of show-store-temp-X
    hwmon: Add power meter spec to Documentation/hwmon/sysfs-interface

    Linus Torvalds
     
  • * 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6: (45 commits)
    [NETFILTER]: xt_time should not assume CONFIG_KTIME_SCALAR
    [NET]: Move unneeded data to initdata section.
    [NET]: Cleanup pernet operation without CONFIG_NET_NS
    [TEHUTI]: Fix incorrect usage of strncat in bdx_get_drvinfo()
    [MYRI_SBUS]: Prevent that myri_do_handshake lies about ticks.
    [NETFILTER]: bridge: fix double POSTROUTING hook invocation
    [NETFILTER]: Consolidate nf_sockopt and compat_nf_sockopt
    [NETFILTER]: nf_nat: fix memset error
    [INET]: Use list_head-s in inetpeer.c
    [IPVS]: Remove unused exports.
    [NET]: Unexport sysctl_{r,w}mem_max.
    [TG3]: Update version to 3.86
    [TG3]: MII => TP
    [TG3]: Add A1 revs
    [TG3]: Increase the PCI MRRS
    [TG3]: Prescaler fix
    [TG3]: Limit 5784 / 5764 to MAC LED mode
    [TG3]: Disable GPHY autopowerdown
    [TG3]: CPMU adjustments for loopback tests
    [TG3]: Fix nvram selftest failures
    ...

    Linus Torvalds
     
  • * 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc:
    [POWERPC] Silence an annoying boot message
    [POWERPC] Fix early btext debug on PowerMac
    [POWERPC] Demote clockevent printk to KERN_DEBUG
    [POWERPC] Fix CONFIG_SMP=n build error on ppc64
    [POWERPC] Avoid unpaired stwcx. on some processors
    [POWERPC] Fix oops related to 4xx flush_tlb_page modification
    [POWERPC] cpm: Fix a couple minor issues in cpm_common.c.
    [POWERPC] Add -mno-spe for ARCH=powerpc builds

    Linus Torvalds
     
  • get_property() should not call battery_update(), it also should call
    get_status() only if battery is present to avoid cycle and oops.

    Signed-off-by: Alexey Starikovskiy
    Tested-by: Rolf Eike Beer
    Acked-by: Johannes Weiner
    Signed-off-by: Linus Torvalds

    Alexey Starikovskiy
     
  • This reverts commit 7c9e69faa28027913ee059c285a5ea8382e24b5d, fixing up
    conflicts in fs/ext4/balloc.c manually.

    The cost of doing the bitmap validation on each lookup - even when the
    bitmap is cached - is absolutely prohibitive. We could, and probably
    should, do it only when adding the bitmap to the buffer cache. However,
    right now we are better off just reverting it.

    Peter Zijlstra measured the cost of this extra validation as a 85%
    decrease in cached iozone, and while I had a patch that took it down to
    just 17% by not being _quite_ so stupid in the validation, it was still
    a big slowdown that could have been avoided by just doing it right.

    Cc: Peter Zijlstra
    Cc: Andrew Morton
    Cc: Aneesh Kumar
    Cc: Andreas Dilger
    Cc: Mingming Cao
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

13 Nov, 2007

3 commits