25 Oct, 2018

5 commits

  • Commands with protection information included were not truncating the
    protection iov_iter to the number of protection bytes in the command.
    This resulted in vhost_scsi mis-calculating the size of the protection
    SGL in vhost_scsi_calc_sgls(), and including both the protection and
    data SG entries in the protection SGL.

    Fixes: 09b13fa8c1a1 ("vhost/scsi: Add ANY_LAYOUT support in vhost_scsi_handle_vq")
    Signed-off-by: Greg Edwards
    Signed-off-by: Michael S. Tsirkin
    Fixes: 09b13fa8c1a1093e9458549ac8bb203a7c65c62a
    Cc: stable@vger.kernel.org
    Reviewed-by: Paolo Bonzini

    Greg Edwards
     
  • The VIRTIO_BALLOON_F_PAGE_POISON feature bit is used to indicate if the
    guest is using page poisoning. Guest writes to the poison_val config
    field to tell host about the page poisoning value that is in use.

    Suggested-by: Michael S. Tsirkin
    Signed-off-by: Wei Wang
    Cc: Michael S. Tsirkin
    Cc: Michal Hocko
    Cc: Andrew Morton
    Signed-off-by: Michael S. Tsirkin

    Wei Wang
     
  • In some usages, e.g. virtio-balloon, a kernel module needs to know if
    page poisoning is in use. This patch exposes the page_poisoning_enabled
    function to kernel modules.

    Signed-off-by: Wei Wang
    Cc: Andrew Morton
    Cc: Michal Hocko
    Cc: Michael S. Tsirkin
    Acked-by: Andrew Morton
    Signed-off-by: Michael S. Tsirkin

    Wei Wang
     
  • Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the
    support of reporting hints of guest free pages to host via virtio-balloon.
    Currenlty, only free page blocks of MAX_ORDER - 1 are reported. They are
    obtained one by one from the mm free list via the regular allocation
    function.

    Host requests the guest to report free page hints by sending a new cmd id
    to the guest via the free_page_report_cmd_id configuration register. When
    the guest starts to report, it first sends a start cmd to host via the
    free page vq, which acks to host the cmd id received. When the guest
    finishes reporting free pages, a stop cmd is sent to host via the vq.
    Host may also send a stop cmd id to the guest to stop the reporting.

    VIRTIO_BALLOON_CMD_ID_STOP: Host sends this cmd to stop the guest
    reporting.
    VIRTIO_BALLOON_CMD_ID_DONE: Host sends this cmd to tell the guest that
    the reported pages are ready to be freed.

    Why does the guest free the reported pages when host tells it is ready to
    free?
    This is because freeing pages appears to be expensive for live migration.
    free_pages() dirties memory very quickly and makes the live migraion not
    converge in some cases. So it is good to delay the free_page operation
    when the migration is done, and host sends a command to guest about that.

    Why do we need the new VIRTIO_BALLOON_CMD_ID_DONE, instead of reusing
    VIRTIO_BALLOON_CMD_ID_STOP?
    This is because live migration is usually done in several rounds. At the
    end of each round, host needs to send a VIRTIO_BALLOON_CMD_ID_STOP cmd to
    the guest to stop (or say pause) the reporting. The guest resumes the
    reporting when it receives a new command id at the beginning of the next
    round. So we need a new cmd id to distinguish between "stop reporting" and
    "ready to free the reported pages".

    TODO:
    - Add a batch page allocation API to amortize the allocation overhead.

    Signed-off-by: Wei Wang
    Signed-off-by: Liang Li
    Cc: Michael S. Tsirkin
    Cc: Michal Hocko
    Cc: Andrew Morton
    Cc: Linus Torvalds
    Signed-off-by: Michael S. Tsirkin

    Wei Wang
     
  • Make sure that make kvmconfig enables all the virtio drivers even if it is
    preceded by a make allnoconfig.

    Signed-off-by: Lénaïc Huard
    Signed-off-by: Michael S. Tsirkin

    Lénaïc Huard
     

22 Oct, 2018

8 commits

  • Greg Kroah-Hartman
     
  • As I introduced these files, I'm willing to be the maintainer of them as
    well.

    Acked-by: Chris Mason
    Acked-by: Olof Johansson
    Acked-by: Steven Rostedt (VMware)
    Acked-by: Theodore Ts'o
    Acked-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • The contact point for the kernel's Code of Conduct should now be the
    Code of Conduct Committee, not the full TAB. Change the email address
    in the file to properly reflect this.

    Acked-by: Chris Mason
    Acked-by: Olof Johansson
    Acked-by: Theodore Ts'o
    Acked-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • There was a blank reference for how to find the Code of Conduct
    Committee. Fix that up by pointing it to the correct kernel.org website
    page location.

    Acked-by: Chris Mason
    Acked-by: Olof Johansson
    Acked-by: Theodore Ts'o
    Acked-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • Create a link between the Code of Conduct and the Code of Conduct
    Interpretation so that people can see that they are related.

    Acked-by: Chris Mason
    Acked-by: Olof Johansson
    Acked-by: Theodore Ts'o
    Acked-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • We use the term "TAB" before defining it later in the document. Fix
    that up by defining it at the first location.

    Reported-by: Kuninori Morimoto
    Acked-by: Chris Mason
    Acked-by: Olof Johansson
    Acked-by: Theodore Ts'o
    Acked-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • The Contributor Covenant Code of Conduct is a general document meant to
    provide a set of rules for almost any open source community. Every
    open-source community is unique and the Linux kernel is no exception.
    Because of this, this document describes how we in the Linux kernel
    community will interpret it. We also do not expect this interpretation
    to be static over time, and will adjust it as needed.

    This document was created with the input and feedback of the TAB as well
    as many current kernel maintainers.

    Co-Developed-by: Thomas Gleixner
    Co-Developed-by: Olof Johansson
    Acked-by: Alex Deucher
    Acked-by: Alexei Starovoitov
    Acked-by: Amir Goldstein
    Acked-by: Andrew Morton
    Acked-by: Andy Lutomirski
    Acked-by: Anna-Maria Gleixner
    Acked-by: Ard Biesheuvel
    Acked-by: Benjamin Herrenschmidt
    Acked-by: Boris Brezillon
    Acked-by: Borislav Petkov
    Acked-by: Chris Mason
    Acked-by: Christian Lütke-Stetzkamp
    Acked-by: Colin Ian King
    Acked-by: Dan Carpenter
    Acked-by: Dan Williams
    Acked-by: Daniel Borkmann
    Acked-by: Daniel Vetter
    Acked-by: Dave Airlie
    Acked-by: Dave Hansen
    Acked-by: David Ahern
    Acked-by: David Sterba
    Acked-by: Dmitry Torokhov
    Acked-by: Dominik Brodowski
    Acked-by: Eric Dumazet
    Acked-by: Felipe Balbi
    Acked-by: Felix Kuehling
    Acked-by: Florian Fainelli
    Acked-by: Geert Uytterhoeven
    Acked-by: Grant Likely
    Acked-by: Gregory CLEMENT
    Acked-by: Guenter Roeck
    Acked-by: Gustavo A. R. Silva
    Acked-by: Hans Verkuil
    Acked-by: Hans de Goede
    Acked-by: Harry Wentland
    Acked-by: Heiko Stuebner
    Acked-by: Ingo Molnar
    Acked-by: Jaegeuk Kim
    Acked-by: James Smart
    Acked-by: James Smart
    Acked-by: Jan Kara
    Acked-by: Jani Nikula
    Acked-by: Jason A. Donenfeld
    Acked-by: Jeff Kirsher
    Acked-by: Jens Axboe
    Acked-by: Jessica Yu
    Acked-by: Jia-Ju Bai
    Acked-by: Jiri Kosina
    Acked-by: Jiri Olsa
    Acked-by: Joerg Roedel
    Acked-by: Johan Hovold
    Acked-by: Johannes Thumshirn
    Acked-by: Jonathan Corbet
    Acked-by: Julia Lawall
    Acked-by: Kees Cook
    Acked-by: Kirill Tkhai
    Acked-by: Kuninori Morimoto
    Acked-by: Laurent Pinchart
    Acked-by: Lina Iyer
    Acked-by: Linus Torvalds
    Acked-by: Linus Walleij
    Acked-by: Mark Brown
    Acked-by: Masahiro Yamada
    Acked-by: Masami Hiramatsu
    Acked-by: Mathieu Desnoyers
    Acked-by: Matias Bjørling
    Acked-by: Mauro Carvalho Chehab
    Acked-by: Maxime Ripard
    Acked-by: Michael Ellerman
    Acked-by: Mike Rapoport
    Acked-by: Mimi Zohar
    Acked-by: Miquel Raynal
    Acked-by: Mishi Choudhary
    Acked-by: Nikolay Borisov
    Acked-by: Oded Gabbay
    Acked-by: Palmer Dabbelt
    Acked-by: Paul E. McKenney
    Acked-by: Peter Zijlstra
    Acked-by: Rafael J. Wysocki
    Acked-by: Richard Weinberger
    Acked-by: Rik van Riel
    Acked-by: Rob Clark
    Acked-by: Rob Herring
    Acked-by: Rodrigo Vivi
    Acked-by: Sean Paul
    Acked-by: Sebastian Andrzej Siewior
    Acked-by: Sebastian Reichel
    Acked-by: Sergio Paracuellos
    Acked-by: Shawn Guo
    Acked-by: Shuah Khan
    Acked-by: Simon Horman
    Acked-by: Srinivas Kandagatla
    Acked-by: Stephen Hemminger
    Acked-by: Takashi Iwai
    Acked-by: Tejun Heo
    Acked-by: Theodore Ts'o
    Acked-by: Thierry Reding
    Acked-by: Todd Poynor
    Acked-by: Viresh Kumar
    Acked-by: Wei Yongjun
    Acked-by: YueHaibing
    Reviewed-by: Steven Rostedt
    Signed-off-by: Thomas Gleixner
    Signed-off-by: Olof Johansson
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • As it was originally worded, this paragraph requires maintainers to
    enforce the code of conduct, or face potential repercussions. It sends
    the wrong message, when really we just want maintainers to be part of
    the solution and not violate the code of conduct themselves.

    Removing it doesn't limit our ability to enforce the code of conduct,
    and we can still encourage maintainers to help maintain high standards
    for the level of discourse in their subsystem.

    Signed-off-by: Chris Mason
    Acked-by: Alex Deucher
    Acked-by: Amir Goldstein
    Acked-by: Andrew Morton
    Acked-by: Anna-Maria Gleixner
    Acked-by: Ard Biesheuvel
    Acked-by: Benjamin Herrenschmidt
    Acked-by: Boris Brezillon
    Acked-by: Borislav Petkov
    Acked-by: Christian Lütke-Stetzkamp
    Acked-by: Christoph Hellwig
    Acked-by: Colin Ian King
    Acked-by: Dan Carpenter
    Acked-by: Dan Williams
    Acked-by: Daniel Borkmann
    Acked-by: Dave Airlie
    Acked-by: Dave Hansen
    Acked-by: David Ahern
    Acked-by: David Sterba
    Acked-by: Dmitry Torokhov
    Acked-by: Dominik Brodowski
    Acked-by: Eric Dumazet
    Acked-by: Felipe Balbi
    Acked-by: Felix Kuehling
    Acked-by: Florian Fainelli
    Acked-by: Florian Westphal
    Acked-by: Geert Uytterhoeven
    Acked-by: Grant Likely
    Acked-by: Gregory CLEMENT
    Acked-by: Guenter Roeck
    Acked-by: Gustavo A. R. Silva
    Acked-by: Hans Verkuil
    Acked-by: Hans de Goede
    Acked-by: Harry Wentland
    Acked-by: Heiko Stuebner
    Acked-by: Ingo Molnar
    Acked-by: Jaegeuk Kim
    Acked-by: James Smart
    Acked-by: James Smart
    Acked-by: Jan Kara
    Acked-by: Jason A. Donenfeld
    Acked-by: Jeff Kirsher
    Acked-by: Jens Axboe
    Acked-by: Jessica Yu
    Acked-by: Jia-Ju Bai
    Acked-by: Jiri Kosina
    Acked-by: Jiri Olsa
    Acked-by: Joerg Roedel
    Acked-by: Johan Hovold
    Acked-by: Johannes Thumshirn
    Acked-by: Jonathan Corbet
    Acked-by: Julia Lawall
    Acked-by: Kees Cook
    Acked-by: Kirill Tkhai
    Acked-by: Kuninori Morimoto
    Acked-by: Laurent Pinchart
    Acked-by: Lina Iyer
    Acked-by: Linus Torvalds
    Acked-by: Linus Walleij
    Acked-by: Mark Brown
    Acked-by: Masahiro Yamada
    Acked-by: Masami Hiramatsu
    Acked-by: Mathieu Desnoyers
    Acked-by: Matias Bjørling
    Acked-by: Maxime Ripard
    Acked-by: Michael Ellerman
    Acked-by: Mike Rapoport
    Acked-by: Mimi Zohar
    Acked-by: Miquel Raynal
    Acked-by: Nikolay Borisov
    Acked-by: Oded Gabbay
    Acked-by: Olof Johansson
    Acked-by: Palmer Dabbelt
    Acked-by: Paul E. McKenney
    Acked-by: Peter Zijlstra
    Acked-by: Rafael J. Wysocki
    Acked-by: Richard Weinberger
    Acked-by: Rik van Riel
    Acked-by: Rob Clark
    Acked-by: Rob Herring
    Acked-by: Rodrigo Vivi
    Acked-by: Sebastian Andrzej Siewior
    Acked-by: Sebastian Reichel
    Acked-by: Sergio Paracuellos
    Acked-by: Shawn Guo
    Acked-by: Shuah Khan
    Acked-by: Simon Horman
    Acked-by: Srinivas Kandagatla
    Acked-by: Stephen Hemminger
    Acked-by: Takashi Iwai
    Acked-by: Tejun Heo
    Acked-by: Theodore Ts'o
    Acked-by: Thierry Reding
    Acked-by: Thomas Gleixner
    Acked-by: Tim Bird
    Acked-by: Todd Poynor
    Acked-by: Trond Myklebust
    Acked-by: Viresh Kumar
    Acked-by: Wei Yongjun
    Acked-by: YueHaibing
    Reviewed-by: Mauro Carvalho Chehab
    Reviewed-by: Steven Rostedt
    Signed-off-by: Greg Kroah-Hartman

    Chris Mason
     

21 Oct, 2018

4 commits

  • Wolfram writes:
    "i2c for 4.19

    Another driver bugfix and MAINTAINERS addition from I2C."

    * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
    i2c: rcar: cleanup DMA for all kinds of failure
    MAINTAINERS: Add entry for Broadcom STB I2C controller

    Greg Kroah-Hartman
     
  • David writes:
    "Networking:

    A few straggler bug fixes:

    1) Fix indexing of multi-pass dumps of ipv6 addresses, from David
    Ahern.

    2) Revert RCU locking change for bonding netpoll, causes worse
    problems than it solves.

    3) pskb_trim_rcsum_slow() doesn't handle odd trim offsets, resulting
    in erroneous bad hw checksum triggers with CHECKSUM_COMPLETE
    devices. From Dimitris Michailidis.

    4) a revert to some neighbour code changes that adjust notifications
    in a way that confuses some apps."

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net:
    Revert "neighbour: force neigh_invalidate when NUD_FAILED update is from admin"
    net/ipv6: Fix index counter for unicast addresses in in6_dump_addrs
    net: fix pskb_trim_rcsum_slow() with odd trim offset
    Revert "bond: take rcu lock in netpoll_send_skb_on_dev"

    Greg Kroah-Hartman
     
  • This reverts commit 8e326289e3069dfc9fa9c209924668dd031ab8ef.

    This patch results in unnecessary netlink notification when one
    tries to delete a neigh entry already in NUD_FAILED state. Found
    this with a buggy app that tries to delete a NUD_FAILED entry
    repeatedly. While the notification issue can be fixed with more
    checks, adding more complexity here seems unnecessary. Also,
    recent tests with other changes in the neighbour code have
    shown that the INCOMPLETE and PROBE checks are good enough for
    the original issue.

    Signed-off-by: Roopa Prabhu
    Signed-off-by: David S. Miller

    Roopa Prabhu
     
  • The loop wants to skip previously dumped addresses, so loops until
    current index >= saved index. If the message fills it wants to save
    the index for the next address to dump - ie., the one that did not
    fit in the current message.

    Currently, it is incrementing the index counter before comparing to the
    saved index, and then the saved index is off by 1 - it assumes the
    current address is going to fit in the message.

    Change the index handling to increment only after a succesful dump.

    Fixes: 502a2ffd7376a ("ipv6: convert idev_list to list macros")
    Signed-off-by: David Ahern
    Signed-off-by: David S. Miller

    David Ahern
     

20 Oct, 2018

16 commits

  • DMA needs to be cleaned up not only on timeout, but on all errors where
    it has been setup before.

    Fixes: 73e8b0528346 ("i2c: rcar: add DMA support")
    Signed-off-by: Wolfram Sang
    Signed-off-by: Wolfram Sang

    Wolfram Sang
     
  • Add an entry for the Broadcom STB I2C controller in the MAINTAINERS file.

    Signed-off-by: Kamal Dasu
    Acked-by: Florian Fainelli
    [wsa: fixed sorting and a whitespace error]
    Signed-off-by: Wolfram Sang

    Kamal Dasu
     
  • Ingo writes:
    "x86 fixes:

    It's 4 misc fixes, 3 build warning fixes and 3 comment fixes.

    In hindsight I'd have left out the 3 comment fixes to make the pull
    request look less scary at such a late point in the cycle. :-/"

    * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    x86/swiotlb: Enable swiotlb for > 4GiG RAM on 32-bit kernels
    x86/fpu: Fix i486 + no387 boot crash by only saving FPU registers on context switch if there is an FPU
    x86/fpu: Remove second definition of fpu in __fpu__restore_sig()
    x86/entry/64: Further improve paranoid_entry comments
    x86/entry/32: Clear the CS high bits
    x86/boot: Add -Wno-pointer-sign to KBUILD_CFLAGS
    x86/time: Correct the attribute on jiffies' definition
    x86/entry: Add some paranoid entry/exit CR3 handling comments
    x86/percpu: Fix this_cpu_read()
    x86/tsc: Force inlining of cyc2ns bits

    Greg Kroah-Hartman
     
  • Ingo writes:
    "scheduler fixes:

    Two fixes: a CFS-throttling bug fix, and an interactivity fix."

    * 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    sched/fair: Fix the min_vruntime update logic in dequeue_entity()
    sched/fair: Fix throttle_list starvation with low CFS quota

    Greg Kroah-Hartman
     
  • Ingo writes:
    "perf fixes:

    Misc perf tooling fixes."

    * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    perf tools: Stop fallbacking to kallsyms for vdso symbols lookup
    perf tools: Pass build flags to traceevent build
    perf report: Don't crash on invalid inline debug information
    perf cpu_map: Align cpu map synthesized events properly.
    perf tools: Fix tracing_path_mount proper path
    perf tools: Fix use of alternatives to find JDIR
    perf evsel: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
    perf vendor events intel: Fix wrong filter_band* values for uncore events
    Revert "perf tools: Fix PMU term format max value calculation"
    tools headers uapi: Sync kvm.h copy
    tools arch uapi: Sync the x86 kvm.h copy

    Greg Kroah-Hartman
     
  • We've been getting checksum errors involving small UDP packets, usually
    59B packets with 1 extra non-zero padding byte. netdev_rx_csum_fault()
    has been complaining that HW is providing bad checksums. Turns out the
    problem is in pskb_trim_rcsum_slow(), introduced in commit 88078d98d1bb
    ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends").

    The source of the problem is that when the bytes we are trimming start
    at an odd address, as in the case of the 1 padding byte above,
    skb_checksum() returns a byte-swapped value. We cannot just combine this
    with skb->csum using csum_sub(). We need to use csum_block_sub() here
    that takes into account the parity of the start address and handles the
    swapping.

    Matches existing code in __skb_postpull_rcsum() and esp_remove_trailer().

    Fixes: 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends")
    Signed-off-by: Dimitris Michailidis
    Reviewed-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Dimitris Michailidis
     
  • Dave writes:
    "drm fixes for 4.19 final (part 2)

    Looked like two stragglers snuck in, one very urgent the pageflipping
    was missing a reference that could result in a GPF on non-i915
    drivers, the other is an overflow in the sun4i dotclock calcs
    resulting in a mode not getting set."

    * tag 'drm-fixes-2018-10-20-1' of git://anongit.freedesktop.org/drm/drm:
    drm/sun4i: Fix an ulong overflow in the dotclock driver
    drm: Get ref on CRTC commit object when waiting for flip_done

    Greg Kroah-Hartman
     
  • Steven writes:
    "tracing: A few small fixes to synthetic events

    Masami found some issues with the creation of synthetic events. The
    first two patches fix handling of unsigned type, and handling of a
    space before an ending semi-colon.

    The third patch adds a selftest to test the processing of synthetic
    events."

    * tag 'trace-v4.19-rc8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
    selftests: ftrace: Add synthetic event syntax testcase
    tracing: Fix synthetic event to allow semicolon at end
    tracing: Fix synthetic event to accept unsigned modifier

    Greg Kroah-Hartman
     
  • Dmitry writes:
    "Input updates for 4.19-rc8

    Just an addition to elan touchpad driver ACPI table."

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
    Input: elan_i2c - add ACPI ID for Lenovo IdeaPad 330-15IGM

    Greg Kroah-Hartman
     
  • Second pull request for v4.19:
    - Fix ulong overflow in sun4i
    - Fix a serious GPF in waiting for flip_done from commit_tail().

    Signed-off-by: Dave Airlie

    From: Maarten Lankhorst
    Link: https://patchwork.freedesktop.org/patch/msgid/97d1ed42-1d99-fcc5-291e-cd1dc29a4252@linux.intel.com

    Dave Airlie
     
  • Add a testcase to check the syntax and field types for
    synthetic_events interface.

    Link: http://lkml.kernel.org/r/153986838264.18251.16627517536956299922.stgit@devbox

    Acked-by: Shuah Khan
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Steven Rostedt (VMware)

    Masami Hiramatsu
     
  • Fix synthetic event to allow independent semicolon at end.

    The synthetic_events interface accepts a semicolon after the
    last word if there is no space.

    # echo "myevent u64 var;" >> synthetic_events

    But if there is a space, it returns an error.

    # echo "myevent u64 var ;" > synthetic_events
    sh: write error: Invalid argument

    This behavior is difficult for users to understand. Let's
    allow the last independent semicolon too.

    Link: http://lkml.kernel.org/r/153986835420.18251.2191216690677025744.stgit@devbox

    Cc: Shuah Khan
    Cc: Tom Zanussi
    Cc: stable@vger.kernel.org
    Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events")
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Steven Rostedt (VMware)

    Masami Hiramatsu
     
  • Fix synthetic event to accept unsigned modifier for its field type
    correctly.

    Currently, synthetic_events interface returns error for "unsigned"
    modifiers as below;

    # echo "myevent unsigned long var" >> synthetic_events
    sh: write error: Invalid argument

    This is because argv_split() breaks "unsigned long" into "unsigned"
    and "long", but parse_synth_field() doesn't expected it.

    With this fix, synthetic_events can handle the "unsigned long"
    correctly like as below;

    # echo "myevent unsigned long var" >> synthetic_events
    # cat synthetic_events
    myevent unsigned long var

    Link: http://lkml.kernel.org/r/153986832571.18251.8448135724590496531.stgit@devbox

    Cc: Shuah Khan
    Cc: Tom Zanussi
    Cc: stable@vger.kernel.org
    Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events")
    Signed-off-by: Masami Hiramatsu
    Signed-off-by: Steven Rostedt (VMware)

    Masami Hiramatsu
     
  • This reverts commit 6fe9487892b32cb1c8b8b0d552ed7222a527fe30.

    It is causing more serious regressions than the RCU warning
    it is fixing.

    Signed-off-by: David S. Miller

    David S. Miller
     
  • I wrote:
    "USB fixes for 4.19-final

    Here are a small number of last-minute USB driver fixes

    Included here are:
    - spectre fix for usb storage gadgets
    - xhci fixes
    - cdc-acm fixes
    - usbip fixes for reported problems

    All of these have been in linux-next with no reported issues."

    * tag 'usb-4.19-final' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
    usb: gadget: storage: Fix Spectre v1 vulnerability
    USB: fix the usbfs flag sanitization for control transfers
    usb: xhci: pci: Enable Intel USB role mux on Apollo Lake platforms
    usb: roles: intel_xhci: Fix Unbalanced pm_runtime_enable
    cdc-acm: correct counting of UART states in serial state notification
    cdc-acm: do not reset notification buffer index upon urb unlinking
    cdc-acm: fix race between reset and control messaging
    usb: usbip: Fix BUG: KASAN: slab-out-of-bounds in vhci_hub_control()
    selftests: usbip: add wait after attach and before checking port status

    Greg Kroah-Hartman
     
  • Jens writes:
    "Block fixes for 4.19-final

    Two small fixes that should go into this release."

    * tag 'for-linus-20181019' of git://git.kernel.dk/linux-block:
    block: don't deal with discard limit in blkdev_issue_discard()
    nvme: remove ns sibling before clearing path

    Greg Kroah-Hartman
     

19 Oct, 2018

7 commits

  • The calculated ideal rate can easily overflow an unsigned long, thus
    making the best div selection buggy as soon as no ideal match is found
    before the overflow occurs.

    Fixes: 4731a72df273 ("drm/sun4i: request exact rates to our parents")
    Cc:
    Signed-off-by: Boris Brezillon
    Acked-by: Maxime Ripard
    Signed-off-by: Maxime Ripard
    Link: https://patchwork.freedesktop.org/patch/msgid/20181018100250.12565-1-boris.brezillon@bootlin.com

    Boris Brezillon
     
  • David writes:
    "Networking

    1) Fix gro_cells leak in xfrm layer, from Li RongQing.

    2) BPF selftests change RLIMIT_MEMLOCK blindly, don't do that. From
    Eric Dumazet.

    3) AF_XDP calls synchronize_net() under RCU lock, fix from Björn
    Töpel.

    4) Out of bounds packet access in _decode_session6(), from Alexei
    Starovoitov.

    5) Several ethtool bugs, where we copy a struct into the kernel twice
    and our validations of the values in the first copy can be
    invalidated by the second copy due to asynchronous updates to the
    memory by the user. From Wenwen Wang.

    6) Missing netlink attribute validation in cls_api, from Davide
    Caratti.

    7) LLC SAP sockets neet to be SOCK_RCU FREE, from Cong Wang.

    8) rxrpc operates on wrong kvec, from Yue Haibing.

    9) A regression was introduced by the disassosciation of route
    neighbour references in rt6_probe(), causing probe for
    neighbourless routes to not be properly rate limited. Fix from
    Sabrina Dubroca.

    10) Unsafe RCU locking in tipc, from Tung Nguyen.

    11) Use after free in inet6_mc_check(), from Eric Dumazet.

    12) PMTU from icmp packets should update the SCTP transport pathmtu,
    from Xin Long.

    13) Missing peer put on error in rxrpc, from David Howells.

    14) Fix pedit in nfp driver, from Pieter Jansen van Vuuren.

    15) Fix overflowing shift statement in qla3xxx driver, from Nathan
    Chancellor.

    16) Fix Spectre v1 in ptp code, from Gustavo A. R. Silva.

    17) udp6_unicast_rcv_skb() interprets udpv6_queue_rcv_skb() return
    value in an inverted manner, fix from Paolo Abeni.

    18) Fix missed unresolved entries in ipmr dumps, from Nikolay
    Aleksandrov.

    19) Fix NAPI handling under high load, we can completely miss events
    when NAPI has to loop more than one time in a cycle. From Heiner
    Kallweit."

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (49 commits)
    ip6_tunnel: Fix encapsulation layout
    tipc: fix info leak from kernel tipc_event
    net: socket: fix a missing-check bug
    net: sched: Fix for duplicate class dump
    r8169: fix NAPI handling under high load
    net: ipmr: fix unresolved entry dumps
    net: mscc: ocelot: Fix comment in ocelot_vlant_wait_for_completion()
    sctp: fix the data size calculation in sctp_data_size
    virtio_net: avoid using netif_tx_disable() for serializing tx routine
    udp6: fix encap return code for resubmitting
    mlxsw: core: Fix use-after-free when flashing firmware during init
    sctp: not free the new asoc when sctp_wait_for_connect returns err
    sctp: fix race on sctp_id2asoc
    r8169: re-enable MSI-X on RTL8168g
    net: bpfilter: use get_pid_task instead of pid_task
    ptp: fix Spectre v1 vulnerability
    net: qla3xxx: Remove overflowing shift statement
    geneve, vxlan: Don't set exceptions if skb->len < mtu
    geneve, vxlan: Don't check skb_dst() twice
    sctp: get pr_assoc and pr_stream all status with SCTP_PR_SCTP_ALL instead
    ...

    Greg Kroah-Hartman
     
  • David writes:
    "Sparc fixes:

    The main bit here is fixing how fallback system calls are handled in
    the sparc vDSO.

    Unfortunately, I fat fingered the commit and some perf debugging
    hacks slipped into the vDSO fix, which I revert in the very next
    commit."

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc:
    sparc: Revert unintended perf changes.
    sparc: vDSO: Silence an uninitialized variable warning
    sparc: Fix syscall fallback bugs in VDSO.

    Greg Kroah-Hartman
     
  • Dave writes:
    "drm fixes for 4.19 final

    Just a last set of misc core fixes for final.

    4 fixes, one use after free, one fb integration fix, one EDID fix,
    and one laptop panel quirk,"

    * tag 'drm-fixes-2018-10-19' of git://anongit.freedesktop.org/drm/drm:
    drm/edid: VSDB yCBCr420 Deep Color mode bit definitions
    drm: fix use of freed memory in drm_mode_setcrtc
    drm: fb-helper: Reject all pixel format changing requests
    drm/edid: Add 6 bpc quirk for BOE panel in HP Pavilion 15-n233sl

    Greg Kroah-Hartman
     
  • Doug writes:
    "Really final for-rc pull request for 4.19

    Ok, so last week I thought we had sent our final pull request for
    4.19. Well, wouldn't ya know someone went and found a couple Spectre
    v1 fixes were needed :-/. So, a couple *very* small specter patches
    for this (hopefully) final -rc week."

    * tag 'for-gkh' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma:
    RDMA/ucma: Fix Spectre v1 vulnerability
    IB/ucm: Fix Spectre v1 vulnerability

    Greg Kroah-Hartman
     
  • We already build the swiotlb code for 32-bit kernels with PAE support,
    but the code to actually use swiotlb has only been enabled for 64-bit
    kernels for an unknown reason.

    Before Linux v4.18 we paper over this fact because the networking code,
    the SCSI layer and some random block drivers implemented their own
    bounce buffering scheme.

    [ mingo: Changelog fixes. ]

    Fixes: 21e07dba9fb1 ("scsi: reduce use of block bounce buffers")
    Fixes: ab74cfebafa3 ("net: remove the PCI_DMA_BUS_IS_PHYS check in illegal_highdma")
    Reported-by: Matthew Whitehead
    Signed-off-by: Christoph Hellwig
    Signed-off-by: Thomas Gleixner
    Tested-by: Matthew Whitehead
    Cc: konrad.wilk@oracle.com
    Cc: iommu@lists.linux-foundation.org
    Cc: stable@vger.kernel.org
    Link: https://lkml.kernel.org/r/20181014075208.2715-1-hch@lst.de
    Signed-off-by: Ingo Molnar

    Christoph Hellwig
     
  • drm-misc-fixes for v4.19:
    - Fix use of freed memory in drm_mode_setcrtc.
    - Reject pixel format changing requests in fb helper.
    - Add 6 bpc quirk for HP Pavilion 15-n233sl
    - Fix VSDB yCBCr420 Deep Color mode bit definitions

    Signed-off-by: Dave Airlie

    From: Maarten Lankhorst
    Link: https://patchwork.freedesktop.org/patch/msgid/647fe5d0-4ec5-57cc-9f23-a4836b29e278@linux.intel.com

    Dave Airlie