Eric Lee / smarc-fsl-linux-kernel

13 Jun, 2015

1 commit

  • 0007fa362   power_supply: bq25890: use flags argument of devm_gpiod_get ... Browse Code »

    Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
    which appeared in v3.17-rc1, the gpiod_get* functions take an additional
    parameter that allows to specify direction and initial value for output.

    Simplify driver accordingly. Furthermore this is one caller less that
    stops us making the flags argument to gpiod_get*() mandatory.

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Sebastian Reichel

    Uwe Kleine-König
     

03 Jun, 2015

1 commit

  • 23fa43a28   power_supply: bq25890: make chip_id int ... Browse Code »

    Smatch static checker correctly detected an impossible condition because
    chip_id was declared as u8, instead of int:

    drivers/power/bq25890_charger.c:843 bq25890_probe()
    warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)'

    Also, while at it, fix the return value too.

    Signed-off-by: Laurentiu Palcu
    Reported-by: Dan Carpenter
    Reviewed-by: Krzysztof Kozlowski
    Signed-off-by: Sebastian Reichel

    Laurentiu Palcu
     

24 May, 2015

1 commit