Eric Lee / smarc-fsl-linux-kernel

04 Jun, 2016

1 commit

20 May, 2016

1 commit

  • fa5691131   rtc: remove useless DRV_VERSION ... Browse Code »

    Many drivers are defining a DRV_VERSION. This is often only used for
    MODULE_VERSION and sometimes to print an info message at probe time. This
    is kind of pointless as they are all versionned with the kernel anyway.
    Also the core will print a message when a new rtc is found.

    Signed-off-by: Alexandre Belloni

    Alexandre Belloni
     

15 Mar, 2016

6 commits

  • bae2f6470   rtc: pcf2123: implement read_offset and set_offset ... Browse Code »

    pcf2123 has an offset register, which can be used to make minor
    adjustments to the clock rate to compensate for temperature or
    a crystal that is not exactly right.

    Signed-off-by: Joshua Clayton
    Signed-off-by: Alexandre Belloni

    Joshua Clayton
     
  • f07fa9242   rtc: pcf2123: avoid resetting the clock if possible ... Browse Code »

    pcf2123 data sheet recommends a software reset when the chip
    is first powered on. This change avoids resetting the chip
    every time the driver is loaded, which has some negative effects.

    There are several registers including a clock rate adjustment that really
    should survive a reload of the driver (or reboot).

    In addition, stopping and restarting the clock to verify the chip is
    there is not a good thing once the time is set.

    According to the data sheet, the seconds register has a 1 in
    the high bit when the voltage has gotten low. We check for this
    condition, as well as whether the time retrieved from the chip is
    valid. We reset the rtc only if the time is not reliable and valid.
    This is sufficient for checking for the presence of the chip,
    as either all zeros or all 0xff will result in an invalid time/date

    Signed-off-by: Joshua Clayton
    Signed-off-by: Alexandre Belloni

    Joshua Clayton
     
  • 1e094b946   rtc: pcf2123: refactor chip reset into a function ... Browse Code »

    Refactor chip reset items into its own function, isolating it from
    the rest of the device probe.
    Subsequent commits will avoid calling this code.

    Signed-off-by: Joshua Clayton
    Signed-off-by: Alexandre Belloni

    Joshua Clayton
     
  • 809b453b7   rtc: pcf2123: clean up writes to the rtc chip ... Browse Code »

    Add new functions pcf2123_write(), and pcf2123_write_reg().
    Use named defines for the values being written.

    This improves modularity and readability, and reduces lines of code.

    Signed-off-by: Joshua Clayton
    Signed-off-by: Alexandre Belloni

    Joshua Clayton
     
  • 66c056d6a   rtc: pcf2123: clean up reads from the chip ... Browse Code »

    Put read operations into a function.
    This improves modularity and readability.

    Signed-off-by: Joshua Clayton
    Signed-off-by: Alexandre Belloni

    Joshua Clayton
     
  • 245cb74be   rtc: pcf2123: define registers and bit macros ... Browse Code »

    Add defines for all 16 registers in the pcf2123.
    Add defines for useful bits from several registers
    I've tried to document all the registers, and
    as best as possible, all the special bits they employ

    Use BIT() wherever possible in the bit definitions

    Signed-off-by: Joshua Clayton
    Signed-off-by: Alexandre Belloni

    Joshua Clayton
     

28 Oct, 2015

1 commit

05 Sep, 2015

1 commit

14 Feb, 2015

1 commit

13 Nov, 2013

1 commit

  • ffc75bb8f   drivers/rtc/rtc-pcf2123.c: use dev_get_platdata() ... Browse Code »

    Use the wrapper function for retrieving the platform data instead of
    accessing dev->platform_data directly. This is a cosmetic change to make
    the code simpler and enhance the readability.

    Signed-off-by: Jingoo Han
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jingoo Han
     

04 Jul, 2013

2 commits

30 Apr, 2013

2 commits

04 Jan, 2013

1 commit

  • 5a167f454   Drivers: rtc: remove __dev* attributes. ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitdata,
    __devinitconst, and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: Alessandro Zummo
    Cc: Srinidhi Kasagar
    Cc: Linus Walleij
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Guan Xuetao
    Cc: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

22 Aug, 2012

1 commit

  • 5ed12f128   drivers/rtc/rtc-pcf2123.c: initialize dynamic sysfs attributes ... Browse Code »

    Dynamically allocated sysfs attributes must be initialized using
    sysfs_attr_init(), otherwise lockdep complains: BUG: key

    not in
    .data!

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Ilya Shchepetkov
    Cc: Chris Verges
    Cc: Christian Pellegrin
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ilya Shchepetkov
     

24 Mar, 2012

1 commit

  • 109e94184   rtc: convert rtc spi drivers to module_spi_driver ... Browse Code »

    Factor out some boilerplate code for spi driver registration into
    module_spi_driver.

    Signed-off-by: Axel Lin
    Cc: Mark Jackson
    Cc: Dennis Aberilla
    Cc: Nikolaus Voss
    Cc: "Kim B. Heino"
    Cc: Raphael Assenat
    Cc: Chris Verges
    Cc: Magnus Damm
    Cc: Atsushi Nemoto
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     

11 Jan, 2012

1 commit

  • 6c3fb5579   drivers/rtc/: remove redundant spi driver bus initialization ... Browse Code »

    In ancient times it was necessary to manually initialize the bus field of
    an spi_driver to spi_bus_type. These days this is done in
    spi_driver_register(), so we can drop the manual assignment.

    The patch was generated using the following coccinelle semantic patch:
    //
    @@
    identifier _driver;
    @@
    struct spi_driver _driver = {
    .driver = {
    - .bus = &spi_bus_type,
    },
    };
    //

    Signed-off-by: Lars-Peter Clausen
    Cc: John Stultz
    Cc: Alessandro Zummo
    Cc: Grant Likely
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Lars-Peter Clausen
     

01 Nov, 2011

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

07 Mar, 2010

1 commit

23 Sep, 2009

2 commits