20 Jul, 2016
2 commits
-
The current rtc-pcf85063 driver only supports the PCF85063TP device.
Using the existing driver on a PCF85063A will result in the time being
set correctly into the RTC, but the RTC is held in the stopped state.
Therefore, the time will no longer advance and no error is indicated.The PCF85063A device has a bigger memory map than the PCF85063TP.
The existing driver make use of an address rollover condition,
but the rollover point is different in the two devices.Signed-off-by: Chris DeBruin
Signed-off-by: Alexandre Belloni -
The year range is not validated properly
As the driver has been mainlined in 2014, it is not an issue to stop
handling dates between 1970 and 2000 with the benefit of handling dates up
to 2100.Signed-off-by: Alexandre Belloni
15 Mar, 2016
6 commits
-
No members of struct pcf85063 are used anymore, remove the whole structure.
Reviewed-by: Juergen Borleis
Signed-off-by: Alexandre Belloni -
Since the driver is mainlined there is no use for a separate version
number.Signed-off-by: Alexandre Belloni
-
pcf85063_get_datetime() tries to handle a century bit but that bit is not
documented and the final value is never used anywhere else in the kernel.Reviewed-by: Juergen Borleis
Tested-by: Ulrich Ölmann
Signed-off-by: Alexandre Belloni -
When setting a new time/date the RTC's clock must be stopped first, in
order to write the time/date registers in an atomic manner.
So, this change stops the clock first and then writes the time/date
registers and the clock control register (to re-enable the clock) in one
turn.Signed-off-by: Juergen Borleis
Signed-off-by: Alexandre Belloni -
Check if the RTC signals an invalid time/date (due to a battery power loss
for example). In this case ignore the time/date until it is really set again.Signed-off-by: Juergen Borleis
Signed-off-by: Alexandre Belloni -
By using i2c_smbus_read_i2c_block_data() the code is now much simpler.
While at it: when reading the RTC's seconds register, all time/date registers
are frozen until the RTC's year register is read. So it is important to read
all time/date registers in one turn to not lose a second event. Make it more
clear why the read must happen in this way.Signed-off-by: Juergen Borleis
Signed-off-by: Alexandre Belloni
08 Nov, 2015
1 commit
-
Return an error when the date is invalid as the policy should be
implemented there.Signed-off-by: Alexandre Belloni
05 Sep, 2015
1 commit
-
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Alexandre Belloni
09 Aug, 2014
1 commit
-
Add support for the pcf85063 rtc chip.
[akpm@linux-foundation.org: fix comment typo, tweak conding style]
Signed-off-by: Soeren Andersen
Cc: Alessandro Zummo
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
