11 Oct, 2007

1 commit

  • This patch makes /proc/net per network namespace. It modifies the global
    variables proc_net and proc_net_stat to be per network namespace.
    The proc_net file helpers are modified to take a network namespace argument,
    and all of their callers are fixed to pass &init_net for that argument.
    This ensures that all of the /proc/net files are only visible and
    usable in the initial network namespace until the code behind them
    has been updated to be handle multiple network namespaces.

    Making /proc/net per namespace is necessary as at least some files
    in /proc/net depend upon the set of network devices which is per
    network namespace, and even more files in /proc/net have contents
    that are relevant to a single network namespace.

    Signed-off-by: Eric W. Biederman
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

09 Oct, 2007

1 commit


27 Aug, 2007

1 commit


22 Aug, 2007

1 commit

  • This fixes handling of USB ISO completion error -EXDEV and includes
    several other changes to current CVS version at isdn4linux.de (changes
    in debug flags, style of code remarks, etc)

    Signed-off-by: Martin Bachem
    Acked-by: Karsten Keil
    Signed-off-by: Linus Torvalds

    Martin Bachem
     

01 Aug, 2007

1 commit


22 Jul, 2007

3 commits

  • Change Kconfig objects from "menu, config" into "menuconfig" so that the user
    can disable the whole feature without having to enter the menu first.

    Signed-off-by: Jan Engelhardt
    Cc: Tilman Schmidt
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Engelhardt
     
  • Unclutter the ISDN menu a tiny bit by moving ISDN4Linux and the CAPI2.0
    layers into their own menu.

    Signed-off-by: Jan Engelhardt
    Cc: Tilman Schmidt
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Engelhardt
     
  • Remove a menu statement and several dependencies from the Kconfig files in
    the drivers/isdn tree as they have become unnecessary by the transformation
    of CONFIG_ISDN from "menu, config" into "menuconfig".
    (Modified version of a patch originally proposed by Jan Engelhardt.)

    Signed-off-by: Tilman Schmidt
    Cc: Jan Engelhardt
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     

20 Jul, 2007

1 commit

  • There is check_reset() -- global function in drivers/isdn/sc/
    There is check_reset -- variable holding module param in aacraid driver.

    On allyesconfig they clash with:

    LD drivers/built-in.o
    drivers/isdn/built-in.o: In function `check_reset':
    : multiple definition of `check_reset'
    drivers/scsi/built-in.o:(.data+0xe458): first defined here
    ld: Warning: size of symbol `check_reset' changed from 4 in drivers/scsi/built-in.o to 219 in drivers/isdn/built-in.o
    ld: Warning: type of symbol `check_reset' changed from 1 to 2 in drivers/isdn/built-in.o

    Rename the former.

    Signed-off-by: Alexey Dobriyan
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     

19 Jul, 2007

1 commit

  • Coverity (1792) spotted a possibly uninitialized return value in case of
    kmalloc() failure:

    1116 static int hisax_cs_setup(int cardnr, struct IsdnCard *card,
    1117 struct IsdnCardState *cs)
    1119 int ret;
    1120
    1121 if (!(cs->rcvbuf = kmalloc(MAX_DFRAME_LEN_L1, GFP_ATOMIC))) {
    1122 printk(KERN_WARNING "HiSax: No memory for isac rcvbuf\n");
    1123 ll_unload(cs);
    1124 goto outf_cs;
    ...
    1165 outf_cs:
    1166 kfree(cs);
    1167 card->cs = NULL;
    1168 return ret;

    The straightforward solution would be to just add the missing
    initialization but hardcoding the return value in the out_cs branch
    (only taken on failure) seems to work just as well and it allows killing
    a couple of other lines too.

    Signed-off-by: Florin Malita
    Signed-off-by: Jeff Garzik

    Florin Malita
     

18 Jul, 2007

17 commits


12 Jul, 2007

1 commit

  • Instead of all drivers reading pci config space to get the revision
    ID, they can now use the pci_device->revision member.

    This exposes some issues where drivers where reading a word or a dword
    for the revision number, and adding useless error-handling around the
    read. Some drivers even just read it for no purpose of all.

    In devices where the revision ID is being copied over and used in what
    appears to be the equivalent of hotpath, I have left the copy code
    and the cached copy as not to influence the driver's performance.

    Compile tested with make all{yes,mod}config on x86_64 and i386.

    Signed-off-by: Auke Kok
    Acked-by: Dave Jones
    Signed-off-by: Greg Kroah-Hartman

    Auke Kok
     

09 Jun, 2007

1 commit

  • __exit function is used by both init and exit routines, so it cannot
    be marked __init. (from allyesconfig)

    WARNING: drivers/built-in.o(.text+0x9b83cf): Section mismatch: reference to .exit.text: (between 'divasfunc_exit' and 'didd_callback')

    Signed-off-by: Randy Dunlap
    Cc: Karsten Keil
    Acked-by: Armin Schindler
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

01 Jun, 2007

3 commits

  • Fix the following section mismatch warnings:

    WARNING: drivers/isdn/hardware/eicon/divadidd.o(.init.text+0xc4): Section mismatch: reference to .exit.text: (between 'init_module' and 'diddfunc_init')
    WARNING: drivers/isdn/hardware/eicon/divas.o(.init.text+0xf4): Section mismatch: reference to .exit.text:divasfunc_exit (between 'init_module' and 'divasfunc_init')
    WARNING: drivers/isdn/hardware/eicon/divas.o(.init.text+0x10d): Section mismatch: reference to .exit.text:divasfunc_exit (between 'init_module' and 'divasfunc_init')
    WARNING: drivers/isdn/hardware/eicon/divas.o(.init.text+0x148): Section mismatch: reference to .exit.text:divasfunc_exit (between 'init_module' and 'divasfunc_init')

    They all point to situation whare a function marked __init calls a function
    marked __exit - but the __exit section may have been discarded.

    Note: This warning is generated by a modified copy of modpost in my
    tree. It will soon hit upstearm.

    Signed-off-by: Sam Ravnborg
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sam Ravnborg
     
  • I noticed that CLIR (aka "hide your calling number") in isdn_tty is broken:
    The at-command parser filters out the required "R" (e.g. ATDR089123456)
    It's been broken for a *very* long time.

    Signed-off-by: Karsten Keil
    Signed-off-by: Matthias Goebl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Karsten Keil
     
  • According to the definitions recently posted on LKML, the maturity label
    for the ISDN4Linux subsystem is wrong. This patch corrects it and also
    clarifies the accompanying help text a bit.

    Signed-off-by: Tilman Schmidt
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     

24 May, 2007

3 commits

  • Squash these:

    drivers/isdn/hardware/eicon/message.c: In function 'api_put':
    drivers/isdn/hardware/eicon/message.c:536: warning: cast from pointer to integer of different size
    drivers/isdn/hardware/eicon/message.c: In function 'plci_free_msg_in_queue':
    drivers/isdn/hardware/eicon/message.c:1035: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/message.c: In function 'data_b3_req':
    drivers/isdn/hardware/eicon/message.c:3121: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/message.c:3154: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/message.c: In function 'callback':
    drivers/isdn/hardware/eicon/message.c:4060: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/message.c: In function 'nl_ind':
    drivers/isdn/hardware/eicon/message.c:7137: warning: cast from pointer to integer of different size

    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • squish these:

    drivers/isdn/hardware/eicon/capifunc.c: In function 'TransmitBufferSet':
    drivers/isdn/hardware/eicon/capifunc.c:192: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/capifunc.c: In function 'TransmitBufferGet':
    drivers/isdn/hardware/eicon/capifunc.c:197: warning: cast from pointer to integer of different size
    drivers/isdn/hardware/eicon/capifunc.c:198: warning: cast from pointer to integer of different size
    drivers/isdn/hardware/eicon/capifunc.c:200: warning: cast from pointer to integer of different size
    drivers/isdn/hardware/eicon/capifunc.c: In function 'TransmitBufferFree':
    drivers/isdn/hardware/eicon/capifunc.c:205: warning: cast from pointer to integer of different size
    drivers/isdn/hardware/eicon/capifunc.c:206: warning: cast from pointer to integer of different size
    drivers/isdn/hardware/eicon/capifunc.c: In function 'sendf':
    drivers/isdn/hardware/eicon/capifunc.c:304: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/capifunc.c:304: warning: cast to pointer from integer of different size
    drivers/isdn/hardware/eicon/capifunc.c:321: warning: cast to pointer from integer of different size

    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • This patch (as875) adds error-checking to the callers of hisax_register().
    It also changes an error pathway in that routine, making it return an error
    code rather than 0.

    This fixes Bugzilla #7960.

    Signed-off-by: Alan Stern
    Acked-by: Karsten Keil
    Cc: Martin Bachem
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Stern
     

22 May, 2007

1 commit

  • First thing mm.h does is including sched.h solely for can_do_mlock() inline
    function which has "current" dereference inside. By dealing with can_do_mlock()
    mm.h can be detached from sched.h which is good. See below, why.

    This patch
    a) removes unconditional inclusion of sched.h from mm.h
    b) makes can_do_mlock() normal function in mm/mlock.c
    c) exports can_do_mlock() to not break compilation
    d) adds sched.h inclusions back to files that were getting it indirectly.
    e) adds less bloated headers to some files (asm/signal.h, jiffies.h) that were
    getting them indirectly

    Net result is:
    a) mm.h users would get less code to open, read, preprocess, parse, ... if
    they don't need sched.h
    b) sched.h stops being dependency for significant number of files:
    on x86_64 allmodconfig touching sched.h results in recompile of 4083 files,
    after patch it's only 3744 (-8.3%).

    Cross-compile tested on

    all arm defconfigs, all mips defconfigs, all powerpc defconfigs,
    alpha alpha-up
    arm
    i386 i386-up i386-defconfig i386-allnoconfig
    ia64 ia64-up
    m68k
    mips
    parisc parisc-up
    powerpc powerpc-up
    s390 s390-up
    sparc sparc-up
    sparc64 sparc64-up
    um-x86_64
    x86_64 x86_64-up x86_64-defconfig x86_64-allnoconfig

    as well as my two usual configs.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     

10 May, 2007

1 commit


09 May, 2007

3 commits