08 Feb, 2008
3 commits
-
Make kernel-doc warn when a function/struct/union/typedef does not contain
a properly formatted short description, such as:
* scsi_devinfo: set up the dynamic device list
or
* scsi_devinfo -This warning is only generated when verbose (-v) mode is used.
Also explain the -v command line option in the -h output.
Signed-off-by: Randy Dunlap
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Prevent duplicate output of a Description: section when there is a "blank"
("*") line between the initial function name/description line and the
"Description:" header.Test case: drivers/scsi/scsi_devinfo.c::scsi_init_devinfo().
Rob Landley hit this while he was producing SCSI kernel-doc.
Signed-off-by: Randy Dunlap
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Fix kernel-doc function prototype parsing which was exposed by vunmap() by
allowing more than one '*' before the function name.Error(linux-2.6.24-mm1//mm/vmalloc.c:438): cannot understand prototype: 'struct page **vunmap(const void *addr) '
Signed-off-by: Randy Dunlap
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
07 Feb, 2008
3 commits
-
I have been prime author and maintainer of block2mtd from day one, but
neither MAINTAINERS nor the module source makes this fact clear. And while
I'm at it, update my email addresses tree-wide, as the old address
currently bounces and change my name to "joern" as unicode will likely
continue to cause trouble until the end of this century.Signed-off-by: Joern Engel
Cc: David Woodhouse
Cc: Andy Whitcroft
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
When resolving symbol names from addresses with aliased symbol names,
kallsyms_lookup always returns the first symbol, even if it is a weak
symbol.This patch changes this by sorting the symbols with the weak symbols last
before feeding them to the kernel. This way the kernel runtime isn't
changed at all, only the kallsyms build system is changed.Another side effect is that the symbols get sorted by address, too. So,
even if future binutils version have some bug in "nm" that makes it fail to
correctly sort symbols by address, the kernel won't be affected by this.Mathieu says:
I created a module in LTTng that uses kallsyms to get the symbol
corresponding to a specific system call address. Unfortunately, all the
unimplemented syscalls were all referring to the (same) weak symbol
identifying an unrelated system call rather that sys_ni (or whatever
non-weak symbol would be expected). Kallsyms was dumbly returning the first
symbol that matched.This patch makes sure kallsyms returns the non-weak symbol when there is
one, which seems to be the expected result.[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Mathieu Desnoyers
Looks-great-to: Rusty Russell
Cc: Sam Ravnborg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
When passing a zero address to kallsyms_lookup(), the kernel thought it was
a valid kernel address, even if it is not. This is because is_ksym_addr()
called is_kernel_extratext() and checked against labels that don't exist on
many archs (which default as zero). Since PPC was the only kernel which
defines _extra_text, (in 2005), and no longer needs it, this patch removes
_extra_text support.For some history (provided by Jon):
http://ozlabs.org/pipermail/linuxppc-dev/2005-September/019734.html
http://ozlabs.org/pipermail/linuxppc-dev/2005-September/019736.html
http://ozlabs.org/pipermail/linuxppc-dev/2005-September/019751.html[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Robin Getz
Cc: David Woodhouse
Cc: Jon Loeliger
Cc: Paul Mackerras
Cc: Benjamin Herrenschmidt
Cc: Sam Ravnborg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
03 Feb, 2008
5 commits
-
follow git and mercurial style, include uncommitted changes detect
Cc: Frans Pop
Signed-off-by: Bryan Wu
Signed-off-by: Sam Ravnborg -
We have several legitimate uses where we export symbols
annotated with one of:
__devinit, __cpuinit, __meminit and their exit counterpart.
So let's stop warning about those being exported in favour
of adding all sorts of workaround to silence the warning.Signed-off-by: Sam Ravnborg
-
We have had warnings for a long time about select of unknow symbol
but the warnings does not really makes sense since we may
select a symbol that is relevant and defined in one
arch but not in another arch.
And as long as we do not use a common set of Kconfig files
for all archs lets just ignore this case.Previously we have used this to find bad uses of
select but we need a more relaible method to do so.Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Michal Zachar reported that
menuconfig did not save the new config when loading
an alternate config unless he altered it manually.Mark config as changed upon load of alternate config fixed this.
Signed-off-by: Sam Ravnborg
Roman Zippel -
We have too many section mismatches detected at the moment.
So silence modpost and prevent the option from being
set in a typical allyesconfig build.Tell the user how to see all the deteils in the summary
message from modpost.Signed-off-by: Sam Ravnborg
02 Feb, 2008
1 commit
-
Some crazy devices in the wild have a vendor id of 0x0000. If we try to
add a module alias with this id, we just can't do it due to a check in
the file2alias.c file. Change the test to verify that both the vendor
and product ids are 0x0000 to show a real "blank" module alias.Note, the module-init-tools package also needs to be changed to properly
generate the depmod tables.Cc: Janusz
Cc: stable
Cc: Jon Masters
Signed-off-by: Greg Kroah-Hartman
29 Jan, 2008
28 commits
-
If there is a mixture of specifying sections for code in gcc
and assembler then if the assembler code do not add
the "ax" flags the linker will see this as two different sections
and generate unique sections for each. ld does so by adding a dot
and a number.
Teach modpost to warn if a section shows up that match this
pattern - but do this only for non-debug sections.It will result in warnings like this:
WARNING: vmlinux.o (.sched.text.1): unexpected section name.
The (.[number]+) following section name are ld generated and not expected.
Did you forget to use "ax"/"aw" in a .S file?
Note that for example contains
section definitions for use in .S files.All warnings seen with a defconfig build for:
x86 (32+64bit) and sparc64 has been fixed (via respective maintainers).arm, powerpc (64 bit), s390 (32 bit), ia64, alpha, sh4 checked - no
warnings seen with a defconfig build.Signed-off-by: Sam Ravnborg
-
If the config option CONFIG_SECTION_MISMATCH is not set and
we see a Section mismatch present the following to the user:modpost: Found 1 section mismatch(es).
To see additional details select "Enable full Section mismatch analysis"
in the Kernel Hacking menu (CONFIG_SECTION_MISMATCH).If the option CONFIG_SECTION_MISMATCH is selected
then be verbose in the Section mismatch reporting from mdopost.
Sample outputs:WARNING: o-x86_64/vmlinux.o(.text+0x7396): Section mismatch in reference from the function discover_ebda() to the variable .init.data:ebda_addr
The function discover_ebda() references
the variable __initdata ebda_addr.
This is often because discover_ebda lacks a __initdata
annotation or the annotation of ebda_addr is wrong.WARNING: o-x86_64/vmlinux.o(.data+0x74d58): Section mismatch in reference from the variable pci_serial_quirks to the function .devexit.text:pci_plx9050_exit()
The variable pci_serial_quirks references
the function __devexit pci_plx9050_exit()
If the reference is valid then annotate the
variable with __exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,WARNING: o-x86_64/vmlinux.o(__ksymtab+0x630): Section mismatch in reference from the variable __ksymtab_arch_register_cpu to the function .cpuinit.text:arch_register_cpu()
The symbol arch_register_cpu is exported and annotated __cpuinit
Fix this by removing the __cpuinit annotation of arch_register_cpu or drop the export.Signed-off-by: Sam Ravnborg
-
Change kconfig behavior so that mixing bool and tristate config
settings in a choice is possible and has the desired effect of offering
just the tristate options individually if the choice gets set to M, and
a normal boolean selection if the choice gets set to Y.Also fix scripts/kconfig/conf's handling of children of choice values -
there may be more than one immediate child, and all of them need to be
processed.Signed-off-by: Jan Beulich
Cc: "Roman Zippel"
Signed-off-by: Sam Ravnborg -
Remove the deprecated __attribute_used__.
[Introduce __section in a few places to silence checkpatch /sam]
Signed-off-by: Adrian Bunk
Signed-off-by: Sam Ravnborg -
Signed-off-by: Daniel De Graaf
Signed-off-by: Sam Ravnborg -
Kconfig had a synonym "enable" for "select" that was neither documented
nor used.Signed-off-by: Adrian Bunk
Cc: Roman Zippel
Signed-off-by: Sam Ravnborg -
Refactor code so the warning report function
does nothing else than reporting warnings.
As a side effect some other code paths were cleaned
up by this.Signed-off-by: Sam Ravnborg
-
Introducing helpers to retreive symbol and section
names cleaned up the code a bit.Signed-off-by: Sam Ravnborg
-
The typical layout is now:
WARNING: vmlinux.o(.text+0x372ec): Section mismatch: reference to .devinit.text:pci_scan_one_pbm in 'psycho_scan_bus'This is first step towards more readable warnings.
Signed-off-by: Sam Ravnborg
-
Setting the option DEBUG_SECTION_MISMATCH will
report additional section mismatch'es but this
should in the end makes it possible to get rid of
all of them.See help text in lib/Kconfig.debug for details.
Signed-off-by: Sam Ravnborg
-
Introducing separate sections for __dev* (HOTPLUG),
__cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG)
allows us to do a much more reliable Section mismatch
check in modpost. We are no longer dependent on the actual
configuration of for example HOTPLUG.This has the effect that all users see much more
Section mismatch warnings than before because they
were almost all hidden when HOTPLUG was enabled.
The advantage of this is that when building a piece
of code then it is much more likely that the Section
mismatch errors are spotted and the warnings will be
felt less random of nature.Signed-off-by: Sam Ravnborg
Cc: Greg KH
Cc: Randy Dunlap
Cc: Adrian Bunk -
Now that match() is introduced use it consistently so
we can share the section name definitions.Signed-off-by: Sam Ravnborg
-
Change the logic in modpost so we identify all the
bad combinations of sections that refer to other
sections.
Compared to the previous approach we are much less
dependent on knowledge of what additional sections
the tool chain uses and thus we can keep the false
positives low.The implmentation is changed to use a table based
lookup and we now check all combinations in first
pass so we no longer need separate passes for init
and exit sections.Tested that the same warnings are generated for
an allyesconfig build without CONFIG_HOTPLUG.Signed-off-by: Sam Ravnborg
Cc: Randy Dunlap
Cc: Adrian Bunk -
Split a too long function up in smaller bits to make
prgram logic easier to follow.
A few related changes done due to parameter
changes.No functional changes.
Signed-off-by: Sam Ravnborg
-
The relocation record sometimes contained an address
which was not an exactly match for a symbol.Implment some simple logic such that if there
is a symbol within 20 bytes of the address contained
in the relocation record then print the name of this
symbol.With this change modpost could find symbol names
for the remaining .init.text symbols in my
allyesconfig build for x86_64.Signed-off-by: Sam Ravnborg
-
It is very convinient to say:
scripts/mod/modpost mm/built-in.oto check if any section mismatch errors occured
in mm/ (as an example).
Fix it so this is possible again.Signed-off-by: Sam Ravnborg
-
Remove the tmp file when exiting. Noticed by Arjan van de Ven.
Catch mktemp failure and exit with message.
Trap kill or other signals and exit cleanly.Signed-off-by: Randy Dunlap
Signed-off-by: Sam Ravnborg -
Use the environment option to provide the ARCH symbol
and the KERNELVERSION symbol.Signed-off-by: Roman Zippel
Signed-off-by: Sam Ravnborg -
Add the possibility to import a value from the environment into kconfig
via the option syntax. Beside flexibility this has the advantage
providing proper dependencies.
Documented the options syntax.Signed-off-by: Roman Zippel
Signed-off-by: Sam Ravnborg -
Rename E_CHOICE to E_LIST to explicitly add support for expression
lists. Add a helper macro expr_list_for_each_sym to more easily iterate
over the list.Signed-off-by: Roman Zippel
Signed-off-by: Sam Ravnborg -
Gettext support for symbol names are unnecessary.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Gettext support for conf.c
[Include locale.h by Kyle].
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel
Cc: Kyle McMartin -
Gettext support for lxdialog.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Full gettext support for menuconfig.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Full gettext support for xconfig.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
This patch removes the indirect I18N support for config file.
Signed-off-by: Egry Gabor
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
Gettext support for menu and toolbar.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel -
This patch adds missing gettext macros.
Signed-off-by: Egry Gabor
Reviewed-by: Sam Ravnborg
Signed-off-by: Sam Ravnborg
Cc: Roman Zippel
