09 Sep, 2016
40 commits
-
Several routines are somewhat documented at v4l2-mem2mem.c
file. Move what's there to the header file.Signed-off-by: Mauro Carvalho Chehab
-
Fix this warning:
Documentation/media/kapi/mc-core.rst:97: WARNING: c:func reference target not found: media_devnode_releaseThe media_device_release() is a function internal to media-devnode.c,
and not exported elsewhere. So, we can't cross-reference it here.
Make it explicit at the documentation.Signed-off-by: Mauro Carvalho Chehab
-
./include/media/rc-map.h:121: WARNING: Inline emphasis start-string without end-string.
Signed-off-by: Mauro Carvalho Chehab
-
There's a typo there, causing 4 warnings:
Documentation/media/uapi/rc/lirc-read.rst:26: WARNING: c:type reference target not found: name
Documentation/media/uapi/rc/lirc-read.rst:26: WARNING: c:type reference target not found: lirc
Documentation/media/uapi/v4l/func-poll.rst:25: WARNING: c:type reference target not found: name
Documentation/media/uapi/v4l/func-poll.rst:25: WARNING: c:type reference target not found: v4l2Fix them.
Signed-off-by: Mauro Carvalho Chehab
-
One reference there is still using :ref:. Fix it, to solve this
warning:
Documentation/media/uapi/mediactl/media-ioc-g-topology.rst:236: WARNING: undefined label: media-v2-intf-devnode (if the link has no caption the label must precede a section header)Signed-off-by: Mauro Carvalho Chehab
-
The struct v4l2_mpeg_vbi_ITV0 is identical to struct v4l2_mpeg_vbi_itv0,
except by its size, and it is documented at the same place at the
book.Fix cross reference for it.
Signed-off-by: Mauro Carvalho Chehab
-
There are several broken references there, due to the conversion to
C domain. Fix them using this shell script and manually adjust what's
broken:# funcs is a file with the broken functions/references
for i in $(cat funcs|sort|uniq|perl -ne 'print "$1\n" if (m/(\S+)$/)'); do
i=${i//-/_}
echo $i
j=${i//_/-}
for k in $(git grep -l "_$j:" Documentation/); do
sed s,\_$j\:,"c\:type\:\: $i", a && mv a $k
done
for k in $(git grep -l "$j" Documentation/media/*.exceptions); do
sed s,$j,":c\:type\:\`$i\`", a && mv a $k
done
for k in $(git grep -l "$j" Documentation/); do
sed "s,:ref:\`$i \`,:c:type:\`$i\`," a && mv a $k
sed "s,:ref:\`$j\`,:c:type:\`$i\`," a && mv a $k
sed -E "s,:ref:\`(.*)\`,:c:type:\`\1\`," a && mv a $k
done
for k in $(git grep -l "" include/media); do
sed -E "s,:ref:\`(.*)\`,enum \&$i," a && mv a $k
done
doneSigned-off-by: Mauro Carvalho Chehab
-
Several structs were renamed or removed during V4L2 development.
Don't try to cross-reference the legacy ones.Signed-off-by: Mauro Carvalho Chehab
-
Use C cross-references to mention the V4L2 API calls on all
places it occurs inside this file.While here, also mark constants as such.
Signed-off-by: Mauro Carvalho Chehab
-
c:type is not the right tag for function definitions.
Replace them by .. c:function::Signed-off-by: Mauro Carvalho Chehab
-
Fix those warnings:
Documentation/media/uapi/cec/cec-ioc-dqevent.rst:124: WARNING: c:func reference target not found: clock_gettime(2)
By replacing it with the right function name, using this shell script:
for i in `find Documentation/media -type f`; do sed 's,clock_gettime(2),clock_gettime,' a && mv a $i; done
Please notice that this will make the nitpick mode to shut up
complaining about that, becasue clock_gettime is on its exclude list,
but the cross reference will be undefined until someone documents
this function at the core documentation.Signed-off-by: Mauro Carvalho Chehab
-
The :c:type: references point to the structure name, and not to
struct foo.Fixed via this shell script:
for i in `find Documentation/media -type f`; do perl -ne 'if (s/\:c\:type\:\`struct\s*(\S+)\`/struct :c:type:`$1`/) { s/struct\s+struct/struct/; s/(struct\s+\:c\:type\:\`\S+\`)\s+structure/$1/; } print $_' a && mv a $i; done
Signed-off-by: Mauro Carvalho Chehab
-
Instead of using c:type:`struct foo `, use:
struct c:type:`foo`This patch was generated via this shell script:
for i in `find Documentation/media -type f`; do perl -ne 'if (m/\:c\:type\:\`struct\s+(\S+)\s*\\`/) { $s=$1; $r=$2; if ($s eq $r) { s/\:c\:type\:\`struct\s+(\S+)\s*\\`/struct :c:type:`$2`/; s/struct\s+struct/struct/; s/(struct\s+\:c\:type\:\`\S+\`)\s+structure/$1/; }} print $_' a && mv a $i; done
Signed-off-by: Mauro Carvalho Chehab
-
Fix some CEC cross references that are broken.
Signed-off-by: Mauro Carvalho Chehab
-
Some structs are pointed via the typedef. As we replaced
those references, fix them.Signed-off-by: Mauro Carvalho Chehab
-
Trivially fix those broken references, by copying the structs
fron the header, just like other API documentation at the
DVB side.This doesn't have the level of quality used at the V4L2 side
of the API, but, as this documents a deprecated API, used
only by av7110 driver, it doesn't make much sense to invest
time making it better.Signed-off-by: Mauro Carvalho Chehab
-
Several links are broken, as they were using the typedef
name, instead of using the corresponding structs. Fix them.Signed-off-by: Mauro Carvalho Chehab
-
Add a table describing the fields on this struct, based
on ca.h header.Signed-off-by: Mauro Carvalho Chehab
-
Add documentation for struct ca_slot_info and for the two
sets of define used by it, according with what's there at the
ca.h header.Signed-off-by: Mauro Carvalho Chehab
-
There are no descriptions at ca.h header for this struct.
Yet, as we want to get rid of the warnings, let's add a
boilerplate, with just the struct types and fields.Signed-off-by: Mauro Carvalho Chehab
-
The documentation follows what's there at the ca.h header.
Signed-off-by: Mauro Carvalho Chehab
-
Add a flat-table describing struct ca_caps, as found at
the source file.Signed-off-by: Mauro Carvalho Chehab
-
Now that we moved away from the :ref: type of references,
we need to update the exceptions lists.Signed-off-by: Mauro Carvalho Chehab
-
One markup tag is wrong here.
Signed-off-by: Mauro Carvalho Chehab
-
There are two warnings that are due to functions that has long
gone:Documentation/media/kapi/v4l2-subdev.rst:417: WARNING: c:func reference target not found: v4l2_i2c_new_subdev_cfg
Documentation/media/kapi/v4l2-subdev.rst:436: WARNING: c:func reference target not found: v4l2_i2c_new_probed_subdevUpdate the documentation to remove those.
Signed-off-by: Mauro Carvalho Chehab
-
Now that scripts/kernel-doc was fixed to parse the typedef
argument used here, let it produce documentation.Signed-off-by: Mauro Carvalho Chehab
-
Fix some minor issues at the documentation tags on this file,
adding cross-references where needed, and fixing some broken
ones.While here, fix a few spaces before tabs to make Checkpatch happier.
Signed-off-by: Mauro Carvalho Chehab
-
The "struct" were inside the reference, causing it to break.
Acked-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
There are several undocumented functions here; document them.
While here, make checkpatch.pl happy.
Signed-off-by: Mauro Carvalho Chehab
-
Documentation/output/cec.h.rst:6: WARNING: c:type reference target not found: cec_event_state_change
Documentation/output/cec.h.rst:6: WARNING: c:type reference target not found: cec_event_state_change
Documentation/output/cec.h.rst:6: WARNING: c:type reference target not found: cec_event_lost_msgs
Documentation/output/cec.h.rst:6: WARNING: c:type reference target not found: cec_event_lost_msgs
Documentation/output/cec.h.rst:6: WARNING: c:type reference target not found: cec_event_state_change
Documentation/output/cec.h.rst:6: WARNING: c:type reference target not found: cec_event_lost_msgsSigned-off-by: Mauro Carvalho Chehab
-
Now that the uAPI is using c:type, let's use it here too.
Signed-off-by: Mauro Carvalho Chehab
-
Change the parse-headers.pl and the corresponding files to use
the C domain for enum references.Signed-off-by: Mauro Carvalho Chehab
-
The prepare_ext_ctrls() function is actually internal to the
v4l2-ctrls.c implementation, so it doesn't have a declaration
for the kAPI header to reference it.Signed-off-by: Mauro Carvalho Chehab
-
The V4L version 1 structures had long gone from the Linux Kernel.
It doesn't make sense to use cross-references for them, as they
won't be found.So, get rid of them.
Signed-off-by: Mauro Carvalho Chehab
-
instead of declaring the uAPI structs using usual refs, e. g.:
.. _foo-struct:Use the C domain way:
.. c:type:: foo_structThis way, the kAPI documentation can use cross-references to
point to the uAPI symbols.That solves about ~100 undefined warnings like:
WARNING: c:type reference target not found: foo_structSigned-off-by: Mauro Carvalho Chehab
-
The typedefs and a macro are not defined. While here, improve a
few bits on the documentation.Signed-off-by: Mauro Carvalho Chehab
-
There are some structs/enums that aren't documented via
kernel-doc markup. Add documentation for them.Fix those warnings:
./include/media/rc-map.h:103: WARNING: c:type reference target not found: rc_map_list
./include/media/rc-map.h:110: WARNING: c:type reference target not found: rc_map_list
./include/media/rc-map.h:117: WARNING: c:type reference target not found: rc_mapSigned-off-by: Mauro Carvalho Chehab
-
There are some functions/macros used by the mediactl documentation
that are alien to the media subsystem. Ignore them.After this patch, the media core will only complain about this
static function:
Documentation/media/kapi/mc-core.rst:97: WARNING: c:func reference target not found: media_devnode_releaseSigned-off-by: Mauro Carvalho Chehab
-
There are several issues on the documentation:
- the media.h header were not properly referenced;
- verbatim expressions were not properly marked as such;
- struct member references were wrong;
- some notes were not using the right markup;
- a comment that were moved to the kernel-doc markup were
duplicated as a comment inside the struct media_entity;
- some args were not pointing to the struct they're using;
- macros weren't documented.Signed-off-by: Mauro Carvalho Chehab
-
The kernel-doc parser didn't handle well the private:
tag. Rewrite it.Signed-off-by: Mauro Carvalho Chehab