Eric Lee / smarc-fsl-linux-kernel

08 Mar, 2013

1 commit

  • e2e091fd9   Merge tag 'ecryptfs-3.9-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs ... Browse Code »

    Pull ecryptfs fixes from Tyler Hicks:
    "Minor code cleanups and new Kconfig option to disable /dev/ecryptfs

    The code cleanups fix up W=1 compiler warnings and some unnecessary
    checks. The new Kconfig option, defaulting to N, allows the rarely
    used eCryptfs kernel to userspace communication channel to be compiled
    out. This may be the first step in it being eventually removed."

    Hmm. I'm not sure whether these should be called "fixes", and it
    probably should have gone in the merge window. But I'll let it slide.

    * tag 'ecryptfs-3.9-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs:
    eCryptfs: allow userspace messaging to be disabled
    eCryptfs: Fix redundant error check on ecryptfs_find_daemon_by_euid()
    ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check
    eCryptfs: decrypt_pki_encrypted_session_key(): remove kfree() redundant null check
    eCryptfs: remove unneeded checks in virt_to_scatterlist()
    eCryptfs: Fix -Wmissing-prototypes warnings
    eCryptfs: Fix -Wunused-but-set-variable warnings
    eCryptfs: initialize payload_len in keystore.c

    Linus Torvalds
     

04 Mar, 2013

1 commit

  • 290502bee   eCryptfs: allow userspace messaging to be disabled ... Browse Code »

    When the userspace messaging (for the less common case of userspace key
    wrap/unwrap via ecryptfsd) is not needed, allow eCryptfs to build with
    it removed. This saves on kernel code size and reduces potential attack
    surface by removing the /dev/ecryptfs node.

    Signed-off-by: Kees Cook
    Signed-off-by: Tyler Hicks

    Kees Cook
     

12 Jan, 2013

1 commit

  • 336d6d032   fs/ecryptfs: remove depends on CONFIG_EXPERIMENTAL ... Browse Code »

    The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
    while now and is almost always enabled by default. As agreed during the
    Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

    CC: Tyler Hicks
    CC: Dustin Kirkland
    Signed-off-by: Kees Cook
    Acked-by: Tyler Hicks

    Kees Cook
     

10 Aug, 2011

1 commit

  • 4b6fee17b   eCryptfs: fix compile error ... Browse Code »

    This patch fixes the compile error reported at the address:

    https://bugzilla.kernel.org/show_bug.cgi?id=40292

    The problem arises when compiling eCryptfs as built-in and the 'encrypted'
    key type as a module. The patch prevents this combination from being set in
    the kernel configuration, by fixing the eCryptfs dependencies.

    Signed-off-by: Roberto Sassu
    Reported-by: David Hill
    Signed-off-by: Tyler Hicks

    Roberto Sassu
     

09 Oct, 2009

2 commits

23 Sep, 2009

1 commit

  • 382684984   ecryptfs: improved dependency checking and reporting ... Browse Code »

    So, I compiled a 2.6.31-rc5 kernel with ecryptfs and loaded its module.
    When it came time to mount my filesystem, I got this in dmesg, and it
    refused to mount:

    [93577.776637] Unable to allocate crypto cipher with name [aes]; rc = [-2]
    [93577.783280] Error attempting to initialize key TFM cipher with name = [aes]; rc = [-2]
    [93577.791183] Error attempting to initialize cipher with name = [aes] and key size = [32]; rc = [-2]
    [93577.800113] Error parsing options; rc = [-22]

    I figured from the error message that I'd either forgotten to load "aes"
    or that my key size was bogus. Neither one of those was the case. In
    fact, I was missing the CRYPTO_ECB config option and the 'ecb' module.
    Unfortunately, there's no trace of 'ecb' in that error message.

    I've done two things to fix this. First, I've modified ecryptfs's
    Kconfig entry to select CRYPTO_ECB and CRYPTO_CBC. I also took CRYPTO
    out of the dependencies since the 'select' will take care of it for us.

    I've also modified the error messages to print a string that should
    contain both 'ecb' and 'aes' in my error case. That will give any
    future users a chance of finding the right modules and Kconfig options.

    I also wonder if we should:

    select CRYPTO_AES if !EMBEDDED

    since I think most ecryptfs users are using AES like me.

    Cc: ecryptfs-devel@lists.launchpad.net
    Cc: linux-fsdevel@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Dustin Kirkland
    Signed-off-by: Dave Hansen
    [tyhicks@linux.vnet.ibm.com: Removed extra newline, 80-char violation]
    Signed-off-by: Tyler Hicks

    Dave Hansen
     

22 Jan, 2009

1 commit