02 Apr, 2020

1 commit

  • Obtained with:

    $ make W=1 net/mptcp/token.o
    net/mptcp/token.c:53: warning: Function parameter or member 'req' not described in 'mptcp_token_new_request'
    net/mptcp/token.c:98: warning: Function parameter or member 'sk' not described in 'mptcp_token_new_connect'
    net/mptcp/token.c:133: warning: Function parameter or member 'conn' not described in 'mptcp_token_new_accept'
    net/mptcp/token.c:178: warning: Function parameter or member 'token' not described in 'mptcp_token_destroy_request'
    net/mptcp/token.c:191: warning: Function parameter or member 'token' not described in 'mptcp_token_destroy'

    Fixes: 79c0949e9a09 (mptcp: Add key generation and token tree)
    Fixes: 58b09919626b (mptcp: create msk early)
    Signed-off-by: Matthieu Baerts
    Signed-off-by: Florian Westphal
    Signed-off-by: David S. Miller

    Matthieu Baerts
     

30 Mar, 2020

1 commit

  • Process the MP_JOIN option in a SYN packet with the same flow
    as MP_CAPABLE but when the third ACK is received add the
    subflow to the MPTCP socket subflow list instead of adding it to
    the TCP socket accept queue.

    The subflow is added at the end of the subflow list so it will not
    interfere with the existing subflows operation and no data is
    expected to be transmitted on it.

    Co-developed-by: Florian Westphal
    Signed-off-by: Florian Westphal
    Co-developed-by: Paolo Abeni
    Signed-off-by: Paolo Abeni
    Signed-off-by: Peter Krystad
    Signed-off-by: Mat Martineau
    Signed-off-by: David S. Miller

    Peter Krystad
     

15 Mar, 2020

1 commit

  • This change moves the mptcp socket allocation from mptcp_accept() to
    subflow_syn_recv_sock(), so that subflow->conn is now always set
    for the non fallback scenario.

    It allows cleaning up a bit mptcp_accept() reducing the additional
    locking and will allow fourther cleanup in the next patch.

    Signed-off-by: Paolo Abeni
    Reviewed-by: Matthieu Baerts
    Signed-off-by: David S. Miller

    Paolo Abeni
     

24 Jan, 2020

1 commit

  • Generate the local keys, IDSN, and token when creating a new socket.
    Introduce the token tree to track all tokens in use using a radix tree
    with the MPTCP token itself as the index.

    Override the rebuild_header callback in inet_connection_sock_af_ops for
    creating the local key on a new outgoing connection.

    Override the init_req callback of tcp_request_sock_ops for creating the
    local key on a new incoming connection.

    Will be used to obtain the MPTCP parent socket to handle incoming joins.

    Co-developed-by: Davide Caratti
    Signed-off-by: Davide Caratti
    Co-developed-by: Florian Westphal
    Signed-off-by: Florian Westphal
    Co-developed-by: Paolo Abeni
    Signed-off-by: Paolo Abeni
    Signed-off-by: Peter Krystad
    Signed-off-by: Christoph Paasch
    Signed-off-by: David S. Miller

    Peter Krystad