18 Jan, 2020

1 commit

  • commit f7e36e18946b4ec756b9c5cf4fb8891be8d1e4a3 upstream.

    In a rare randconfig build I came across one configuration that does
    not enable CONFIG_GPIOLIB, which is needed by lochnagar:

    ERROR: "devm_gpiochip_add_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined!
    ERROR: "gpiochip_generic_free" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined!
    ERROR: "gpiochip_generic_request" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined!
    ERROR: "gpiochip_get_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined!

    Add another 'select' like all other pinctrl drivers have.

    Fixes: 0548448b719a ("pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar")
    Signed-off-by: Arnd Bergmann
    Link: https://lore.kernel.org/r/20191218163701.171914-1-arnd@arndb.de
    Acked-by: Charles Keepax
    Signed-off-by: Linus Walleij
    Signed-off-by: Greg Kroah-Hartman

    Arnd Bergmann
     

05 Aug, 2019

3 commits


14 Jul, 2019

1 commit

  • Pull pin control updates from Linus Walleij:
    "This is the bulk of pin control changes for the v5.3 kernel cycle:

    Core changes:

    - Device links can optionally be added between a pin control producer
    and its consumers. This will affect how the system power management
    is handled: a pin controller will not suspend before all of its
    consumers have been suspended.

    This was necessary for the ST Microelectronics STMFX expander and
    need to be tested on other systems as well: it makes sense to make
    this default in the long run.

    Right now it is opt-in per driver.

    - Drive strength can be specified in microamps. With decreases in
    silicon technology, milliamps isn't granular enough, let's make it
    possible to select drive strengths in microamps.

    Right now the Meson (AMlogic) driver needs this.

    New drivers:

    - New subdriver for the Tegra 194 SoC.

    - New subdriver for the Qualcomm SDM845.

    - New subdriver for the Qualcomm SM8150.

    - New subdriver for the Freescale i.MX8MN (Freescale is now a product
    line of NXP).

    - New subdriver for Marvell MV98DX1135.

    Driver improvements:

    - The Bitmain BM1880 driver now supports pin config in addition to
    muxing.

    - The Qualcomm drivers can now reserve some GPIOs as taken aside and
    not usable for users. This is used in ACPI systems to take out some
    GPIO lines used by the BIOS so that noone else (neither kernel nor
    userspace) will play with them by mistake and crash the machine.

    - A slew of refurbishing around the Aspeed drivers (board management
    controllers for servers) in preparation for the new Aspeed AST2600
    SoC.

    - A slew of improvements over the SH PFC drivers as usual.

    - Misc cleanups and fixes"

    * tag 'pinctrl-v5.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl: (106 commits)
    pinctrl: aspeed: Strip moved macros and structs from private header
    pinctrl: aspeed: Fix missed include
    pinctrl: baytrail: Use GENMASK() consistently
    pinctrl: baytrail: Re-use data structures from pinctrl-intel.h
    pinctrl: baytrail: Use defined macro instead of magic in byt_get_gpio_mux()
    pinctrl: qcom: Add SM8150 pinctrl driver
    dt-bindings: pinctrl: qcom: Add SM8150 pinctrl binding
    dt-bindings: pinctrl: qcom: Document missing gpio nodes
    pinctrl: aspeed: Add implementation-related documentation
    pinctrl: aspeed: Split out pinmux from general pinctrl
    pinctrl: aspeed: Clarify comment about strapping W1C
    pinctrl: aspeed: Correct comment that is no longer true
    MAINTAINERS: Add entry for ASPEED pinctrl drivers
    dt-bindings: pinctrl: aspeed: Convert AST2500 bindings to json-schema
    dt-bindings: pinctrl: aspeed: Convert AST2400 bindings to json-schema
    dt-bindings: pinctrl: aspeed: Split bindings document in two
    pinctrl: qcom: Add irq_enable callback for msm gpio
    pinctrl: madera: Fixup SPDX headers
    pinctrl: qcom: sdm845: Fix CONFIG preprocessor guard
    pinctrl: tegra: Add bitmask support for parked bits
    ...

    Linus Torvalds
     

26 Jun, 2019

1 commit

  • GPL-2.0-only is the preferred way of expressing v2 of the GPL, so switch
    to that. Remove some redundant copyright notices and correct some
    instances where the wrong comment type has been used in header files.

    Signed-off-by: Charles Keepax
    Signed-off-by: Linus Walleij

    Charles Keepax
     

21 May, 2019

1 commit


04 Apr, 2019

1 commit

  • Lochnagar is an evaluation and development board for Cirrus
    Logic Smart CODEC and Amp devices. It allows the connection of
    most Cirrus Logic devices on mini-cards, as well as allowing
    connection of various application processor systems to provide a
    full evaluation platform. This driver supports the board
    controller chip on the Lochnagar board.

    Lochnagar provides many pins which can generally be used for an
    audio function such as an AIF or a PDM interface, but also as
    GPIOs.

    Signed-off-by: Charles Keepax
    Reviewed-by: Linus Walleij
    Signed-off-by: Linus Walleij

    Charles Keepax
     

28 Jan, 2019

1 commit

  • The change adds explicit inclusion of linux/pinctrl/machine.h header
    to the only needed pinctrl-madera-core.c file, and therefore inclusion
    of pinctrl/machine.h header from pinctrl/pinconf.h can be removed.

    The change is preparatory to a follow-up reversal of commit f07512e615dd
    ("pinctrl/pinconfig: add debug interface").

    Signed-off-by: Vladimir Zapolskiy
    Cc: Charles Keepax
    Reviewed-by Richard Fitzgerald
    Signed-off-by: Linus Walleij

    Vladimir Zapolskiy
     

12 Oct, 2018

1 commit

  • There is a potential execution path in which variable *ret* is checked
    in an IF statement, and then its value is used to report an error at
    line 659 without being properly initialized previously:

    659 if (ret)
    660 dev_err(priv->dev, "Failed to write to 0x%x (%d)\n", reg, ret);

    Fix this by initializing variable *ret* to 0 in order to
    avoid unpredictable or unintended results.

    Addresses-Coverity-ID: 1471969 ("Uninitialized scalar variable")
    Fixes: 218d72a77b0b ("pinctrl: madera: Add driver for Cirrus Logic Madera codecs")
    Signed-off-by: Gustavo A. R. Silva
    Acked-by: Charles Keepax
    Signed-off-by: Linus Walleij

    Gustavo A. R. Silva
     

01 Oct, 2018

1 commit


29 Aug, 2018

4 commits


05 Jun, 2018

1 commit

  • These codecs have a variable number of I/O lines each of which
    is individually selectable to a wide range of possible functions.

    The functionality is slightly different from the traditional muxed
    GPIO since most of the functions can be mapped to any pin (and even
    the same function to multiple pins). Most pins have a dedicated
    "alternate" function that is only available on that pin. The
    alternate functions are usually a group of signals, though it is
    not always necessary to enable the full group, depending on the
    alternate function and how it is to be used. The mapping between
    alternate functions and GPIO pins varies between codecs depending
    on the number of alternate functions and available pins.

    Signed-off-by: Richard Fitzgerald
    Reviewed-by: Linus Walleij
    Signed-off-by: Lee Jones

    Richard Fitzgerald