06 May, 2019
1 commit
-
Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patchesCc: Support Opensource
Signed-off-by: Guenter Roeck
Acked-by: Steve Twiss
Signed-off-by: Wim Van Sebroeck
24 Mar, 2018
1 commit
-
- Add SPDX identifier
- Remove boiler plate license text
- If MODULE_LICENSE and boiler plate does not match, go for boiler plate
licenseSigned-off-by: Marcus Folkesson
Acked-by: Adam Thomson
Acked-by: Baruch Siach
Acked-by: Charles Keepax
Acked-by: Keiji Hayashibara
Acked-by: Johannes Thumshirn
Acked-by: Florian Fainelli
Acked-by: Mans Rullgard
Acked-by: Matthias Brugger
Acked-by: Michal Simek
Acked-by: Neil Armstrong
Acked-by: Nicolas Ferre
Acked-by: Thierry Reding
Acked-by: Tomas Winkler
Acked-by: Patrice Chotard
Acked-by: William Breathitt Gray
Reviewed-by: Eric Anholt
Reviewed-by: Guenter Roeck
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
25 Feb, 2017
2 commits
-
Use device managed functions to simplify error handling, reduce
source code size, improve readability, and reduce the likelyhood of bugs.The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts used
to generate this commit log are available at
https://github.com/groeck/coccinelle-patches- Replace 'goto l; ... l: return e;' with 'return e;'
- Drop assignments to otherwise unused variables
- Drop remove function
- Drop platform_set_drvdata()
- Use devm_watchdog_register_driver() to register watchdog deviceAcked-by: Adam Thomson
Signed-off-by: Guenter Roeck -
Declare watchdog_info structures as const as they are only stored in the
info field of watchdog_device structures. This field is of type const
struct watchdog_info *, so watchdog_info structures having this property
can be declared const too.
Done using Coccinelle:@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_info i@p={...};@ok@
identifier r1.i;
position p;
struct watchdog_device obj;
@@
obj.info=&i@p;@bad@
position p!={r1.p,ok.p};
identifier r1.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct watchdog_info i;Signed-off-by: Bhumika Goyal
Acked-by: Florian Fainelli
Acked-by: Baruch Siach
Reviewed-by: Guenter Roeck
Acked-by: Adam Thomson
Signed-off-by: Guenter Roeck
30 Dec, 2015
1 commit
-
Reference counting is now implemented in the watchdog core and no longer
required in watchdog drivers.Since it was implememented a no-op, and since the local memory is allocated
with devm_kzalloc(), the reference counting code in the driver really did
not really work anyway, and this patch effectively fixes a bug which could
cause a crash on unloading if the watchdog device was still open.Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
10 Sep, 2015
1 commit
-
/sys/class/watchdog/watchdogn/device/modalias can help to identify the
driver/module for a given watchdog node. However, many wdt devices do not
set their parent and so, we do not see an entry for device in sysfs for
such devices.This patch fixes parent of watchdog_device so that
/sys/class/watchdog/watchdogn/device is populated.Exceptions: booke, diag288, octeon, softdog and w83627hf -- They do not
have any parent. Not sure, how we can identify driver for these devices.Signed-off-by: Pratyush Anand
Reviewed-by: Johannes Thumshirn
Acked-by: Guenter Roeck
Acked-by: H Hartley Sweeten
Acked-by: Lee Jones
Acked-by: Lubomir Rintel
Acked-by: Maxime Coquelin
Acked-by: Thierry Reding
Acked-by: Viresh Kumar
Acked-by: Linus Walleij
Signed-off-by: Wim Van Sebroeck
31 Mar, 2014
1 commit
-
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().Signed-off-by: Jingoo Han
Reviewed-by: Jean Delvare [for at32ap700x]
Acked-by: Lubomir Rintel [for bcm2835]
Acked-by: Viresh Kumar [for sp805_wdt]
Acked-by: Mika Westerberg [for ts72xx_wdt]
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
12 Jul, 2013
1 commit
-
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.Signed-off-by: Jingoo Han
Reviewed-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
02 Jan, 2013
2 commits
-
Otherwise, WDIOC_GETTIMEOUT returns wrong value if set_timeout fails.
This patch also removes unnecessary ret variable in da9055_wdt_ping function.Signed-off-by: Axel Lin
Signed-off-by: Wim Van Sebroeck -
It is not required to free devm_ allocated data. Since kref_put
needs a valid release function, da9055_wdt_release_resources()
is not deleted.Signed-off-by: Axel Lin
Signed-off-by: Wim Van Sebroeck
20 Dec, 2012
1 commit
-
This is the Watchdog patch for the DA9055 PMIC. This patch has got dependency on
the DA9055 MFD core.This patch is functionally tested on SMDK6410
Signed-off-by: David Dajun Chen
Signed-off-by: Ashish Jangam
Signed-off-by: Wim Van Sebroeck