20 Aug, 2017

1 commit

• aa7d01fd7   media: v4l2-pci-skeleton: constify vb2_ops structures ... Browse Code »

  These vb2_ops structures are only stored in the ops field of a
  vb2_queue structure, which is declared as const. Thus the vb2_ops
  structures themselves can be const.

  Done with the help of Coccinelle.

  //
  @r disable optional_qualifier@
  identifier i;
  position p;
  @@
  static struct vb2_ops i@p = { ... };

  @ok@
  identifier r.i;
  struct vb2_queue e;
  position p;
  @@
  e.ops = &i@p;

  @bad@
  position p != {r.p,ok.p};
  identifier r.i;
  struct vb2_ops e;
  @@
  e@i@p

  @depends on !bad disable optional_qualifier@
  identifier r.i;
  @@
  static
  +const
  struct vb2_ops i = { ... };
  //

  Signed-off-by: Julia Lawall
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Julia Lawall

  2017-08-20 20:03:09 +0800  

09 Jul, 2016

2 commits

• 36c0f8b32   [media] vb2: replace void *alloc_ctxs by struct device *alloc_devs ... Browse Code »

  Make this a proper typed array. Drop the old allocate context code since
  that is no longer used.

  Note that the memops functions now get a struct device pointer instead of
  the struct device ** that was there initially (actually a void pointer to
  a struct containing only a struct device pointer).

  This code is now a lot cleaner.

  Signed-off-by: Hans Verkuil
  Reviewed-by: Laurent Pinchart
  Cc: Sakari Ailus
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2016-07-09 01:45:07 +0800  
• 8f10c2db7   [media] v4l2-pci-skeleton: set q->dev instead of allocating a context ... Browse Code »

  Stop using alloc_ctx as that is now no longer needed.

  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2016-07-09 01:34:57 +0800  

10 May, 2016

1 commit

• 0185f8501   [media] samples: v4l: from Documentation to samples directory ... Browse Code »

  With the new autoksyms support, we can run into a situation where
  the v4l pci skeleton module is the only one using some exported
  symbols that get dropped because they are never referenced by
  the kernel otherwise, causing a build problem:

  ERROR: "vb2_dma_contig_memops" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "vb2_dma_contig_init_ctx_attrs" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_match_dv_timings" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_find_dv_timings_cap" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_valid_dv_timings" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "v4l2_enum_dv_timings_cap" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
  ERROR: "vb2_dma_contig_cleanup_ctx" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!

  Specifically, we do look in the samples directory for users of
  symbols, but not the Documentation directory.

  This solves the build problem by moving the connector sample into
  the same directory as the other samples.

  Fixes: 23121ca2b56b ("kbuild: create/adjust generated/autoksyms.h")

  Signed-off-by: Arnd Bergmann

  Arnd Bergmann

  2016-05-10 05:34:37 +0800