11 Oct, 2006
40 commits
-
Do correct mapping of pause and duplex when using 1000BaseX fiber
versions of the board.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The PHY interrupt from the internal fiber is getting
stuck on when the link is down. Add code to handle the
transition and mask it.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Bugfix: rx descriptor release function fails to visit
the last entry while walking receive descriptor ring.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
The ring buffer descriptors are DMA-accessed bidirectionally,
but are not declared in this way. Fix this.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Cosmetic patch: give the variable holding the numer of descriptors
a more descriptive name, so to avoid confusion.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
The current code attempts to start the TX dma every time a packet
is queued. This is too conservative, and wastes CPU time. This
patch changes behaviour to call the kick-dma function less often,
only when the tx queue is at risk of emptying.This reduces cpu usage, improves performance.
Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Remove a dummy register read that is not needed.
This reduces CPU usage notably during transmit.Signed-off-by: Linas Vepstas
Cc: Arnd Bergmann
Cc: James K Lewis
Signed-off-by: Jeff Garzik -
The transmit side of the spider ethernet driver currently
places locks around some very large chunks of code. This
results in a fair amount of lock contention is some cases.
This patch makes the locks much more fine-grained, protecting
only the cirtical sections. One lock is used to protect
three locations: the queue head and tail pointers, and the
queue low-watermark location.Signed-off-by: Linas Vepstas
Cc: Arnd Bergmann
Cc: James K Lewis
Signed-off-by: Jeff Garzik -
This patch moves transmit queue cleanup code out of the
interrupt context, and into the NAPI polling routine.Signed-off-by: Linas Vepstas
Acked-by: Arnd Bergmann
Cc: James K Lewis
Signed-off-by: Jeff Garzik -
Implement basic low-watermark support for the transmit queue.
Hardware low-watermarks allow a properly configured kernel
to continously stream data to a device and not have to handle
any interrupts at all in doing so. Correct zero-interrupt
operation can be actually observed for this driver, when the
socket buffer is made large enough.The basic idea of a low-watermark interrupt is as follows.
The device driver queues up a bunch of packets for the hardware
to transmit, and then kicks the hardware to get it started.
As the hardware drains the queue of pending, untransmitted
packets, the device driver will want to know when the queue
is almost empty, so that it can queue some more packets.If the queue drains down to the low waterark, then an interrupt
will be generated. However, if the kernel/driver continues
to add enough packets to keep the queue partially filled,
no interrupt will actually be generated, and the hardware
can continue streaming packets indefinitely in this mode.The impelmentation is done by setting the DESCR_TXDESFLG flag
in one of the packets. When the hardware sees this flag, it will
interrupt the device driver. Because this flag is on a fixed
packet, rather than at fixed location in the queue, the
code below needs to move the flag as more packets are
queued up. This implementation attempts to keep the flag
at about 1/4 from "empty".Signed-off-by: Linas Vepstas
Signed-off-by: James K Lewis
Acked-by: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Bugfix -- the rx chain is in memory after the tx chain --
the offset being used was wrong, resulting in memory corruption
when the size of the rx and tx rings weren't exactly the same.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Turn off mis-interpretation of the queue-empty interrupt
status bit as an error.Signed-off-by: Linas Vepstas
Signed-off-by: James K Lewis
Acked-by: Arnd Bergmann
Signed-off-by: Jeff Garzik -
The print message associated with the descriptor chain end interrupt
prints a bogs value. Fix that.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
The current receive interrupt mask sets a bogus bit that doesn't even
belong to the definition of this register. Remove it.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
This patch adds a call to netif_stop_queue() when there is
no more room for more packets on the transmit queue.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
This patch fixes the names of a few fields in the DMA control
register. There is no functional change.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Set the netdev watchdog timer.
Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Polite device drivers pad short packets to 60 bytes,
so that mean-spirited users don't accidentally DOS
some other OS that can't handle short packets.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
Bugfix: when cleaning up the transmit queue upon device close,
be sure to walk the entire queue.Signed-off-by: Linas Vepstas
Cc: James K Lewis
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
The module param permsissions should bw read-only, not writable.
From: James K Lewis
Signed-off-by: James K Lewis
Signed-off-by: Linas Vepstas
Cc: Arnd Bergmann
Signed-off-by: Jeff Garzik -
This patch increases the Burst Address alignment from 64 to 1024 in the
Spidernet driver. This improves transmit performance for large packets.From: James K Lewis
Signed-off-by: James K Lewis
Signed-off-by: Linas Vepstas
Acked-by: Arnd Bergmann
Signed-off-by: Jeff Garzik -
This patch adds version information as reported by
ethtool -i to the Spidernet driver.From: James K Lewis
Signed-off-by: James K Lewis
Signed-off-by: Linas Vepstas
Acked-by: Arnd Bergmann
Signed-off-by: Jeff Garzik -
This patch includes a bug fix for the port state notification
and fixes the default queue sizes.Signed-off-by: Jan-Bernd Themann
Signed-off-by: Jeff Garzik -
This eHEA patch covers required changes related to Anton Blanchard's new hvcall interface.
Signed-off-by: Jan-Bernd Themann
Signed-off-by: Jeff Garzik -
drivers/net/ibmveth.c:939: error: too many arguments to function `ibmveth_interrupt'
Cc: Jeff Garzik
Cc: Anton Blanchard
Cc: Paul Mackerras
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
This fixes eeprom read on big-endian architectures.
readw returns the data in CPU order. With cpu_to_le16 we convert it to little
endian, because "ptr" is a pointer to a _byte_ arrray. See the cast above. A
byte array is little endian.The bug is:
Reading u16 values with readw, casting them into an u8 array and accessing
this u8 array as an u8 (byte) array. The correct fix is to swap the
CPU-ordering value returned by readw into little endian, as the u8 array is
little endian.This compiles to nothing on little endian hardware (so it does not change b44
code on LE hardware), but _fixes_ code on BE hardware.Signed-off-by: Michael Buesch
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
generic IRQ layer will complain thusly:No IRQF_TRIGGER set_type function for IRQ 25 ()
Signed-off-by: Deepak Saxena
Cc: Jeff Garzik
Cc: Russell King
Cc: Nicolas Pitre
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
This is needed by at least the Mac Mini's, which (incorrectly) come back
from suspend with SCI_EN clear.Thanks to Frédéric Riss for hunting this down.
Acked-by: Frédéric Riss
Cc: Pavel Machek
Cc: Len Brown
Cc: Arjan van de Ven
Signed-off-by: Linus Torvalds -
The error path path mistakenly called sysfs_create_group() rather than
sysfs_remove_group(). They take the same arguments, so it's easy to
cut-n-paste such a bug.Signed-off-by: Jeff Garzik
Signed-off-by: Linus Torvalds -
- fix: toshoboe_invalid_dev() was recently removed, but not all callers
were updated, causing the obvious linker error. Remove caller,
because the check (like the one removed) isn't used.- fix: propagate request_irq() return value
- cleanup: remove void* casts
- cleanup: remove impossible ASSERTs
Signed-off-by: Jeff Garzik
Signed-off-by: Linus Torvalds -
* 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc:
[POWERPC] Fix windfarm platform device usage
[POWERPC] Fix i2c-powermac platform device usage
[POWERPC] Fix secondary CPU startup on old "powersurge" SMP powermacs
[POWERPC] ARCH=ppc pt_regs fixes
[POWERPC] Update maple defconfig
[POWERPC] Fix Maple secondary IDE interrupt
[POWERPC] Make U4 PCIe work on maple
[POWERPC] cell: fix default zImage build target
[POWERPC] Fix boot wrapper invocation if CROSS_COMPILE contains spaces
[POWERPC] Fix xmon IRQ handler for pt_regs removal -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds -
Signed-off-by: Alexey Dobriyan
Signed-off-by: Al Viro
Acked-by: David S. Miller
Signed-off-by: Linus Torvalds -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds -
Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds