06 Aug, 2019
1 commit
-
When system suspend, pcie bus write BRCMF_H2D_HOST_D3_INFORM cmd
into tcm32 mem to let host enter D3 mode, and wait the D3 ACK
interrupt. But sometime, the interrupt is comming lately then
cause wait event timeout, so double check the D3 ACK state.Signed-off-by: Fugang Duan
Acked-by: Richard Zhu
02 Jul, 2019
1 commit
-
Enable imx8mn platform to get mac address from efuse.
Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan
01 Jul, 2019
1 commit
-
Fix CAN coverty issue.
Signed-off-by: Joakim Zhang
Acked-by: Fugang Duan
20 May, 2019
1 commit
-
brcmfamc driver attach mmc func devices only when func1 device's
node exist, and whose compatible string match "brcm,bcm4329-fmac".Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan
30 Apr, 2019
6 commits
-
When running wlan interface up/down stress test in background then run
reboot command, there have kernel panic as below message.
This issue is fixed by doing cleanup in shutdown handler.Unable to handle kernel paging request at virtual address 7f0e9040
pgd = 86c20000
[7f0e9040] *pgd=86ecd811, *pte=00000000, *ppte=00000000
Internal error: Oops: 7 [#1] PREEMPT SMP ARM
task: 8603c000 task.stack: 86040000
PC is at device_shutdown+0x198/0x204
LR is at _raw_spin_unlock_irq+0x28/0x54
pc : [] lr : [] psr: 20030013
sp : 86041e60 ip : 00000000 fp : 80c5b7e4
r10: 80cb0b24 r9 : 80f7e020 r8 : 86b0b844
r7 : 80fdce84 r6 : 86b0b810 r5 : 80f34ef0 r4 : 86b0b81c
r3 : 7f0e9018 r2 : ffffffff r1 : 00000002 r0 : 00000000
Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
Control: 10c53c7d Table: 86c2006a DAC: 00000051
Process systemd-shutdow (pid: 1, stack limit = 0x86040210)
Stack: (0x86041e60 to 0x86042000)
1e60: 00000000 00000000 80f0f704 aef99500 fee1dead 80107c44 86040000 00000000
1e80: 7eee5fd4 8014bb74 00000000 8014bdcc 00000000 00000000 00000000 8020464c
1ea0: 87336540 00000000 00000000 00000000 861b24e0 87336548 00000024 00000002
1ec0: 00000000 00000005 0000001e 80205c34 00000000 00000000 1c4a66cc 87336540
1ee0: 00000000 86041f08 86041f80 00000000 00000000 80205d5c 86041f04 86041f08
1f00: 00000000 00000000 00000001 00000000 00000024 86041f20 00000005 7eee521c
1f20: 7eee5350 00000004 7eee5f1c 00000010 7eee5364 00000005 7eee53f4 0000000a
1f40: 76ece6fc 00000001 86005b00 00000005 fffffffe fffffffe 86d1a000 fffff000
1f60: 80107c44 87336540 87336540 00000000 7eee5318 80205df0 00000000 00000004
1f80: 00000000 00000000 00000000 7eee53f4 7eee5318 00000000 00000000 00000000
1fa0: 00000058 80107a60 00000000 00000000 fee1dead 28121969 01234567 aef99500
1fc0: 00000000 00000000 00000000 00000058 00000000 ffffffff 00000000 7eee5fd4
1fe0: 004a0e18 7eee5c44 0048afa4 76d0b5e0 60030010 fee1dead 00000000 00000000
[] (device_shutdown) from [] (kernel_restart+0xc/0x50)
[] (kernel_restart) from [] (SyS_reboot+0xc8/0x1ac)
[] (SyS_reboot) from [] (ret_fast_syscall+0x0/0x54)
Code: eaffffb5 e5943040 e3530000 0afffff3 (e5933028)
---[ end trace cb8c3d96d6f26a91 ]---Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
Not all firmware set channel/ulp_sdioctrl, so change the error message
to debug level for reading chanspec/ulp_sdioctrl iovar data.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
If reboot command is issued when PCIe WLAN device is in connected
state, system kernel dump while booting as below log. This issue
is fixed by doing cleanup and disable PCIe interrupt in shutdown handler.[ 6.405135] irq 304: nobody cared (try booting with the "irqpoll" option)
[ 6.425581] Call trace:
[ 6.428034] [] dump_backtrace+0x0/0x3c8
[ 6.433433] [] show_stack+0x14/0x20
[ 6.438485] [] dump_stack+0x9c/0xbc
[ 6.443538] [] __report_bad_irq+0x34/0xf0
[ 6.449110] [] note_interrupt+0x2ec/0x338
[ 6.454682] [] handle_irq_event_percpu+0x44/0x58
[ 6.460861] [] handle_irq_event+0x48/0x78
[ 6.466433] [] handle_fasteoi_irq+0xa8/0x180
[ 6.472265] [] generic_handle_irq+0x24/0x38
[ 6.478009] [] __handle_domain_irq+0x5c/0xb8
[ 6.483841] [] gic_handle_irq+0x78/0x174
[ 6.489325] Exception stack(0xffff0000094f3d80 to 0xffff0000094f3ec0)
[ 6.495765] 3d80: 0000000000000000 ffff000009502580 0000000000000709 ffff000008ac5b28
[ 6.503593] 3da0: 0000000002222221 00ffffffffffffff 0000000008cd6205 00000000000000c0
[ 6.511421] 3dc0: 00000032b5503510 ffff000008082000 0000000000001000 0000000000000000
[ 6.519249] 3de0: 0000000034d5d91d 00008000b4a78000 ffff000009502580 0000000000000000
[ 6.527077] 3e00: 0000000000000000 0000000000000000 0000000000000000 000000016cb15db1
[ 6.534905] 3e20: 0000000000000001 ffff8000b900ce00 ffff8000b925e000 0000000000000001
[ 6.542733] 3e40: 000000016c9c1569 ffff8000b925e000 ffff000009502580 0000000000000400
[ 6.550561] 3e60: 00000000417b0018 ffff0000094f3ec0 ffff000008a308a8 ffff0000094f3ec0
[ 6.558389] 3e80: ffff000008a307f4 0000000040000045 ffff8000b925e060 0000000000000001
[ 6.566217] 3ea0: ffffffffffffffff ffff8000b925e000 ffff0000094f3ec0 ffff000008a307f4
[ 6.574045] [] el1_irq+0xb0/0x124
[ 6.578925] [] cpuidle_enter_state+0x134/0x228
[ 6.584930] [] cpuidle_enter+0x18/0x20
[ 6.590242] [] call_cpuidle+0x1c/0x40
[ 6.595465] [] do_idle+0x1a4/0x1e0
[ 6.600428] [] cpu_startup_entry+0x24/0x28
[ 6.606088] [] rest_init+0xd0/0xe0
[ 6.611056] [] start_kernel+0x398/0x3acReviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
There is a limitation about wakeup event mechanisim in driver:
Other devices may suspend failed after system calling flexcan_suspend()
and before calling flexcan_noirq_suspend(), the result is that
flexcan_noirq_resume() will not be called. This will leave flexcan in
stop mode, and with the current driver it can't recover from this even
with a soft reboot, it requires a hard reboot.This patch is intends to fix the scenario.
Reviewed-by: Fugang Duan
Signed-off-by: Joakim Zhang -
Fd mode related bit in register will keep asserted when setting "fd off"
in userspace after once setting "fd on" before. Clear fd related bit
when "fd off" is more reasonble. Also clean the cbt and fdcbt register
bit before setting.Acked-by: Fugang Duan
Signed-off-by: Joakim Zhang -
We allocate skb according to "fd on" or "fd off" before, this may not
reasonable. Such as, transfer normal frame when fd mode is on. Allcoating
skb based on "EDL" bit from mailbox ctrl field is more reasonable.Signed-off-by: Joakim Zhang
29 Apr, 2019
2 commits
-
Only set wowlan parameters when the interface's BRCMF_FEAT_WOWL
flag is set.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
Move the func->num check early in .brcmf_ops_sdio_suspend() to
save suspend time.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan
19 Apr, 2019
3 commits
-
Current brcmfmac driver cannot load cyw4339 module and always report
bus timeout as below log.brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4339-sdio for chip BCM4339/2
brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4339-sdio for chip BCM4339/2
brcmfmac: brcmf_c_process_clm_blob: no clm_blob available (err=-11), device may have limited channels available
brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
brcmfmac: brcmf_bus_started: failed: -110
brcmfmac: brcmf_attach: dongle is not responding: err=-110
brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
brcmfmac: brcmf_bus_started: failed: -110
brcmfmac: brcmf_attach: dongle is not responding: err=-110
brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
brcmfmac: brcmf_c_preinit_dcmds: Retreiving version information failed, -110
brcmfmac: brcmf_bus_started: failed: -110
Unable to handle kernel NULL pointer dereference at virtual address 00000004
pgd = 50d469b0
[00000004] *pgd=00000000
Internal error: Oops: 817 [#1] PREEMPT SMP ARM
Modules linked in: mxc_vadc mxc_dcic mx6s_capture ov5640_camera_v2 brcmfmac brcmutil
CPU: 0 PID: 91 Comm: kworker/0:3 Not tainted 4.19.35-04384-g50ca4a9 #1147
Hardware name: Freescale i.MX6 SoloX (Device Tree)
Workqueue: events request_firmware_work_func
PC is at brcmf_attach+0x234/0x3d8 [brcmfmac]
LR is at __slab_free+0x1a4/0x308
pc : [] lr : [] psr: 20010013
sp : a8679e78 ip : a8679de8 fp : 00000000
r10: 00000000 r9 : a8ef0c00 r8 : a9ffa1a0
r7 : a868b808 r6 : a9ff8460 r5 : ffffff92 r4 : a9ff81a0
r3 : 00000000 r2 : 588fd8f8 r1 : 00000000 r0 : 00000000
Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
Control: 10c53c7d Table: a901c04a DAC: 00000051
Process kworker/0:3 (pid: 91, stack limit = 0xbe6d797a)
Stack: (0xa8679e78 to 0xa867a000)
9e60: 7f03540c 00000000
9e80: a97cecc0 00000008 00000001 a8ecf800 81004d08 a8ecfc00 a868b808 7f0328b8
9ea0: 00000002 00000008 00000001 7f02adfc 00000840 00010000 00000840 bc3ef180
9ec0: a92abcc0 00000000 00000000 588fd8f8 ab731d80 a92ab454 a8398340 00000014
9ee0: 81004d08 00000000 a92ab440 a9461140 ab731d80 7f023620 a9eec980 588fd8f8
9f00: a9461480 81004d08 ab731d80 ab734f00 00000000 a9461484 00000000 8054c058
9f20: 00000000 00000003 a9461140 588fd8f8 ab731d80 a9461480 a865a280 80146690
9f40: 81003d00 ab731d98 a865a280 a865a294 ab731d80 81003d00 ab731d98 a8678000
9f60: 00000008 8014697c 00000000 a8643e00 a8643dc0 00000000 a865a280 80146950
9f80: a8643e1c a8075ebc 00000000 8014bfc8 a8643dc0 8014bea4 00000000 00000000
9fa0: 00000000 00000000 00000000 801010e8 00000000 00000000 00000000 00000000
9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000
[] (brcmf_attach [brcmfmac]) from [] (brcmf_sdio_firmware_callback+0x4c4/0x74c [brcmfmac])
[] (brcmf_sdio_firmware_callback [brcmfmac]) from [] (brcmf_fw_request_done+0x188/0x214 [brcmfmac])
[] (brcmf_fw_request_done [brcmfmac]) from [] (request_firmware_work_func+0x4c/0x88)
[] (request_firmware_work_func) from [] (process_one_work+0x138/0x3f8)
[] (process_one_work) from [] (worker_thread+0x2c/0x554)
[] (worker_thread) from [] (kthread+0x124/0x154)
[] (kthread) from [] (ret_from_fork+0x14/0x2c)
Exception stack(0xa8679fb0 to 0xa8679ff8)
9fa0: 00000000 00000000 00000000 00000000
9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
9fe0: 00000000 00000000 00000000 00000000 00000013 00000000
Code: e3530000 0a000011 e59432cc e3a00000 (e5839004)
---[ end trace 8b8e3996f6f715bf ]---cyw4339 doesn't support ulp_sdioctrl iovar and ulp mode, the current logic make
sdio bus down/up, and trigger firmware load twice. So remove the ulp status
check for cyw4339.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
Upstream rejected ARCH_MXC_ARM64 in favor of defining ARCH_MXC for
arm64.Update the CAN driver to check for CONFIG_HAVE_IMX_SC around
SCFW-dependent code.Signed-off-by: Joakim Zhang
-
CAN driver will keep ISOFD state after setting "fd on" or "fd on
fd-non-iso off", you can't switch to NONISOFD mode, this patch intends
to add branch for "fd-non-iso on".Signed-off-by: Joakim Zhang
18 Apr, 2019
25 commits
-
Now the FlexCAN driver always use last mailbox for TX, it will work well when
MB payload size is 8/16 bytes. TX mailbox would change to 13 when MB payload
size is 64 bytes to support CANFD. So we may need to set iflag register to add
support for variable payload size.Signed-off-by: Joakim Zhang
-
Add callback for mailbox read/write function and clean up the code.
Signed-off-by: Joakim Zhang
-
We need to add property in DTS node before when we want to use normal
mode on i.MX8 platform. Check in RM, we also can use CBT register not
must CTRL1 register to set bitrate for normal mode.This patch intends to use CBT register to set bitrate for normal mode on
i.MX8. After this, we don't need to modify the DTS node to support
normal mode.Signed-off-by: Joakim Zhang
-
ISO CAN FD is introduced to increase the failture detection capability
than non-ISO CAN FD. The non-ISO CAN FD is still supported by FlexCAN so
that it can be used mainly during an intermediate phase, for evaluation
and development purposes.Therefore, it is strongly recommended to configure FlexCAN to the ISO
CAN FD protocol by setting the ISOCANFDEN field in the CTRL2 register.Test Command:
ISO FD MODE:
ip link set can0 type can bitrate 1000000 dbitrate 4000000 fd on
fd-non-iso offnon-ISO FD MODE:
ip link set can0 type can bitrate 1000000 dbitrate 4000000 fd on
fd-non-iso onNOTE: if you only set fd on, driver will use ISO FD MODE by default.
Signed-off-by: Joakim Zhang
-
When dev->power.can_wakeup set to true, device_prepare() may runtime resume the device:
dpm_suspend_start()
dpm_prepare(state);
dev->driver->pm->prepare()
pm_genpd_prepare()
if (resume_needed(dev, genpd))
pm_runtime_resume(dev);And imx8qm/qxp power domain driver don't implement the active_wakeup() callback, then
resume_needed() always return "true" when dev->power.can_wakeup is true.Once CAN device is runtime active status, then CAN's clock's count is 1 during system
suspend. And CAN0/CAN1/CAN2 share the same module clock, so we can say all CAN's module
clock is enabled during system suspended.flexcan_runtime_resume()
flexcan_clks_enable(priv);i.MX8QM/QXP SCU code clock logic requires linux kernel clocks should be disabled during
suspend, otherwise SCU don't enable them after system resume back.There are two ways to fix the issue:
1. CAN driver should check the runtime status to ensure all clocks are disabled during
system suspend.
2. Don't set CAN wakeup capability during probe, move it into flexcan_open().Signed-off-by: Fugang Duan
Signed-off-by: Joakim Zhang -
This patch is to add CAN wakeup function on MX8 platforms and update the
binding file fsl-flexcan.txt.For MX8, the function "flexcan_irq()" should not call "flexcan_exit_stop_mode()"
due to firmware(SCU) cannot make SC IPC calls from an interrupt context.
If not exit stop mode in ISR, it will continuously enter wakeup ISR for the reason
that system will respond IRQ before call CAN system resume.
To fix the issue, we can exit stop mode during noirq resume stage.For wakeup case, it should not set pinctrl to sleep state by
pinctrl_pm_select_sleep_state.Signed-off-by: Joakim Zhang
-
Add support flexcan on imx8 platforms, mailbox as default
Signed-off-by: Joakim Zhang
-
Modify Kconfig file to enable flexcan support for arm64
Signed-off-by: Joakim Zhang
-
Moving the brcmf_bus_preinit() call allows the bus code to do some
required initialization before handling firmware control messages..brcmf_bus_preinit() already is called in .brcmf_bus_started() when
bus is ready. So remove it from .brcmf_c_preinit_dcmds().Fixes: 383c26d2ea2f(MLK-18675-20 brcmfmac: Support wake on ping packet)
Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
func0 is not provided by the mmc stack as a function when probing.
commit 99d7b6fdfc8c(brcmfmac: Remove func0 from function array)
already remove the func0.But commit c37fa19e0128(brcmfmac: Remove array of functions) add
fun0 again. That cause NULL pointer issue.Fixes: c37fa19e0128(brcmfmac: Remove array of functions)
Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
commit 861cb5eb467f ("brcmfmac: Fix access point mode") upstream.
Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
hostapd (device_ap_sme=1 use_monitor=0):brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
So add the missing mgmt_stypes for AP mode to fix this.
Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
Suggested-by: Arend van Spriel
Signed-off-by: Stefan Wahren
Acked-by: Arend van Spriel
Signed-off-by: Kalle Valo -
This patch fixes 43455 CRC error while running throughput test with
suspend/resume stress test.The continuous failure messages before system crash:
brcmfmac: brcmf_sdiod_sglist_rw: CMD53 sg block read failed -84
brcmfmac: brcmf_sdio_rxglom: glom read of 25600 bytes failed: -5
brcmfmac: brcmf_sdio_rxfail: abort command, terminate frame
brcmfmac: brcmf_sdiod_sglist_rw: CMD53 sg block read failed -84
brcmfmac: brcmf_sdio_rxglom: glom read of 24576 bytes failed: -5
brcmfmac: brcmf_sdio_rxfail: abort command, terminate frameSigned-off-by: Wright Feng
Signed-off-by: Fugang Duan
(cherry picked from commit d6e37c2eb0f6fc2b50172321a464337073038228) -
With asynchronous suspend/resume feature, suspend and resume callbacks to
be executed in parallel with each other. It makes bus changes the state to
BRCMF_BUS_DOWN before all brcmf_cfg80211_suspend IOVAR executions.
The same situation also happens in resume procedure and causes PM mode
keeps in PM_MAX after resume. In order to fix the race condition, We add
one second sleep in bus suspend and cfg80211 resume function.Signed-off-by: Wright Feng
Signed-off-by: Fugang Duan
(cherry picked from commit fdb676ce002039d7359b200b6c2cc728f41c05fa) -
We got ifp null pointer kernel panic in brcmf_txfinalize after removing
Wi-Fi USB dongle when data was transmitting, The root cause is that
interface was removed before calling brcmf_txfinalize in
brcmf_fws_dequeue_worker and finally caused kernel panic.Signed-off-by: Wright Feng
Signed-off-by: Fugang Duan
(cherry picked from commit 3f94bfe6febc9762e340a69b6520242f27d20c85) -
To trunkcate the addtional bytes, if extra bytes are received.
Current code only have a warning and proceed without handling it.
But in one crash dump reported by DVT, these causes the
crash intermittently. So the processing is limit to the skb->len.Signed-off-by: Raveendran Somu
Signed-off-by: Fugang Duan
(cherry picked from commit f7112c027e0c7447b05474b72934589bbbb8e298) -
Add brcmfmac platform device pinctrl state support. That is useful
for dynamically configurate pin group for different wlan chips.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan
(cherry picked from commit 88f2834cd5b8cb8864af68d265b5bdee3000c4bf) -
- The current timeout value is not enough for MB transaction read
when modem enter D3 mode, so increase the timeout value to match
the D3 mode timing requirement.
- Add 10 ms delay for pcie device to exit D3 state and enter D0 state.
- Remove the duplicated code for SBMBX register access.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan
(cherry picked from commit 05601af462145e27142e3d140e10a66d4a493d40) -
There are two D11 cores in RSDB chips like 4359. We have to reset two
D11 cores simutaneously before firmware download, or the firmware may
not be initialized correctly and cause "fw initialized failed" error.Reviewed-by: Richard Zhu
Signed-off-by: Wright Feng
Signed-off-by: Fugang Duan
(cherry picked commit from 8f50bea9357af3088dba0103f0017d56763b0ae9) -
Not all chips support wowlan, then get wowlan wakeup event failed.
Change the log into debug level.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan
(cherry picked from commit 47b205952ca6be6216e19a121f1fb400c5fcf7e7) -
Remove duplicate mailbox register entry from hardware register structure.
Signed-off-by: Arulpandiyan Vadivel
(cherry picked from commit 0fb8da2c4060fa5c43cb9fd2fef6aee58a0d9235) -
uboot fdt_fixup_ethernet() already add the "local-mac-address" property
for each net node when boot from net, the mac address read from fuse in
default. But for non-net boot or net is disabled in uboot, then kernel
also needs to read the MAC address from fuse. The patch add i.MX8MM platform
to read fuse from MAC in kernel in such case.Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
i.MX8QXP has different fuse address with i.MX8QM, correct i.MX8QXP
MAC fuse word address.Signed-off-by: Fugang Duan
-
commit ae136b3cfe7c(MLK-18483-04 net: fec: close the mu ipc channel
when it is not used) merge part of code from commit 379ede4dfd95
(MLK-18483-02 net: fec: add sleep mode support for i.MX8QM/QXP),
but miss the commit.So add the feature support for i.MX8QM/QXP by merge the commit 379ede4dfd95
(MLK-18483-02 net: fec: add sleep mode support for i.MX8QM/QXP)Reviewed-by: Richard Zhu
Signed-off-by: Fugang Duan -
Upstream rejected ARCH_MXC_ARM64 in favor of defining ARCH_MXC for
arm64.Update the FEC driver to check for CONFIG_HAVE_IMX_SC around
SCFW-dependent code.Fixes: 800ae684d992 ("MLK-16022 net: fec: get mac address from fuse")
Signed-off-by: Leonard Crestez -
This was incorrectly added to the fec_devtype array only by commit
088c766a5c04 ("MLK-10724-6 net: fec: add i.mx6ul enet support")The rest of 8qm support was later added by commit d1a46676c8b8
("MLK-16781 net: fec: add eee mode tx lpi support")Signed-off-by: Leonard Crestez
