Eric Lee / smarc-fsl-linux-kernel

15 Oct, 2020

1 commit

  • b989451b8   docs: libata.rst: fix a wrong usage of :c:type: tag ... Browse Code »

    The usage of :c:type: to reference to a struct member is wrong,
    as pointed by Sphinx 3:

    ./Documentation/driver-api/libata.rst:511: WARNING: Unparseable C cross-reference: 'qc->complete_fn'
    Invalid C declaration: Expected end of definition. [error at 2]
    qc->complete_fn
    --^

    Instead, let's use :c:expr: for such purpose.

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     

12 Mar, 2020

1 commit

01 Nov, 2019

2 commits

  • 95364f367   ata: make qc_prep return ata_completion_errors ... Browse Code »

    In case a driver wants to return an error from qc_prep, return enum
    ata_completion_errors. sata_mv is one of those drivers -- see the next
    patch. Other drivers return the newly defined AC_ERR_OK.

    [v2] use enum ata_completion_errors and AC_ERR_OK.

    Signed-off-by: Jiri Slaby
    Cc: Jens Axboe
    Cc: linux-ide@vger.kernel.org
    Signed-off-by: Jens Axboe

    Jiri Slaby
     
  • 0fb596eda   ata: Documentation, fix function names ... Browse Code »

    ata_qc_prep no longer exists, there are ata_bmdma_qc_prep and
    ata_bmdma_dumb_qc_prep instead. And most drivers do not use them, so
    reword the paragraph.

    ata_qc_issue_prot was renamed to ata_sff_qc_issue. ->tf_load is now
    ->sff_tf_load. Fix them.

    And fix spelling supercede -> supersede.

    Signed-off-by: Jiri Slaby
    Cc: Jens Axboe
    Cc: linux-ide@vger.kernel.org
    Signed-off-by: Jens Axboe

    Jiri Slaby
     

12 Jul, 2018

1 commit

  • 23ebda2fc   libata: remove ata_sff_data_xfer_noirq() ... Browse Code »

    ata_sff_data_xfer_noirq() is invoked via the ->sff_data_xfer hook. The
    latter is invoked by ata_pio_sector(), atapi_send_cdb() and
    __atapi_pio_bytes() which in turn is invoked by ata_sff_hsm_move().
    The latter function requires that the "ap->lock" lock is held which
    needs to be taken with disabled interrupts.

    There is no need have to have ata_sff_data_xfer_noirq() which invokes
    ata_sff_data_xfer32() with disabled interrupts because at this point the
    interrupts are already disabled.
    Remove the function and its references to it and replace all callers
    with ata_sff_data_xfer32().

    Signed-off-by: Sebastian Andrzej Siewior
    Signed-off-by: Tejun Heo

    Sebastian Andrzej Siewior
     

16 May, 2017

2 commits