09 Sep, 2007
1 commit
-
Fix an off-by-one error in the I/O region declaration of two
hardware monitoring drivers (lm78 and w83781d.) We were requesting
one extra port at the end of the region.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
13 Aug, 2007
3 commits
-
The smsc47m1 driver no longer creates the name attribute used by
libsensors to identify chip types. It was lost during the conversion
to a platform driver. I was fooled by the fact that we do have a
group with all attributes, but only to delete them all at once. The
group is not used to create the attributes, so we have to explicitly
create the name attribute.This fixes lm-sensors ticket #2236:
http://lm-sensors.org/ticket/2236Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Don't assume that the default bank is 0. For one thing, we don't even
set it to 0 when the driver is loaded, so the initial state might be
different. For another, something (say, the BIOS) might access the chip
and leave with the bank set to something different, so assuming that
the bank value is 0 is not safe.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch forces the driver to read the fan divider values during early init.
Otherwise, a call to store_fan_min() could access uninitialized variables.Signed-off-by: Mark M. Hoffman
Signed-off-by: Jean Delvare
12 Aug, 2007
1 commit
-
Commit 348753379a7704087603dad403603e825422fd9a introduced a regression that
caused temp2 and temp3 sensor type settings to be written to temp1 instead.
The result is that temp sensor readings could be way off.Signed-off-by: Mark M. Hoffman
31 Jul, 2007
11 commits
-
Here is a small fscher bugfix for 2.6.23 merging, lifted from my other fscher
work, as requested by Jean. The current driver has a control sysfs attribute,
which shows the contents of the control register, but the underlying
global_control value in the data structure currently never gets filled with
the actual contents of this register.Signed-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk
Acked-by: Hans de Goede
Signed-off-by: Mark M. Hoffman -
The commit http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=32c82a934759b2c9939c9e25865c2d7d1204b9e8
broke lm90 for my (Asus V6VA) laptop.Before 2.6.23-rc1 and with the following patch, I get:
[g ~]$ sensors
max6657-i2c-0-4c
Adapter: SMBus I801 adapter at 0400
M/B Temp: +64°C (low = +0°C, high = +127°C)
CPU Temp: +78.9°C (low = +73.2°C, high = +88.2°C)
M/B Crit: +105°C (hyst = +95°C)
CPU Crit: +105°C (hyst = +95°C)Which regressed into:
[g ~]$ sensors
No sensors found!
Make sure you loaded all the kernel drivers you need.
Try sensors-detect to find out which these are.
zsh: 2701 exit 1 sensorsand dmesg contains:
i2c-adapter i2c-0: Unsupported chip (man_id=0x4D, chip_id=0x4D).
It seems to be a typo, as address 0X4F is mentionned nowhere else in the file,
and my chip is actually at 0x4C.Signed-off-by: Guillaume Chazarain
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Signed-off-by: Nicolas Boichat
Acked-by: Jean Delvare
Cc: Martin Szulecki
Cc: Dmitry Torokhov
Signed-off-by: Andrew Morton
Signed-off-by: Mark M. Hoffman -
Here is another small fscher bugfix for 2.6.23 merging, this was caught by Jean
while reviewing my other bugfix. The driver was updating its copy of the
control register as if it was clear to write, but its regular read/write. This
patch fixes this.Signed-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Fix temp?_fault attribute. The temp was incorrectly compared against
0x0800 rather than 0x8000. Only the upper 8 bits are compared as the
datasheet doesn't specify what happens to the lower bits in case of a
diode fault.Signed-off-by: Juerg Haefliger
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
On Sun, 22 Jul 2007 00:30:56 +0200, Gabriel C wrote:
> I noticed this warnings on current git:
>
> drivers/hwmon/pc87360.c:1082: warning: 'pc87360_remove' defined but not used
> drivers/hwmon/sis5595.c:580: warning: 'sis5595_remove' defined but not used
> drivers/hwmon/smsc47m1.c:608: warning: 'smsc47m1_remove' defined but not used
> drivers/hwmon/via686a.c:648: warning: 'via686a_remove' defined but not used
> drivers/hwmon/vt8231.c:755: warning: 'vt8231_remove' defined but not usedSigned-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch cleans up duplicate includes in
drivers/hwmon/Signed-off-by: Jesper Juhl
Signed-off-by: Mark M. Hoffman -
Here is a small but important bugfix to the lm78 driver. I found out about this
problem because a Fedora user filed a bug that the lm78 driver no longer worked
on his system: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249428The problem is that sometime ago the isa lm78 detection was made more stringent
and this new code now checks the chip-id, but does not accept a chip-id of 20h,
however a chip-id of 20h is valid, and is excepted in the main probe function
of the driver, see line 551. This fixed also makes the isa detection code
accept the chip-id of 0x20 fixing this issue.Signed-off-by: Hans de Goede
Signed-off-by: Mark M. Hoffman -
This fixes an array overflow bug. We have 4 pairs of min/max temperature
limits, not 3.Signed-off-by: Hans J. Koch
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch adds support for THMC50 and ADM1022 hardware monitoring chips.
Signed-off-by: Krzysztof Helt
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
20 Jul, 2007
24 commits
-
* 'release' of git://lm-sensors.org/kernel/mhoffman/hwmon-2.6: (44 commits)
i2c: Delete the i2c-isa pseudo bus driver
hwmon: refuse to load abituguru driver on non-Abit boards
hwmon: fix Abit Uguru3 driver detection on some motherboards
hwmon/w83627ehf: Be quiet when no chip is found
hwmon/w83627ehf: No need to initialize fan_min
hwmon/w83627ehf: Export the thermal sensor types
hwmon/w83627ehf: Enable VBAT monitoring
hwmon/w83627ehf: Add support for the VID inputs
hwmon/w83627ehf: Fix timing issues
hwmon/w83627ehf: Add error messages for two error cases
hwmon/w83627ehf: Convert to a platform driver
hwmon/w83627ehf: Update the Kconfig entry
make coretemp_device_remove() static
hwmon: Add LM93 support
hwmon: Improve the pwmN_enable documentation
hwmon/smsc47b397: Don't report missing fans as spinning at 82 RPM
hwmon: Add support for newer uGuru's
hwmon/f71805f: Add temperature-tracking fan control mode
hwmon/w83627ehf: Preserve speed reading when changing fan min
hwmon: fix detection of abituguru volt inputs
...Manual fixup of trivial conflict in MAINTAINERS file
-
With this patch the abituguru refuses to load on non Abit motherboards, as
discussed in lkml CONFIG_BREAK_MY_MACHINE thread.Signed-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch changes the driver to also detect uguru3's which hold 0x08 at DATA
initially, as has been reported here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220160Also when an uguru3's holds 0x0014 in the ID register it will now report
"Abit AB9 Pro" as motherboard identification.Signed-off-by: Hans de Goede
Signed-off-by: Mark M. Hoffman -
This fixes bug #8593:
http://bugzilla.kernel.org/show_bug.cgi?id=8593Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
We don't need to initialize fan_min in this driver, as the fan_div
attributes are read-only.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Add support for the w83627ehf thermal sensor types. I made them read-only,
as the BIOS is supposed to set them up properly. This information makes it
easier to find out which temperature channel corresponds to the CPU.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
If VBAT monitoring is disabled, enable it. Original patch from
an anonymous contributor on the lm-sensors trac system:
http://lm-sensors.org/ticket/2218Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
The W83627EHF and similar chips have 6 VID input pins, add support
for them. The driver changes the input voltage level automatically
if the current setting is not correct for the detected CPU model.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
* I have experimental evidence that the W83627EHG needs more than 1
second to refresh all the measured values. Increase the caching time to
1.5 second.
* When changing a fan clock divider, the corresponding fan speed
measurement register is no longer valid, until the next time the chip
will refresh it. One way to fix this is to pretend that the cache is
still valid for one more period (1.5 second.)Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
If the Super-I/O device is disabled, it is likely the BIOS has a good
reason for leaving it disabled, so give a warning when enabling it --
it's not likely to be wired correctly or be able to give good data.Also, if the Super-I/O device is configured with an address of 0, the
driver refuses to initialize it.Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Remove i2c-isa from the w83627ehf driver, and use a platform driver
instead.Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Add description for the W83627DHG chip to Kconfig.
Signed-off-by: David Hubbard
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
coretemp_device_remove() can become static.
Signed-off-by: Adrian Bunk
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch adds support for the LM93 hardware monitoring chip.
Signed-off-by: Hans J. Koch
Signed-off-by: Mark M. Hoffman -
Also protects ourselves against a possible division by zero.
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch adds a new driver for the hardware monitoring features of the
third revision of the Abit uGuru chip, found on recent Abit
motherboards. This is an entirely different beast then the first and
second revision (its again a winbond microcontroller, but the "protocol"
to talk to it and the bank addresses are very different.Signed-off-by: Hans de Goede
Signed-off-by: Mark M. Hoffman -
Add support for the "temperature mode" fan speed control. In this mode,
the user can define 3 temperature/speed trip points, and the chip will
set the speed automatically according to the temperature changes.Signed-off-by: Phil Endecott
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
The w83627ehf driver changes the fan clock divider automatically when
a new min fan speed is set. It is supposed to preserve the fan speed
reading while doing so, bug doesn't really. Fix it.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
This patch fixes the detection of volt inputs with a reading of more then 240
units.Signed-off-by: Hans de Goede
Signed-off-by: Mark M. Hoffman -
This patch adds the SMSC SCH5317 chip (device ID 0x85) as a supported
device to the smsc47b397 driver.Signed-off-by: Juerg Haefliger
Signed-off-by: Mark M. Hoffman -
This is the patch for converting it87 to a platform driver (and remove i2c-isa).
Signed-off-by: Corentin LABBE
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Fix a potential race condition when some hardware monitoring platform
drivers are being unloaded. I believe that the driver data pointer
shouldn't be cleared before all the sysfs files are removed, otherwise
a sysfs callback might attempt to dereference a NULL pointer. I'm not
sure exactly what the driver core protects drivers against, so let's
play it safe.While we're here, clear the driver data pointer when probe fails, so
as to not leave an invalid pointer behind us.Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Convert the vt8231 driver from the nonsensical i2c-isa hack to a
regular platform driver.Signed-off-by: Roger Lucas
Signed-off-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Use PCI_REVISION_ID instead of our own define.
Signed-off-by: Jean Delvare
