Eric Lee / smarc-fsl-linux-kernel

08 Nov, 2019

1 commit

21 May, 2019

1 commit

  • 09c434b8a   treewide: Add SPDX license identifier for more missed files ... Browse Code »

    Add SPDX license identifiers to all files which:

    - Have no license information of any form

    - Have MODULE_LICENCE("GPL*") inside which was used in the initial
    scan/conversion to ignore the file

    These files fall under the project license, GPL v2 only. The resulting SPDX
    license identifier is:

    GPL-2.0-only

    Signed-off-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

14 Sep, 2018

1 commit

27 Jun, 2017

1 commit

08 Jun, 2017

1 commit

  • cf124db56   net: Fix inconsistent teardown and release of private netdev state. ... Browse Code »

    Network devices can allocate reasources and private memory using
    netdev_ops->ndo_init(). However, the release of these resources
    can occur in one of two different places.

    Either netdev_ops->ndo_uninit() or netdev->destructor().

    The decision of which operation frees the resources depends upon
    whether it is necessary for all netdev refs to be released before it
    is safe to perform the freeing.

    netdev_ops->ndo_uninit() presumably can occur right after the
    NETDEV_UNREGISTER notifier completes and the unicast and multicast
    address lists are flushed.

    netdev->destructor(), on the other hand, does not run until the
    netdev references all go away.

    Further complicating the situation is that netdev->destructor()
    almost universally does also a free_netdev().

    This creates a problem for the logic in register_netdevice().
    Because all callers of register_netdevice() manage the freeing
    of the netdev, and invoke free_netdev(dev) if register_netdevice()
    fails.

    If netdev_ops->ndo_init() succeeds, but something else fails inside
    of register_netdevice(), it does call ndo_ops->ndo_uninit(). But
    it is not able to invoke netdev->destructor().

    This is because netdev->destructor() will do a free_netdev() and
    then the caller of register_netdevice() will do the same.

    However, this means that the resources that would normally be released
    by netdev->destructor() will not be.

    Over the years drivers have added local hacks to deal with this, by
    invoking their destructor parts by hand when register_netdevice()
    fails.

    Many drivers do not try to deal with this, and instead we have leaks.

    Let's close this hole by formalizing the distinction between what
    private things need to be freed up by netdev->destructor() and whether
    the driver needs unregister_netdevice() to perform the free_netdev().

    netdev->priv_destructor() performs all actions to free up the private
    resources that used to be freed by netdev->destructor(), except for
    free_netdev().

    netdev->needs_free_netdev is a boolean that indicates whether
    free_netdev() should be done at the end of unregister_netdevice().

    Now, register_netdevice() can sanely release all resources after
    ndo_ops->ndo_init() succeeds, by invoking both ndo_ops->ndo_uninit()
    and netdev->priv_destructor().

    And at the end of unregister_netdevice(), we invoke
    netdev->priv_destructor() and optionally call free_netdev().

    Signed-off-by: David S. Miller

    David S. Miller
     

09 Jan, 2017

1 commit

  • bc1f44709   net: make ndo_get_stats64 a void function ... Browse Code »

    The network device operation for reading statistics is only called
    in one place, and it ignores the return value. Having a structure
    return value is potentially confusing because some future driver could
    incorrectly assume that the return value was used.

    Fix all drivers with ndo_get_stats64 to have a void function.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     

08 Dec, 2016

1 commit

19 Aug, 2015

1 commit

29 Mar, 2014

1 commit

  • b7d47ca2f   net: nlmon: flag nlmon devs with LLTX/SG ... Browse Code »

    As in xmit path we merely update statistics and free the skb, we
    can mark the device with LLTX feature, so that upper layers can
    avoid taking the single txq lock on xmit. While at it, also add
    missing NETIF_F_SG.

    Signed-off-by: Daniel Borkmann
    Acked-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Daniel Borkmann
     

15 Mar, 2014

1 commit

  • 57a7744e0   net: Replace u64_stats_fetch_begin_bh to u64_stats_fetch_begin_irq ... Browse Code »

    Replace the bh safe variant with the hard irq safe variant.

    We need a hard irq safe variant to deal with netpoll transmitting
    packets from hard irq context, and we need it in most if not all of
    the places using the bh safe variant.

    Except on 32bit uni-processor the code is exactly the same so don't
    bother with a bh variant, just have a hard irq safe variant that
    everyone can use.

    Signed-off-by: "Eric W. Biederman"
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

15 Feb, 2014

1 commit

06 Nov, 2013

1 commit

  • 827da44c6   net: Explicitly initialize u64_stats_sync structures for lockdep ... Browse Code »

    In order to enable lockdep on seqcount/seqlock structures, we
    must explicitly initialize any locks.

    The u64_stats_sync structure, uses a seqcount, and thus we need
    to introduce a u64_stats_init() function and use it to initialize
    the structure.

    This unfortunately adds a lot of fairly trivial initialization code
    to a number of drivers. But the benefit of ensuring correctness makes
    this worth while.

    Because these changes are required for lockdep to be enabled, and the
    changes are quite trivial, I've not yet split this patch out into 30-some
    separate patches, as I figured it would be better to get the various
    maintainers thoughts on how to best merge this change along with
    the seqcount lockdep enablement.

    Feedback would be appreciated!

    Signed-off-by: John Stultz
    Acked-by: Julian Anastasov
    Signed-off-by: Peter Zijlstra
    Cc: Alexey Kuznetsov
    Cc: "David S. Miller"
    Cc: Eric Dumazet
    Cc: Hideaki YOSHIFUJI
    Cc: James Morris
    Cc: Jesse Gross
    Cc: Mathieu Desnoyers
    Cc: "Michael S. Tsirkin"
    Cc: Mirko Lindner
    Cc: Patrick McHardy
    Cc: Roger Luethi
    Cc: Rusty Russell
    Cc: Simon Horman
    Cc: Stephen Hemminger
    Cc: Steven Rostedt
    Cc: Thomas Petazzoni
    Cc: Wensong Zhang
    Cc: netdev@vger.kernel.org
    Link: http://lkml.kernel.org/r/1381186321-4906-2-git-send-email-john.stultz@linaro.org
    Signed-off-by: Ingo Molnar

    John Stultz
     

03 Jul, 2013

1 commit

29 Jun, 2013

1 commit

  • 3b233fe04   nlmon: fix comparison in nlmon_is_valid_mtu ... Browse Code »

    This patch fixes the following warning introduced in e4fc408e0e99
    ("packet: nlmon: virtual netlink monitoring device for packet
    sockets") reported by Dan Carpenter:

    warning: "drivers/net/nlmon.c:31 nlmon_is_valid_mtu()
    warn: always true condition '(new_mtu > 1))) =>
    (s32min-s32max
    Signed-off-by: Daniel Borkmann
    Signed-off-by: David S. Miller

    Daniel Borkmann
     

25 Jun, 2013

1 commit

  • e4fc408e0   packet: nlmon: virtual netlink monitoring device for packet sockets ... Browse Code »

    Currently, there is no good possibility to debug netlink traffic that
    is being exchanged between kernel and user space. Therefore, this patch
    implements a netlink virtual device, so that netlink messages will be
    made visible to PF_PACKET sockets. Once there was an approach with a
    similar idea [1], but it got forgotten somehow.

    I think it makes most sense to accept the "overhead" of an extra netlink
    net device over implementing the same functionality from PF_PACKET
    sockets once again into netlink sockets. We have BPF filters that can
    already be easily applied which even have netlink extensions, we have
    RX_RING zero-copy between kernel- and user space that can be reused,
    and much more features. So instead of re-implementing all of this, we
    simply pass the skb to a given PF_PACKET socket for further analysis.

    Another nice benefit that comes from that is that no code needs to be
    changed in user space packet analyzers (maybe adding a dissector, but
    not more), thus out of the box, we can already capture pcap files of
    netlink traffic to debug/troubleshoot netlink problems.

    Also thanks goes to Thomas Graf, Flavio Leitner, Jesper Dangaard Brouer.

    [1] http://marc.info/?l=linux-netdev&m=113813401516110

    Signed-off-by: Daniel Borkmann
    Signed-off-by: David S. Miller

    Daniel Borkmann