01 May, 2017

1 commit

• cddbfbd44   lib: remove check for AVR32 arch in test_user_copy ... Browse Code »

  The AVR32 architecture support has been removed from the Linux kernel,
  hence remove all the check for this architecture in test_user_copy.c.

  Signed-off-by: Hans-Christian Noren Egtvedt

  Hans-Christian Noren Egtvedt

  2017-05-01 15:36:30 +0800  

23 Feb, 2017

1 commit

• 4deaa6fd0   usercopy: ARM NOMMU has no 64-bit get_user ... Browse Code »

  On a NOMMU ARM kernel, we get this link error:

  ERROR: "__get_user_bad" [lib/test_user_copy.ko] undefined!

  The problem is that the extended get_user/put_user definitions
  were only added for the normal (MMU based) case.

  We could add it for NOMMU as well, but it seems easier to just not
  call it, since no other code needs it.

  Fixes: 4c5d7bc63775 ("usercopy: Add tests for all get_user() sizes")
  Signed-off-by: Arnd Bergmann
  Signed-off-by: Kees Cook

  Arnd Bergmann

  2017-02-23 03:24:08 +0800  

22 Feb, 2017

1 commit

• 4c5d7bc63   usercopy: Add tests for all get_user() sizes ... Browse Code »

  The existing test was only exercising native unsigned long size
  get_user(). For completeness, we should check all sizes. But we
  must skip some 32-bit architectures that don't implement a 64-bit
  get_user().

  These new tests actually uncovered a bug in ARM's 64-bit get_user()
  zeroing.

  Signed-off-by: Kees Cook

  Kees Cook

  2017-02-22 03:59:38 +0800  

17 Feb, 2017

2 commits

• f5f893c57   usercopy: Adjust tests to deal with SMAP/PAN ... Browse Code »

  Under SMAP/PAN/etc, we cannot write directly to userspace memory, so
  this rearranges the test bytes to get written through copy_to_user().
  Additionally drops the bad copy_from_user() test that would trigger a
  memcpy() against userspace on failure.

  Signed-off-by: Kees Cook

  Kees Cook

  2017-02-17 08:34:59 +0800  
• 4fbfeb8bd   usercopy: add testcases to check zeroing on failure ... Browse Code »

  During usercopy the destination buffer will be zeroed if copy_from_user()
  or get_user() fails. This patch adds testcases for it. The destination
  buffer is set with non-zero value before illegal copy_from_user() or
  get_user() is executed and the buffer is compared to zero after usercopy
  is done.

  Signed-off-by: Hoeun Ryu
  [kees: clarified commit log, dropped second kmalloc]
  Signed-off-by: Kees Cook

  Hoeun Ryu

  2017-02-17 08:34:59 +0800  

24 Jan, 2014

1 commit

• 3e2a4c183   test: check copy_to/from_user boundary validation ... Browse Code »

  To help avoid an architecture failing to correctly check kernel/user
  boundaries when handling copy_to_user, copy_from_user, put_user, or
  get_user, perform some simple tests and fail to load if any of them
  behave unexpectedly.

  Specifically, this is to make sure there is a way to notice if things
  like what was fixed in commit 8404663f81d2 ("ARM: 7527/1: uaccess:
  explicitly check __user pointer when !CPU_USE_DOMAINS") ever regresses
  again, for any architecture.

  Additionally, adds new "user" selftest target, which loads this module.

  Signed-off-by: Kees Cook
  Cc: Rusty Russell
  Cc: Joe Perches
  Signed-off-by: Andrew Morton
  Signed-off-by: Linus Torvalds

  Kees Cook

  2014-01-24 08:36:57 +0800