02 Oct, 2016
1 commit
-
The cipher block size for GCM is 16 bytes, and thus the CTR transform
used in crypto_gcm_setkey() will also expect a 16-byte IV. However,
the code currently reserves only 8 bytes for the IV, causing
an out-of-bounds access in the CTR transform. This patch fixes
the issue by setting the size of the IV buffer to 16 bytes.Fixes: 84c911523020 ("[CRYPTO] gcm: Add support for async ciphers")
Signed-off-by: Ondrej Mosnacek
Signed-off-by: Herbert Xu
22 Sep, 2016
23 commits
-
Ensure scatterlists have a virtual memory mapping before dumping.
Signed-off-by: Catalin Vasile
Signed-off-by: Herbert Xu -
Currently omap-rng checks the return value of pm_runtime_get_sync and
reports failure if anything is returned, however it should be checking
if ret < 0 as pm_runtime_get_sync return 0 on success but also can return
1 if the device was already active which is not a failure case. Only
values < 0 are actual failures.Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed")
Signed-off-by: Dave Gerlach
Signed-off-by: Herbert Xu -
The current internal buffer size is way too large for crypto core, so
shrink it to be smaller. This makes the buffer to fit into the space
reserved for the export/import buffers also.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Now that the driver has been converted to use scatterlists for data
handling, add proper implementation for the export/import stubs also.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Currently, the internal buffer has been used for data transmission. Change
this so that scatterlists are used instead, and change the driver to
actually use the previously introduced helper functions for scatterlist
preparation.This patch also removes the old buffer handling code which is no longer
needed.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Currently the threshold value was hardcoded in the driver. Having a define
for it makes it easier to configure.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Currently omap-sham uses a huge internal buffer for caching data, and
pushing this out to the DMA as large chunks. This, unfortunately,
doesn't work too well with the export/import functionality required
for ahash algorithms, and must be changed towards more scatterlist
centric approach.This patch adds support functions for (mostly) scatterlist based data
handling. omap_sham_prepare_request() prepares a scatterlist for DMA
transfer to SHA crypto accelerator. This requires checking the data /
offset / length alignment of the data, splitting the data to SHA block
size granularity, and adding any remaining data back to the buffer.
With this patch, the code doesn't actually go live yet, the support code
will be taken properly into use with additional patches that modify the
SHA driver functionality itself.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
The current usage of sgl will be deprecated, and will be replaced by an
array required by the sg based driver implementation. Rename the existing
variable as sgl_tmp so that it can be removed from the driver easily later.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
OMAP HW generally expects data for DMA to be on word boundary, so make the
SHA driver inform crypto framework of the same preference.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Initially these just return -ENOTSUPP to indicate that they don't
really do anything yet. Some sort of implementation is required
for the driver to at least probe.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
We get 1 warning when building kernel with W=1:
drivers/crypto/sunxi-ss/sun4i-ss-hash.c:168:5: warning: no previous prototype for 'sun4i_hash' [-Wmissing-prototypes]In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.Signed-off-by: Baoyou Xie
Signed-off-by: Herbert Xu -
Fix the retrn value check which testing the wrong variable
in ccp_dmaengine_register().Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
Signed-off-by: Wei Yongjun
Acked-by: Gary R Hook
Signed-off-by: Herbert Xu -
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.Fixes: 6e9b5e76882c ("hwrng: geode - Migrate to managed API")
Signed-off-by: Wei Yongjun
Signed-off-by: Herbert Xu -
In case of error, the function devm_kzalloc() or devm_ioport_map()
return NULL pointer not ERR_PTR(). The IS_ERR() test in the return
value check should be replaced with NULL test.Fixes: 31b2a73c9c5f ("hwrng: amd - Migrate to managed API")
Signed-off-by: Wei Yongjun
Signed-off-by: Herbert Xu -
Move statements for error handling which were identical
in two if branches to the end of these functions.Signed-off-by: Markus Elfring
Signed-off-by: Herbert Xu -
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.Signed-off-by: Markus Elfring
Signed-off-by: Herbert Xu -
* Return a value at the end without storing it in an intermediate variable.
* Delete the local variable "ret" which became unnecessary with
this refactoring.Signed-off-by: Markus Elfring
Signed-off-by: Herbert Xu -
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
Signed-off-by: Herbert Xu -
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
Signed-off-by: Herbert Xu -
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.Signed-off-by: Markus Elfring
Signed-off-by: Herbert Xu -
Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset().
Signed-off-by: Wei Yongjun
Acked-by: Gary R Hook
Signed-off-by: Herbert Xu -
Fix to return error code -ENOMEM from the crypto_engine_alloc_init()
error handling case instead of 0, as done elsewhere in this function.Fixes: 0529900a01cb ("crypto: omap-aes - Support crypto engine framework")
Signed-off-by: Wei Yongjun
Signed-off-by: Herbert Xu -
Fix to return error code -ENOMEM from the crypto_engine_alloc_init()
error handling case instead of 0, as done elsewhere in this function.Fixes: f1b77aaca85a ("crypto: omap-des - Integrate with the crypto
engine framework")
Signed-off-by: Wei Yongjun
Signed-off-by: Herbert Xu
13 Sep, 2016
16 commits
-
Remove unneeded variables and assignments.
Signed-off-by: Masahiro Yamada
Signed-off-by: Herbert Xu -
Fix checkpatch.pl warning by changing from asm/io.h to linux/io.h. In
the mean time arrange the includes in alphabetical order.Signed-off-by: PrasannaKumar Muralidharan
Signed-off-by: Herbert Xu -
Use devm_ioremap and devm_hwrng_register instead of ioremap and
hwrng_register. This removes error handling code. Also moved code around
by removing goto statements. This improves code readability.Signed-off-by: PrasannaKumar Muralidharan
Signed-off-by: Herbert Xu -
Fix the missing clk_disable_unprepare() before return
from st_rng_probe() in the error handling case.Signed-off-by: Wei Yongjun
Acked-by: Patrice Chotard
Acked-by: Peter Griffin
Signed-off-by: Herbert Xu -
Managed API eliminates error handling code, thus reduces several lines
of code.Signed-off-by: PrasannaKumar Muralidharan
Signed-off-by: Herbert Xu -
In core rng_buffer and rng_fillbuf is allocated in hwrng_register only
once and it is freed during module exit. This patch moves allocating
rng_buffer and rng_fillbuf from hwrng_register to rng core's init. This
avoids checking whether rng_buffer and rng_fillbuf was allocated from
every hwrng_register call. Also moving them to module init makes it
explicit that it is freed in module exit.Change in v2:
Fix memory leak when register_miscdev fails.Signed-off-by: PrasannaKumar Muralidharan
Signed-off-by: Herbert Xu -
Fix a memory leak in an error path in uc loader.
Signed-off-by: Giovanni Cabiddu
Signed-off-by: Herbert Xu -
Checkpatch.pl warns about usage of asm/io.h. Use linux/io.h instead.
Signed-off-by: PrasannaKumar Muralidharan
Signed-off-by: Herbert Xu -
The crypto engine must be initialized before registering algorithms,
otherwise the test manager will crash as it attempts to execute
tests for the algos while they are being registered.Fixes: f1b77aaca85a ("crypto: omap-des - Integrate with the crypto engine framework")
Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
The crypto engine must be initialized before registering algorithms,
otherwise the test manager will crash as it attempts to execute
tests for the algos while they are being registered.Fixes: 0529900a01cb ("crypto: omap-aes - Support crypto engine framework")
Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
As setting up the DMA operations is quite costly, add software fallback
support for requests smaller than 200 bytes. This change gives some 10%
extra performance in ipsec use case.Signed-off-by: Lokesh Vutla
[t-kristo@ti.com: udpated against latest upstream, to use skcipher mainly]
Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Some SoCs like omap4/omap5/dra7 contain multiple AES crypto accelerator
cores. Adapt the driver to support this. The driver picks the last used
device from a list of AES devices.Signed-off-by: Lokesh Vutla
[t-kristo@ti.com: forward ported to 4.7 kernel]
Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Calling runtime PM API at the cra_init/exit is bad for power management
purposes, as the lifetime for a CRA can be very long. Instead, use
pm_runtime autosuspend approach for handling the device clocks. Clocks
are enabled when they are actually required, and autosuspend disables
these if they have not been used for a sufficiently long time period.
By default, the timeout value is 1 second.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
If software fallback is used on older hardware accelerator setup (OMAP2/
OMAP3), the first block of data must be purged from the buffer. The
first block contains the pre-generated ipad value required by the HW,
but the software fallback algorithm generates its own, causing wrong
results.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
If we have processed any data with the hardware accelerator (digcnt > 0),
we must complete the entire hash by using it. This is because the current
hash value can't be imported to the software fallback algorithm. Otherwise
we end up with wrong hash results.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu -
Some of the call paths of OMAP SHA driver can avoid executing the next
step of the crypto queue under tasklet; instead, execute the next step
directly via function call. This avoids a costly round-trip via the
scheduler giving a slight performance boost.Signed-off-by: Tero Kristo
Signed-off-by: Herbert Xu
