16 Aug, 2016
1 commit
-
These are the leftovers I could only track down using keep_warnings =
True. For some of them we might want to update our style guide on how
to reference structures and constants, not sure ...Cc: Markus Heiser
Cc: Jonathan Corbet
Cc: linux-doc@vger.kernel.org
Reviewed-by: Sean Paul
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1471034937-651-1-git-send-email-daniel.vetter@ffwll.ch
17 May, 2016
1 commit
-
drm_gem_object_lookup() has never required the drm_device for its file
local translation of the user handle to the GEM object. Let's remove the
unused parameter and save some space.Signed-off-by: Chris Wilson
Cc: dri-devel@lists.freedesktop.org
Cc: Dave Airlie
Cc: Daniel Vetter
[danvet: Fixup kerneldoc too.]
Signed-off-by: Daniel Vetter
04 May, 2016
1 commit
-
Finally all the core gem and a lot of drivers are entirely free of
dev->struct_mutex depencies, and we can start to have an entirely
lockless unref path.To make sure that no one who touches the core code accidentally breaks
existing drivers which still require dev->struct_mutex I've made the
might_lock check unconditional.While at it de-inline the ref/unref functions, they've become a bit
too big.v2: Make it not leak like a sieve.
v3: Review from Lucas:
- drop != NULL in pointer checks.
- fixup copypasted kerneldoc to actually match the functions.v4:
Add __drm_gem_object_unreference as a fastpath helper for drivers who
abolished dev->struct_mutex, requested by Chris.v5: Fix silly mistake in drm_gem_object_unreference_unlocked caught by
intel-gfx CI - I checked for gem_free_object instead of
gem_free_object_unlocked ...Cc: Chris Wilson
Cc: Alex Deucher
Cc: Lucas Stach
Reviewed-by: Lucas Stach (v3)
Reviewed-by: Chris Wilson (v4)
Reviewed-by: Alex Deucher
Signed-off-by: Daniel Vetter
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1462178451-1765-1-git-send-email-daniel.vetter@ffwll.ch
24 Nov, 2015
1 commit
-
I just realized that I've forgotten to update all the gem refcounting
docs. For pennance also add pretty docs for the overall drm_gem_object
structure, with a few links thrown in fore good.As usually we need to make sure the kerneldoc reference is at most a
sect2 for otherwise it won't be listed.Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1445533889-7661-1-git-send-email-daniel.vetter@ffwll.ch
Reviewed-by: Alex Deucher
Signed-off-by: Daniel Vetter
19 Oct, 2015
1 commit
-
Pretty soon only some drivers will need dev->struct_mutex in their
gem_free_object callbacks. Hence it's really important to make sure
everything still keeps getting this right.v2: Don't check for locking before we check for non-NULL obj. Spotted
by Dan Carpenter.Link: http://mid.gmane.org/1444894601-5200-10-git-send-email-daniel.vetter@ffwll.ch
Reviewed-by: David Herrmann
Signed-off-by: Daniel Vetter
08 Apr, 2015
1 commit
-
If kref_put_mutex returns true then the caller or the put function is responsible
for unlocking the mutex. The usual pattern assumes that the free
callback unlocks the mutex, but since that is shared with the locked
variant we need to explicitly unlock here.Signed-off-by: Maarten Lankhorst
Signed-off-by: Daniel Vetter
24 Dec, 2014
1 commit
-
This reverts commit 355a70183848f21198e9f6296bd646df3478a26d.
This had some bad side effects under normal operation, and should
have been dropped earlier.Signed-off-by: Dave Airlie
21 Nov, 2014
1 commit
-
It happens on occasion that developers of generic user-space applications
abuse the dumb buffer API to get hold of drm buffers that they can both
mmap() and use for GPU acceleration, using the assumptions that dumb buffers
and buffers available for GPU are
a) The same type and can be aribtrarily type-casted.
b) fully coherent.This patch makes the most widely used drivers warn nicely when that happens,
the next step will be to fail.v2: Move drmP.h changes to drm_gem.h. Fix Radeon dumb mmap breakage.
Signed-off-by: Thomas Hellstrom
Acked-by: Daniel Vetter
Acked-by: Alex Deucher
Signed-off-by: Dave Airlie
24 Sep, 2014
1 commit
-
v2: Don't forget git add, noticed by David.
Cc: David Herrmann
Signed-off-by: Daniel Vetter
Acked-by: David Herrmann
Acked-by: Alex Deucher
Signed-off-by: Dave Airlie