15 Sep, 2016
1 commit
-
Introduce a typedef gpio_blink_set_t to improve readability of the code.
Signed-off-by: Heiner Kallweit
Signed-off-by: Jacek Anaszewski
27 Jun, 2016
1 commit
-
Some systems use 'gpio_led_register_device' to make an in-memory copy of
their LED device table so the original can be removed as .init.rodata.
When the LED subsystem is not enabled source in the led directory is not
built and so this function may be undefined. Fix this here.Signed-off-by: Andrew F. Davis
Signed-off-by: Jacek Anaszewski
20 Jun, 2016
1 commit
-
This patch converts the IDE specific LED trigger to a generic disk
activity LED trigger. The libata core is now a trigger source just
like before the IDE disk driver. It's merely a replacement of the
string ide by disk.The patch is taken from http://dev.gentoo.org/~josejx/ata.patch and is
widely used by any ibook/powerbook owners with great satisfaction.
Likewise, it is very often used successfully on different ARM platforms.Unlike the original patch, the existing 'ide-disk' trigger is still
available for backward compatibility. That reduce the amount of patches
in affected device trees out of the mainline kernel. For further
development, the new name 'disk-activity' should be used.Cc: Joseph Jezak
Cc: Jörg Sommer
Cc: Richard Purdie
Signed-off-by: Stephan Linz
Signed-off-by: Jacek Anaszewski
08 Jun, 2016
1 commit
-
Commit 76931edd54f8 ("leds: fix brightness changing when software blinking
is active") changed the semantics of led_set_brightness() which according
to the documentation should disable blinking upon any brightness setting.
Moreover it made it different for soft blink case, where it was possible
to change blink brightness, and for hardware blink case, where setting
any brightness greater than 0 was ignored.While the change itself is against the documentation claims, it was driven
also by the fact that timer trigger remained active after turning blinking
off. Fixing that would have required major refactoring in the led-core,
led-class, and led-triggers because of cyclic dependencies.Finally, it has been decided that allowing for brightness change during
blinking is beneficial as it can be accomplished without disturbing
blink rhythm.The change in brightness setting semantics will not affect existing
LED class drivers that implement blink_set op thanks to the LED_BLINK_SW
flag introduced by this patch. The flag state will be from now on checked
in led_set_brightness() which will allow to distinguish between software
and hardware blink mode. In the latter case the control will be passed
directly to the drivers which apply their semantics on brightness set,
which is disable the blinking in case of most such drivers. New drivers
will apply new semantics and just change the brightness while hardware
blinking is on, if possible.The issue was smuggled by subsequent LED core improvements, which modified
the code that originally introduced the problem.Fixes: f1e80c07416a ("leds: core: Add two new LED_BLINK_ flags")
Signed-off-by: Tony Makkiel
Signed-off-by: Jacek Anaszewski
06 May, 2016
2 commits
-
Calling a GPIO LEDs is quite likely to work even if the kernel
has paniced, so they are ideal to blink in this situation.
This commit adds support for the new "panic-indicator"
firmware property, allowing to mark a given LED to blink on
a kernel panic.Signed-off-by: Ezequiel Garcia
Reviewed-by: Matthias Brugger
Acked-by: Pavel Machek
Signed-off-by: Jacek Anaszewski -
This commit adds a new led_cdev flag LED_PANIC_INDICATOR, which
allows to mark a specific LED to be switched to the "panic"
trigger, on a kernel panic.This is useful to allow the user to assign a regular trigger
to a given LED, and still blink that LED on a kernel panic.Signed-off-by: Ezequiel Garcia
Reviewed-by: Matthias Brugger
Acked-by: Pavel Machek
Signed-off-by: Jacek Anaszewski
13 Apr, 2016
1 commit
-
This commit introduces a MTD trigger for flash (NAND/NOR) device
activity. The implementation is copied from IDE disk.This trigger deprecates the "nand-disk" LED trigger, but for backwards
compatibility, we still keep the "nand-disk" trigger around.The motivation for deprecating the "nand-disk" LED trigger is that
it only works for NAND drivers, whereas the "mtd" LED trigger
is more generic (in fact, "nand-disk" currently only works for
certain NAND drivers).Signed-off-by: Ezequiel Garcia
Acked-by: Boris Brezillon
Signed-off-by: Jacek Anaszewski
14 Mar, 2016
2 commits
-
When a USB LED device is unplugged the remove call chain calls
led_classdev_unregister which tries to switch the LED off.
As the device has been removed already this results in a ENODEV
error message in dmesg.
Avoid this error message by ignoring ENODEV in calls from
led_classdev_unregister if the LED device is flagged as pluggable.Therefore a new flag LED_HW_PLUGGABLE was introduced which should be set by
all LED drivers handling pluggable LED devices (mainly USB LED devices).Signed-off-by: Heiner Kallweit
Signed-off-by: Jacek Anaszewski -
Now that workqueues have been removed from individual drivers and
were replaced with a core-internal workqueue we shouldn't
encourage people to add new workqueues to drivers.Signed-off-by: Heiner Kallweit
Signed-off-by: Jacek Anaszewski
04 Jan, 2016
5 commits
-
Complementing devm_led_classdev_register add a managed version of
led_trigger_register.I omit a managed version of led_classdev_unregister as the equivalent
devm_led_classdev_unregister isn't used in the kernel as of today.Signed-off-by: Heiner Kallweit
Signed-off-by: Jacek Anaszewski -
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS_SYNC flags.
led_set_brightness() now calls led_set_brightness_nosleep() instead of
choosing between sync and async op basing on the flags defined by the
driver.From now on, if a user wants to make sure that brightness will be set
synchronously, they have to use led_set_brightness_sync() API. It is now
being made publicly available since it has become apparent that it is
a caller who should decide whether brightness is to be set in
a synchronous or an asynchronous way.Signed-off-by: Jacek Anaszewski
Acked-by: Sakari Ailus -
This patch makes LED core capable of setting brightness for drivers
that implement brightness_set_blocking op. It removes from LED class
drivers responsibility for using work queues on their own.In order to achieve this set_brightness_delayed callback is being
modified to directly call one of available ops for brightness setting.led_set_brightness_async() function didn't set brightness in an
asynchronous way in all cases. It was mistakenly assuming that all
LED subsystem drivers used work queue in their brightness_set op,
whereas only half of them did that. Since it has no users now,
it is being removed.Signed-off-by: Jacek Anaszewski
Acked-by: Sakari Ailus -
The initial purpose of brightness_set_sync op, introduced along with
the LED flash class extension, was to add a means for setting torch LED
brightness as soon as possible, which couldn't have been guaranteed by
brightness_set op. This patch renames the op to brightness_set_blocking,
which describes its purpose in a more generic way. It is beneficial
in view of the prospective changes in the LED core, aiming at removing
the need for using work queues in LED class drivers that can sleep
or use delays while setting brightness.Signed-off-by: Jacek Anaszewski
Acked-by: Andrew Lunn
Acked-by: Pavel Machek
Acked-by: Sakari Ailus -
This patch adds LED_BLINK_BRIGHTNESS_CHANGE flag to indicate that blink
brightness has changed, and LED_BLINK_DISABLE flag to indicate that
blinking deactivation has been requested. In order to use the flags
led_timer_function and set_brightness_delayed callbacks as well as
led_set_brightness() function are being modified. The main goal of these
modifications is to prepare set_brightness_work for extension of the
scope of its responsibilities.Signed-off-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Sakari Ailus
26 Oct, 2015
1 commit
-
The EAE PLX-PCI card has special leds on the the main io pci resource
bar. This patch adds support to trigger the conflict and data leds with
the packages.Signed-off-by: Michael Grzeschik
05 May, 2015
1 commit
-
Part of led-trigger API was in the private drivers/leds/leds.h header.
Move it to the include/linux/leds.h header to unify the API location
and announce it as public. It has been already exported from
led-triggers.c with EXPORT_SYMBOL_GPL macro. The no-op definitions are
changed from macros to inline to match the style of the surrounding code.Signed-off-by: Jacek Anaszewski
Cc: Richard Purdie
Acked-by: Sakari Ailus
Signed-off-by: Bryan Wu
10 Mar, 2015
2 commits
-
Synchronized flash strobe feature has been considered not fitting
for LED subsystem sysfs interface and thus is being removed.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Signed-off-by: Bryan Wu -
(cooloney@gmail.com: add _unregister function into the document)
Suggested-by: Stephen Boyd
Signed-off-by: Bjorn Andersson
Signed-off-by: Bryan Wu
27 Jan, 2015
1 commit
-
Some LED devices support two operation modes - torch and flash.
This patch provides support for flash LED devices in the LED subsystem
by introducing new sysfs attributes and kernel internal interface.
The attributes being introduced are: flash_brightness, flash_strobe,
flash_timeout, max_flash_timeout, max_flash_brightness, flash_fault,
flash_sync_strobe and available_sync_leds. All the flash related
features are placed in a separate module.The modifications aim to be compatible with V4L2 framework requirements
related to the flash devices management. The design assumes that V4L2
sub-device can take of the LED class device control and communicate
with it through the kernel internal interface. When V4L2 Flash sub-device
file is opened, the LED class device sysfs interface is made
unavailable.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Acked-by: Pavel Machek
Signed-off-by: Bryan Wu
16 Dec, 2014
1 commit
-
Pull LED subsystem update from Bryan Wu:
"We got some cleanup and driver for LP8860 as well as some patches for
LED Flash Class"* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds:
leds: lp8860: Fix module dependency
leds: lp8860: Introduce TI lp8860 4 channel LED driver
leds: Add support for setting brightness in a synchronous way
leds: implement sysfs interface locking mechanism
leds: syscon: handle multiple syscon instances
leds: delete copy/paste mistake
leds: regulator: Convert to devm_regulator_get_exclusive
15 Nov, 2014
2 commits
-
There are use cases when setting a LED brightness has to
have immediate effect (e.g. setting a torch LED brightness).
This patch extends LED subsystem to support such operations.
The LED subsystem internal API __led_set_brightness is changed
to led_set_brightness_async and new led_set_brightness_sync API
is added.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Signed-off-by: Bryan Wu -
Add a mechanism for locking LED subsystem sysfs interface.
This patch prepares ground for addition of LED Flash Class
extension, whose API will be integrated with V4L2 Flash API.
Such a fusion enforces introducing a locking scheme, which
will secure consistent access to the LED Flash Class device.The mechanism being introduced allows for disabling LED
subsystem sysfs interface by calling led_sysfs_disable function
and enabling it by calling led_sysfs_enable. The functions
alter the LED_SYSFS_DISABLE flag state and must be called
under mutex lock. The state of the lock is checked with use
of led_sysfs_is_disabled function. Such a design allows for
providing immediate feedback to the user space on whether
the LED Flash Class device is available or is under V4L2 Flash
sub-device control.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Signed-off-by: Bryan Wu
05 Nov, 2014
2 commits
-
Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO
descriptors") already converted most of the driver to use GPIO descriptors.
What is still missing is the platform specific hook gpio_blink_set() and
board files which pass legacy GPIO numbers to this driver in platform data.In this patch we handle the former and convert gpio_blink_set() to take
GPIO descriptor instead. In order to do this we convert the existing four
users to accept GPIO descriptor and translate it to legacy GPIO number in
the platform code. This effectively "pushes" legacy GPIO number usage from
the driver to platforms.Also add comment to the remaining block describing that it is legacy code
path and we are getting rid of it eventually.Suggested-by: Linus Walleij
Signed-off-by: Mika Westerberg
Acked-by: Andrew Lunn
Reviewed-by: Linus Walleij
Acked-by: Alexandre Courbot
Signed-off-by: Rafael J. Wysocki -
GPIO descriptors are the preferred way over legacy GPIO numbers
nowadays. Convert the driver to use GPIO descriptors internally but
still allow passing legacy GPIO numbers from platform data to support
existing platforms.Signed-off-by: Mika Westerberg
Acked-by: Alexandre Courbot
Acked-by: Bryan Wu
Acked-by: Arnd Bergmann
Acked-by: Grant Likely
Signed-off-by: Rafael J. Wysocki
13 Sep, 2014
1 commit
-
led_update_brightness helper function used to be exploited only locally
in the led-class.c module, where its result was being passed to the
brightness_show sysfs callback. With the introduction of v4l2-flash
subdevice the same functionality becomes required for reading current
brightness from a LED device. This patch adds checking of return value
of the brightness_get callback and moves the led_update_brightness()
function to the LED subsystem public API.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Signed-off-by: Bryan Wu
12 Sep, 2014
2 commits
-
Documentations states that brightness units type is enum led_brightness
and this is the type used by the led API functions. Adjust the type
of brightness variables in the struct led_classdev accordingly.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Signed-off-by: Bryan Wu -
Reorder include directives so that they are arranged
in alphabetical order.Signed-off-by: Jacek Anaszewski
Acked-by: Kyungmin Park
Cc: Richard Purdie
Signed-off-by: Bryan Wu
03 Sep, 2014
1 commit
-
This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758.
It's broken as it changes led_blink_set() in a way that it can now sleep
(while synchronously waiting for workqueue to be cancelled). That's a
problem, because it's possible that this function gets called from atomic
context (tpt_trig_timer() takes a readlock and thus disables preemption).This has been brought up 3 weeks ago already [1] but no proper fix has
materialized, and I keep seeing the problem since 3.17-rc1.[1] https://lkml.org/lkml/2014/8/16/128
BUG: sleeping function called from invalid context at kernel/workqueue.c:2650
in_atomic(): 1, irqs_disabled(): 0, pid: 2335, name: wpa_supplicant
5 locks held by wpa_supplicant/2335:
#0: (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x12/0x20
#1: (&wdev->mtx){+.+.+.}, at: [] cfg80211_mgd_wext_siwessid+0x5c/0x180 [cfg80211]
#2: (&local->mtx){+.+.+.}, at: [] ieee80211_prep_connection+0x17a/0x9a0 [mac80211]
#3: (&local->chanctx_mtx){+.+.+.}, at: [] ieee80211_vif_use_channel+0x5d/0x2a0 [mac80211]
#4: (&trig->leddev_list_lock){.+.+..}, at: [] tpt_trig_timer+0xec/0x170 [mac80211]
CPU: 0 PID: 2335 Comm: wpa_supplicant Not tainted 3.17.0-rc3 #1
Hardware name: LENOVO 7470BN2/7470BN2, BIOS 6DET38WW (2.02 ) 12/19/2008
ffff8800360b5a50 ffff8800751f76d8 ffffffff8159e97f ffff8800360b5a30
ffff8800751f76e8 ffffffff810739a5 ffff8800751f77b0 ffffffff8106862f
ffffffff810685d0 0aa2209200000000 ffff880000000004 ffff8800361c59d0
Call Trace:
[] dump_stack+0x4d/0x66
[] __might_sleep+0xe5/0x120
[] flush_work+0x5f/0x270
[] ? mod_delayed_work_on+0x80/0x80
[] ? mark_held_locks+0x6a/0x90
[] ? __cancel_work_timer+0x6f/0x100
[] ? trace_hardirqs_on_caller+0xfd/0x1c0
[] __cancel_work_timer+0x7b/0x100
[] cancel_delayed_work_sync+0xe/0x10
[] led_blink_set+0x1b/0x40
[] tpt_trig_timer+0x110/0x170 [mac80211]
[] ieee80211_mod_tpt_led_trig+0x9d/0x160 [mac80211]
[] __ieee80211_recalc_idle+0x98/0x140 [mac80211]
[] ieee80211_idle_off+0xe/0x10 [mac80211]
[] ieee80211_add_chanctx+0x3b/0x220 [mac80211]
[] ieee80211_new_chanctx+0x44/0xf0 [mac80211]
[] ieee80211_vif_use_channel+0x1fa/0x2a0 [mac80211]
[] ieee80211_prep_connection+0x188/0x9a0 [mac80211]
[] ieee80211_mgd_auth+0x256/0x2e0 [mac80211]
[] ieee80211_auth+0x13/0x20 [mac80211]
[] cfg80211_mlme_auth+0x106/0x270 [cfg80211]
[] cfg80211_conn_do_work+0x155/0x3b0 [cfg80211]
[] cfg80211_connect+0x3f0/0x540 [cfg80211]
[] cfg80211_mgd_wext_connect+0x158/0x1f0 [cfg80211]
[] cfg80211_mgd_wext_siwessid+0xde/0x180 [cfg80211]
[] ? cfg80211_wext_giwessid+0x50/0x50 [cfg80211]
[] cfg80211_wext_siwessid+0x1d/0x40 [cfg80211]
[] ioctl_standard_iw_point+0x14c/0x3e0
[] ? trace_hardirqs_on_caller+0xfd/0x1c0
[] ioctl_standard_call+0x8a/0xd0
[] ? ioctl_standard_iw_point+0x3e0/0x3e0
[] wireless_process_ioctl.constprop.10+0xb6/0x100
[] wext_handle_ioctl+0x5d/0xb0
[] dev_ioctl+0x329/0x620
[] ? trace_hardirqs_on_caller+0xfd/0x1c0
[] sock_ioctl+0x142/0x2e0
[] do_vfs_ioctl+0x300/0x520
[] ? sysret_check+0x1b/0x56
[] ? trace_hardirqs_on_caller+0xfd/0x1c0
[] SyS_ioctl+0x81/0xa0
[] system_call_fastpath+0x1a/0x1f
wlan0: send auth to 00:0b:6b:3c:8c:e4 (try 1/3)
wlan0: authenticated
wlan0: associate with 00:0b:6b:3c:8c:e4 (try 1/3)
wlan0: RX AssocResp from 00:0b:6b:3c:8c:e4 (capab=0x431 status=0 aid=2)
wlan0: associated
IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
cfg80211: Calling CRDA for country: NA
wlan0: Limiting TX power to 27 (27 - 0) dBm as advertised by 00:0b:6b:3c:8c:e4=================================
[ INFO: inconsistent lock state ]
3.17.0-rc3 #1 Not tainted
---------------------------------
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
swapper/0/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
((&(&led_cdev->blink_work)->work)){+.?...}, at: [] flush_work+0x0/0x270
{SOFTIRQ-ON-W} state was registered at:
[] __lock_acquire+0x30e/0x1a30
[] lock_acquire+0x91/0x110
[] flush_work+0x38/0x270
[] __cancel_work_timer+0x7b/0x100
[] cancel_delayed_work_sync+0xe/0x10
[] led_blink_set+0x1b/0x40
[] tpt_trig_timer+0x110/0x170 [mac80211]
[] ieee80211_mod_tpt_led_trig+0x9d/0x160 [mac80211]
[] __ieee80211_recalc_idle+0x98/0x140 [mac80211]
[] ieee80211_idle_off+0xe/0x10 [mac80211]
[] ieee80211_add_chanctx+0x3b/0x220 [mac80211]
[] ieee80211_new_chanctx+0x44/0xf0 [mac80211]
[] ieee80211_vif_use_channel+0x1fa/0x2a0 [mac80211]
[] ieee80211_prep_connection+0x188/0x9a0 [mac80211]
[] ieee80211_mgd_auth+0x256/0x2e0 [mac80211]
[] ieee80211_auth+0x13/0x20 [mac80211]
[] cfg80211_mlme_auth+0x106/0x270 [cfg80211]
[] cfg80211_conn_do_work+0x155/0x3b0 [cfg80211]
[] cfg80211_connect+0x3f0/0x540 [cfg80211]
[] cfg80211_mgd_wext_connect+0x158/0x1f0 [cfg80211]
[] cfg80211_mgd_wext_siwessid+0xde/0x180 [cfg80211]
[] cfg80211_wext_siwessid+0x1d/0x40 [cfg80211]
[] ioctl_standard_iw_point+0x14c/0x3e0
[] ioctl_standard_call+0x8a/0xd0
[] wireless_process_ioctl.constprop.10+0xb6/0x100
[] wext_handle_ioctl+0x5d/0xb0
[] dev_ioctl+0x329/0x620
[] sock_ioctl+0x142/0x2e0
[] do_vfs_ioctl+0x300/0x520
[] SyS_ioctl+0x81/0xa0
[] system_call_fastpath+0x1a/0x1f
irq event stamp: 493416
hardirqs last enabled at (493416): [] __cancel_work_timer+0x6f/0x100
hardirqs last disabled at (493415): [] try_to_grab_pending+0x1f/0x160
softirqs last enabled at (493408): [] _local_bh_enable+0x1d/0x50
softirqs last disabled at (493409): [] irq_exit+0xa5/0xb0other info that might help us debug this:
Possible unsafe locking scenario:CPU0
----
lock((&(&led_cdev->blink_work)->work));
lock((&(&led_cdev->blink_work)->work));*** DEADLOCK ***
2 locks held by swapper/0/0:
#0: (((&tpt_trig->timer))){+.-...}, at: [] call_timer_fn+0x0/0x180
#1: (&trig->leddev_list_lock){.+.?..}, at: [] tpt_trig_timer+0xec/0x170 [mac80211]stack backtrace:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.17.0-rc3 #1
Hardware name: LENOVO 7470BN2/7470BN2, BIOS 6DET38WW (2.02 ) 12/19/2008
ffffffff8246eb30 ffff88007c203b00 ffffffff8159e97f ffffffff81a194c0
ffff88007c203b50 ffffffff81599c29 0000000000000001 ffffffff00000001
ffff880000000000 0000000000000006 ffffffff81a194c0 ffffffff81093ad0
Call Trace:
[] dump_stack+0x4d/0x66
[] print_usage_bug+0x1f4/0x205
[] ? check_usage_backwards+0x140/0x140
[] mark_lock+0x223/0x2b0
[] __lock_acquire+0x2b0/0x1a30
[] lock_acquire+0x91/0x110
[] ? mod_delayed_work_on+0x80/0x80
[] ? __ieee80211_get_rx_led_name+0x10/0x10 [mac80211]
[] flush_work+0x38/0x270
[] ? mod_delayed_work_on+0x80/0x80
[] ? mark_held_locks+0x6a/0x90
[] ? __cancel_work_timer+0x6f/0x100
[] ? __ieee80211_get_rx_led_name+0x10/0x10 [mac80211]
[] ? trace_hardirqs_on_caller+0xad/0x1c0
[] ? __ieee80211_get_rx_led_name+0x10/0x10 [mac80211]
[] __cancel_work_timer+0x7b/0x100
[] cancel_delayed_work_sync+0xe/0x10
[] led_blink_set+0x1b/0x40
[] tpt_trig_timer+0x110/0x170 [mac80211]
[] call_timer_fn+0x75/0x180
[] ? process_timeout+0x10/0x10
[] ? __ieee80211_get_rx_led_name+0x10/0x10 [mac80211]
[] run_timer_softirq+0x1fc/0x2f0
[] __do_softirq+0x115/0x2e0
[] irq_exit+0xa5/0xb0
[] do_IRQ+0x53/0xf0
[] common_interrupt+0x6f/0x6f
[] ? cpuidle_enter_state+0x6e/0x180
[] cpuidle_enter+0x12/0x20
[] cpu_startup_entry+0x330/0x360
[] rest_init+0xc1/0xd0
[] ? csum_partial_copy_generic+0x170/0x170
[] start_kernel+0x44f/0x45a
[] ? set_init_arg+0x53/0x53
[] x86_64_start_reservations+0x2a/0x2c
[] x86_64_start_kernel+0xf1/0xf4Cc: Vincent Donnefort
Cc: Hugh Dickins
Cc: Tejun Heo
Signed-off-by: Jiri Kosina
Signed-off-by: Bryan Wu
04 Jul, 2014
1 commit
-
This patch converts the blink timer from led-core to workqueue which is more
suitable for this kind of non-priority operations. Moreover, timer may lead to
errors when a LED setting function use a scheduling function such as pinctrl
which is using mutex.Signed-off-by: Vincent Donnefort
Signed-off-by: Bryan Wu
26 Jun, 2014
1 commit
-
Allow led-class devices to be created with optional attribute groups.
This is needed in order to allow led drivers to create custom device
attributes in a race-free manner.Signed-off-by: Johan Hovold
Signed-off-by: Bryan Wu
02 Apr, 2013
2 commits
-
Some LED devices support flash/torch functionality through the LED subsystem.
This patch enables direct LED trigger controls by the driver.
Flash on/off and torch on/off can be done simply by other driver space.
Two trigger APIs are added, ledtrig_flash_ctrl() and ledtrig_torch_ctrl().Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Bryan Wu -
Macros are used in case that an inline function doesn't work.
Otherwise, use an empty inline function.(a) Case of !CONFIG_LEDS_TRIGGERS
Following macros are replaced with inline functions.
led_trigger_register_simple()
led_trigger_unregister_simple()
led_trigger_event()
To make inline types, the structure, 'led_trigger' should be defined.
This structure has no member at all.(b) Case of !CONFIG_LEDS_TRIGGER_IDE_DISK
ledtrig_ide_activity() macro is replaced with an inline function as well.(c) DEFINE_LED_TRIGGER() and DEFINE_LED_TRIGGER_GLOBAL()
Struct 'led_trigger' is defined both cases, with CONFIG_LEDS_TRIGGERS and
without CONFIG_LEDS_TRIGGERS.
Those macros are moved out of CONFIG_LED_TRIGGERS because of no-dependency
on CONFIG_LEDS_TRIGGERS.(d) Fix build errors in mmc-core driver
After replacing macros with inline functions, following build errors occur.
(condition: CONFIG_LEDS_TRIGGERS is not set)drivers/mmc/core/core.c: In function 'mmc_request_done':
drivers/mmc/core/core.c:164:25: error: 'struct mmc_host' has no member named 'led'
drivers/mmc/core/core.c: In function 'mmc_start_request':
drivers/mmc/core/core.c:254:24: error: 'struct mmc_host' has no member named 'led'
make[3]: *** [drivers/mmc/core/core.o] Error 1The reason of these errors is non-existent member variable, 'led'.
It is only valid when CONFIG_LEDS_TRIGGERS is set.
But now, it can be used without this dependency.
To fix build errors, member 'led' is always used without its config option in
'include/linux/mmc/host.h'.Signed-off-by: Milo(Woogyom) Kim
Signed-off-by: Bryan Wu
27 Nov, 2012
2 commits
-
This patch fixes build warnings when CONFIG_LEDS_TRIGGERS is
disabled as below:
include/linux/leds.h:158:18: warning: 'struct led_trigger' declared inside parameter list [enabled by default]
include/linux/leds.h:158:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled
by default]Signed-off-by: Jingoo Han
Acked-by: Fabio Baltieri
Signed-off-by: Bryan Wu -
Implements a "led_trigger_rename" function to rename a trigger with
proper locking.This assumes that led name was originally allocated in non-constant
storage.Signed-off-by: Fabio Baltieri
Cc: Kurt Van Dijck
Signed-off-by: Bryan Wu
10 Oct, 2012
1 commit
-
Pull LED subsystem update from Bryan Wu.
* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds: (24 commits)
leds: add output driver configuration for pca9633 led driver
leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()
leds: Add new LED driver for lm3642 chips
leds-lp5523: Fix riskiness of the page fault
leds-lp5523: turn off the LED engines on unloading the driver
leds-lm3530: Fix smatch warnings
leds-lm3530: Use devm_regulator_get function
leds: leds-gpio: adopt pinctrl support
leds: Add new LED driver for lm355x chips
leds-lp5523: use the i2c device id rather than fixed name
leds-lp5523: add new device id for LP55231
leds-lp5523: support new LP55231 device
leds: triggers: send uevent when changing triggers
leds-lp5523: minor code style fixes
leds-lp5523: change the return type of lp5523_set_mode()
leds-lp5523: set the brightness to 0 forcely on removing the driver
leds-lp5523: add channel name in the platform data
leds: leds-gpio: Use of_get_child_count() helper
leds: leds-gpio: Use platform_{get,set}_drvdata
leds: leds-gpio: use of_match_ptr()
...
11 Sep, 2012
1 commit
-
Delay execution of led_set_brightness() if need to stop soft-blink
timer.This allows led_set_brightness to be called in hard-irq context even if
soft-blink was activated on that LED.Signed-off-by: Fabio Baltieri
Cc: Pawel Moll
Signed-off-by: Bryan Wu
13 Aug, 2012
1 commit
-
…oney/linux-leds into next/drivers
From Bryan Wu <bryan.wu@canonical.com>:
Based on Linus Walleij's ARM LED consolidation work, this patchset introduce a
new generic led trigger for CPU not only for ARM but also for others.For enabling CPU idle event, CPU arch code should call ledtrig_cpu() stub to
trigger idle start or idle end event.These patches convert old style LED driver in arch/arm to gpio_led or new led
driver interface. Against 3.5 release and build successfully for all the machines.Test ledtrig-cpu driver on OMAP4 Panda board.
v9 --> v10
* fix compiling issue on versatile_defconfig reported by Russell King
* rebase to 3.5 kernel and move patches to new git treev8 --> v9:
* use mutex to replace rw_sema pointed out by Tim Gardner
* add a new struct led_trigger_cpu
* add lock_is_inited to record mutex lock initializationv6 --> v7:
* add a patch to unify the led-trigger name
* fix some typo pointed
* use BUG_ON to detect CPU numbers during building stagev5 --> v6:
* replace __get_cpu_var() to per_cpu()
* remove smp_processor_id() which is wrong with for_each_possible_cpu()
* test on real OMAP4 Panda board
* add comments about CPU hotplug in the CPU LED trigger driverv4 --> v5:
* rebase all the patches on top of latest linux-next
* replace on_each_cpu() with for_each_possible_cpu()
* add some description of ledtrig_cpu() API
* remove old leds code from driver nwflash.c, which should use a new led trigger then
* this trigger driver can be built as module nowv3 --> v4:
* fix a typo pointed by Jochen Friedrich
* fix some building errors
* add Reviewed-by and Tested-by into patch logv2 --> v3:
* almost rewrote the whole ledtrig-cpu driver, which is more simple
* every CPU will have a per-CPU trigger
* cpu trigger can be assigned to any leds
* fix a lockdep issue in led-trigger common code
* other fix according to reviewv1 --> v2:
* remove select operations in Kconfig of every machines
* add back supporting of led in core module of mach-integrator
* solidate name scheme in ledtrig-cpu.c
* add comments of CPU_LED_* cpu led events
* fold patches of RealView and Versatile together
* add machine_is_ check during assabet led driver init
* add some Acked-by in patch logs
* remove code for simpad machine in machine-sa11000, since Jochen Friedrich
introduced gpiolib and gpio-led driver for simpad
* on Assabet and Netwinder machine, LED operations is reversed like:
setting bit means turn off leds
clearing bit means turn on leds
* add a new function to read CM_CTRL register for led driver* 'for-arm-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds:
ARM: use new LEDS CPU trigger stub to replace old one
ARM: mach-sa1100: retire custom LED code
ARM: mach-omap1: retire custom LED code
ARM: mach-pnx4008: remove including old leds event API header file
ARM: plat-samsung: remove including old leds event API header file
ARM: mach-pxa: retire custom LED code
char: nwflash: remove old led event code
ARM: mach-footbridge: retire custom LED code
ARM: mach-ebsa110: retire custom LED code
ARM: mach-clps711x: retire custom LED code of P720T machine
ARM: mach-integrator: retire custom LED code
ARM: mach-integrator: move CM_CTRL to header file for accessing by other functions
ARM: mach-orion5x: convert custom LED code to gpio_led and LED CPU trigger
ARM: mach-shark: retire custom LED code
ARM: mach-ks8695: remove leds driver, since nobody use it
ARM: mach-realview and mach-versatile: retire custom LED code
ARM: at91: convert old leds drivers to gpio_led and led_trigger drivers
led-triggers: create a trigger for CPU activityConflicts:
arch/arm/mach-clps711x/p720t.c
arch/arm/mach-sa1100/leds-cerf.c
arch/arm/mach-sa1100/leds-lart.cLet's hope this is the last time we pull this and it doesn't cause
more trouble. I have verified that version 10 causes no build
warnings or errors any more, and the patches still look good.Signed-off-by: Arnd Bergmann <arnd@arndb.de>
31 Jul, 2012
1 commit
-
Attempting to consolidate the ARM LED code, this removes the
custom RealView LED trigger code to turn LEDs on and off in
response to CPU activity and replace it with a standard trigger.(bryan.wu@canonical.com:
It introduces several syscore stubs into this trigger.
It also provides ledtrig_cpu trigger event stub in .
Although it was inspired by ARM work, it can be used in other arch.)Cc: Richard Purdie
Signed-off-by: Linus Walleij
Signed-off-by: Bryan Wu
Reviewed-by: Jamie Iles
Tested-by: Jochen Friedrich
24 Jul, 2012
2 commits
-
Rename leds external interface led_brightness_set() to led_set_brightness().
This is the second phase of the change to reduce confusion between the
leds internal and external interfaces that set brightness. With this change,
now the external interface is led_set_brightness(). The first phase renamed
the internal interface led_set_brightness() to __led_set_brightness().
There are no changes to the interface implementations.Signed-off-by: Shuah Khan
Signed-off-by: Bryan Wu -
Add two new functions, led_blink_set_oneshot and
led_trigger_blink_oneshot, to be used by triggers for one-shot blink of
led devices.This is implemented extending the existing software-blink code, and uses
the same timer and handler function.The behavior of the code is to do a blink-on, blink-off sequence when
the function is called, ignoring other calls until the sequence is
completed so that the leds keep blinking at constant rate if the
functions are called repeatedly.This is meant to be used by drivers which needs to trigger on sporadic
event, but doesn't have clear busy/idle trigger points.After the blink sequence the led remains off. This behavior can be
inverted setting the "invert" argument, which blink the led off, than on
and leave the led on after the sequence.(bryan.wu@canonical.com: rebase to commit 'leds: don't disable blinking
when writing the same value to delay_on or delay_off')Signed-off-by: Fabio Baltieri
Acked-by: Shuah Khan
Signed-off-by: Bryan Wu
