Eric Lee / smarc-fsl-linux-kernel

06 May, 2015

1 commit

  • 05836c378   util_macros.h: have array pointer point to array of constants ... Browse Code »

    Using the new find_closest() macro can result in the following sparse
    warnings.

    drivers/hwmon/lm85.c:194:16: warning:
    incorrect type in initializer (different modifiers)
    drivers/hwmon/lm85.c:194:16: expected int *__fc_a
    drivers/hwmon/lm85.c:194:16: got int static const [toplevel] *
    drivers/hwmon/lm85.c:210:16: warning:
    incorrect type in initializer (different modifiers)
    drivers/hwmon/lm85.c:210:16: expected int *__fc_a
    drivers/hwmon/lm85.c:210:16: got int const *map

    This is because the array passed to find_closest() will typically be
    declared as array of constants, but the macro declares a non-constant
    pointer to it.

    Signed-off-by: Guenter Roeck
    Cc: Bartosz Golaszewski

    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Guenter Roeck
     

17 Apr, 2015

1 commit

  • 95d119528   util_macros.h: add find_closest() macro ... Browse Code »

    This series unduplicates the code used to find the member in an array
    closest to 'x'.

    The first patch adds a macro implementing the algorithm in two flavors -
    for arrays sorted in ascending and descending order. The second updates
    Documentation/CodingStyle on the naming convention for local variables in
    macros resembling functions. Other three patches replace duplicated code
    with calls to one of these macros in some hwmon drivers.

    This patch (of 5):

    Searching for the member of an array closest to 'x' is duplicated in
    several places.

    Add a new include - util_macros.h - and two macros that implement this
    algorithm for arrays sorted both in ascending and descending order.

    Uses linear search.

    Signed-off-by: Bartosz Golaszewski
    Cc: Guenter Roeck
    Cc: Steven Rostedt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bartosz Golaszewski