02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

08 Jun, 2014

1 commit

  • Replaced non-standard C use of Variable Length Arrays In Structs (VLAIS) in
    xt_repldata.h with a C99 compliant flexible array member and then calculated
    offsets to the other struct members. These other members aren't referenced by
    name in this code, however this patch maintains the same memory layout and
    padding as was previously accomplished using VLAIS.

    Had the original structure been ordered differently, with the entries VLA at
    the end, then it could have been a flexible member, and this patch would have
    been a lot simpler. However since the data stored in this structure is
    ultimately exported to userspace, the order of this structure can't be changed.

    This patch makes no attempt to change the existing behavior, merely the way in
    which the current layout is accomplished using standard C99 constructs. As such
    the code can now be compiled with either gcc or clang.

    This version of the patch removes the trailing alignment that the VLAIS
    structure would allocate in order to simplify the patch.

    Author: Mark Charlebois
    Signed-off-by: Mark Charlebois
    Signed-off-by: Behan Webster
    Signed-off-by: Vinícius Tinti

    Mark Charlebois
     

11 Feb, 2010

1 commit