20 Oct, 2014

1 commit

• 14ac00e03   spi: drop owner assignment from platform_drivers ... Browse Code »

  A platform_driver does not need to set an owner, it will be populated by the
  driver core.

  Signed-off-by: Wolfram Sang

  Wolfram Sang

  2014-10-20 22:21:36 +0800  

17 Jun, 2014

1 commit

• 25f8a7cc5   spi: sh-sci: fix use-after-free in sh_sci_spi_remove() ... Browse Code »

  setbits() uses sp->membase.

  Signed-off-by: Jürg Billeter
  Acked-by: Geert Uytterhoeven
  Signed-off-by: Mark Brown

  Jürg Billeter

  2014-06-17 22:47:31 +0800  

15 Apr, 2014

1 commit

• e4745fef5   spi: Remove unneeded include of linux/workqueue.h ... Browse Code »

  Signed-off-by: Axel Lin
  Signed-off-by: Mark Brown

  Axel Lin

  2014-04-15 00:20:15 +0800  

30 Mar, 2014

1 commit

• 81235b4ea   Merge remote-tracking branches 'spi/topic/s3c64xx', 'spi/topic/sc18is602', 'spi/… ... Browse Code »

  …topic/sh-hspi', 'spi/topic/sh-msiof', 'spi/topic/sh-sci', 'spi/topic/sirf' and 'spi/topic/spidev' into spi-next

  Mark Brown

  2014-03-30 08:51:34 +0800  

13 Mar, 2014

1 commit

• ed8eb250d   spi: sh-sci: Prevent NULL pointer dereference ... Browse Code »

  If sp->info is NULL, we will hit NULL pointer dereference in probe() while
  setting bus_num and num_chipselect for master:

  sp->bitbang.master->bus_num = sp->info->bus_num;
  sp->bitbang.master->num_chipselect = sp->info->num_chipselect;

  Thus add NULL test for sp->info in probe() to prevent NULL pointer dereference.

  Signed-off-by: Axel Lin
  Reviewed-by: Geert Uytterhoeven
  Signed-off-by: Mark Brown

  Axel Lin

  2014-03-13 21:40:51 +0800  

03 Feb, 2014

1 commit

• 3a44623d5   spi: delete non-required instances of include <linux/init.h> ... Browse Code »

  None of these files are actually using any __init type directives
  and hence don't need to include . Most are just a
  left over from __devinit and __cpuinit removal, or simply due to
  code getting copied from one driver to the next.

  Signed-off-by: Paul Gortmaker
  Signed-off-by: Mark Brown

  Paul Gortmaker

  2014-02-03 20:20:35 +0800  

17 Sep, 2013

1 commit

• 94c69f765   spi: bitbang: Let spi_bitbang_start() take a reference to master ... Browse Code »

  Many drivers that use bitbang library have a leak on probe error paths.
  This is because once a spi_master_get() call succeeds, we need an additional
  spi_master_put() call to free the memory.

  Fix this issue by moving the code taking a reference to master to
  spi_bitbang_start(), so spi_bitbang_start() will take a reference to master on
  success. With this change, the caller is responsible for calling
  spi_bitbang_stop() to decrement the reference and spi_master_put() as
  counterpart of spi_alloc_master() to prevent a memory leak.

  So now we have below patten for drivers using bitbang library:

  probe:
  spi_alloc_master -> Init reference count to 1
  spi_bitbang_start -> Increment reference count
  remove:
  spi_bitbang_stop -> Decrement reference count
  spi_master_put -> Decrement reference count (reference count reaches 0)

  Fixup all users accordingly.

  Signed-off-by: Axel Lin
  Suggested-by: Uwe Kleine-Koenig
  Acked-by: Uwe Kleine-Koenig
  Signed-off-by: Mark Brown

  Axel Lin

  2013-09-17 19:56:14 +0800  

29 Aug, 2013

1 commit

• 8074cf063   spi: use dev_get_platdata() ... Browse Code »

  Use the wrapper function for retrieving the platform data instead of
  accessing dev->platform_data directly.

  Signed-off-by: Jingoo Han
  Signed-off-by: Mark Brown

  Jingoo Han

  2013-08-29 20:56:23 +0800  

01 Nov, 2011

1 commit

• d7614de42   spi: Add module.h to implicit users in drivers/spi ... Browse Code »

  We are clipping down the presence of module.h, since it was
  everywhere. If you really need it, you better call it out,
  as per this changeset.

  Signed-off-by: Paul Gortmaker

  Paul Gortmaker

  2011-11-01 07:32:17 +0800  

25 Oct, 2011

1 commit

• 940ab8896   drivercore: Add helper macro for platform_driver boilerplate ... Browse Code »

  For simple modules that contain a single platform_driver without any
  additional setup code then ends up being a block of duplicated
  boilerplate. This patch adds a new macro, module_platform_driver(),
  which replaces the module_init()/module_exit() registrations with
  template functions.

  Signed-off-by: Grant Likely
  Acked-by: Greg Kroah-Hartman
  Reviewed-by: Magnus Damm
  Reviewed-by: Mark Brown
  Reviewed-by: Stephen Boyd

  Grant Likely

  2011-10-25 06:35:47 +0800  

06 Jun, 2011

1 commit

• ca632f556   spi: reorganize drivers ... Browse Code »

  Sort the SPI makefile and enforce the naming convention spi_*.c for
  spi drivers.

  This change also rolls the contents of atmel_spi.h into the .c file
  since there is only one user of that particular include file.

  v2: - Use 'spi-' prefix instead of 'spi_' to match what seems to be
  be the predominant pattern for subsystem prefixes.
  - Clean up filenames in Kconfig and header comment blocks

  Signed-off-by: Grant Likely
  Acked-by: Wolfram Sang
  Acked-by: Linus Walleij

  Grant Likely

  2011-06-06 15:16:30 +0800