29 Jan, 2010
1 commit
-
In struct device_node, the phandle is named 'linux_phandle' for PowerPC
and MicroBlaze, and 'node' for SPARC. There is no good reason for the
difference, it is just an artifact of the code diverging over a couple
of years. This patch renames both to simply .phandle.Note: the .node also existed in PowerPC/MicroBlaze, but the only user
seems to be arch/powerpc/platforms/powermac/pfunc_core.c. It doesn't
look like the assignment between .linux_phandle and .node is
significantly different enough to warrant the separate code paths
unless ibm,phandle properties actually appear in Apple device trees.I think it is safe to eliminate the old .node property and use
phandle everywhere.Signed-off-by: Grant Likely
Acked-by: David S. Miller
Tested-by: Wolfram Sang
Acked-by: Benjamin Herrenschmidt
01 Oct, 2009
1 commit
-
The client->driver pointer can be NULL when i2c-device probing fails
in i2c_new_device(). This patch adds the NULL checks for client->driver
and return the error instead of blind assumption of driver availability.Reported-by: Tim Shepard
Cc: Jean Delvare
Cc: Johannes Berg
Signed-off-by: Takashi Iwai
31 Jul, 2009
1 commit
-
Check that the result of kzalloc is not NULL before a dereference.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)//
@@
expression *x;
identifier f;
constant char *C;
@@x = \(kmalloc\|kcalloc\|kzalloc\)(...);
... when != x == NULL
when != x != NULL
when != (x || ...)
(
kfree(x)
|
f(...,C,...,x,...)
|
*f(...,x,...)
|
*x->f
)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
12 May, 2009
1 commit
-
In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device. Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used. These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.Signed-off-by: Greg Kroah-Hartman
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai
21 Apr, 2009
1 commit
-
The legacy i2c binding model is going away soon, so convert the AOA
codec drivers to the new model or they'll break.Signed-off-by: Jean Delvare
Tested-by: Johannes Berg
Tested-by: Andreas Schwab
Cc: Benjamin Herrenschmidt
Signed-off-by: Takashi Iwai
24 Mar, 2009
1 commit
16 Jan, 2009
2 commits
-
Some machines have a master amp GPIO that needs to be toggled to
get sound output, in addition to speaker/headphone/line-out amps.
This makes snd-aoa handle it, if present in the device tree, thus
making snd-aoa be able to output sound on PowerMac3,6, which was
previously handled by snd-powermac which also doesn't use the
master amp GPIO.Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai -
This patch changes snd-aoa to handle some older machines that are
currently handled by snd-powermac. snd-aoa has a number of advantages
though, notably it can autoload better and is generally a more modern
driver.By hardcoding the accepted device-ids (last hunk of the patch) I'm
trying to avoid regressions because this driver will otherwise load
automatically and not let snd-powermac load. People who are unhappy
with snd-powermac and have a device-id property in the device tree
are encouraged to read this patch and make a patch to amend this as
appropriate.Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
12 Jan, 2009
1 commit
-
Convert from snd_card_new() to the new snd_card_create() function
in other sound subdirectories.Signed-off-by: Takashi Iwai
25 Dec, 2008
1 commit
03 Nov, 2008
2 commits
-
[stripped sound/isa/* changes, replaced with the next patch -- tiwai]
Signed-off-by: Kay Sievers
Signed-off-by: Takashi Iwai
24 Oct, 2008
3 commits
-
This cleans up the apple onboard audio driver filenames.
Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai -
We shouldn't modify a global variable here.
Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
15 Oct, 2008
1 commit
-
Manual fixup of conflicts on:
arch/powerpc/include/asm/dcr-regs.h
drivers/net/ibm_newemac/core.h
25 Aug, 2008
1 commit
-
Signed-off-by: Roel Kluin
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
20 Aug, 2008
1 commit
-
Signed-off-by: Stephen Rothwell
Acked-by: Takashi Iwai
Signed-off-by: Paul Mackerras
27 May, 2008
1 commit
-
Convert menu in sound Kconfig files to menuconfig and if.
Signed-off-by: Takashi Iwai
01 Feb, 2008
4 commits
-
This header file exists only for some hacks to adapt alsa-driver
tree. It's useless for building in the kernel. Let's move a few
lines in it to sound/core.h and remove it.
With this patch, sound/driver.h isn't removed but has just a single
compile warning to include it. This should be really killed in
future.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Set a proper error code in the error path of i2sbus_attach_codec().
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
The aoa driver is not specifying constraints on number of periods, and, it
seems, it might end with a non-integer number, which it cannot deal with.
Fix by adding a proper constraint.Signed-off-by: Heikki Lindholm
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Check the value ranges in ctl put callbacks properly in aoa drivers.
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
16 Oct, 2007
2 commits
-
Clean up codes using the new common snd_ctl_boolean_*_info() callbacks.
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
sound/aoa/codecs/snd-aoa-codec-tas.c:750: warning: 'tas_suspend' defined but not used
sound/aoa/codecs/snd-aoa-codec-tas.c:760: warning: 'tas_resume' defined but not used
Acked-by: Johannes BergSigned-off-by: Stephen Rothwell
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
13 Oct, 2007
1 commit
-
This changes the uevent buffer functions to use a struct instead of a
long list of parameters. It does no longer require the caller to do the
proper buffer termination and size accounting, which is currently wrong
in some places. It fixes a known bug where parts of the uevent
environment are overwritten because of wrong index calculations.Many thanks to Mathieu Desnoyers for finding bugs and improving the
error handling.Signed-off-by: Kay Sievers
Cc: Mathieu Desnoyers
Cc: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman
20 Jul, 2007
1 commit
-
Parse error in ifdef or bad use of macro.
Signed-off-by: Yoann Padioleau
Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
11 May, 2007
3 commits
-
This patch changes snd-aoa-i2sbus to use MODULE_DEVICE_TABLE instead of
a hardcoded MODULE_ALIAS. Thanks to Sylvain Munaut for pointing this
out.Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
strlcpy already accounts for the trailing zero in its length
computation, so there is no need to substract one to the buffer size.Signed-off-by: Jean Delvare
Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This fixes a warning sparse gives.
Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
07 May, 2007
1 commit
-
for consistency with other Open Firmware interfaces (and Sparc).
This is just a straight replacement.
This leaves the compatibility define in place.
Signed-off-by: Stephen Rothwell
Signed-off-by: Paul Mackerras
30 Apr, 2007
1 commit
28 Apr, 2007
1 commit
-
Make use of add_uevent_var() instead of (often incorrectly) open coding it.
Signed-off-by: Michael Ellerman
Signed-off-by: Eric Rannaud
Cc: Kay Sievers
Cc: Cornelia Huck
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman
13 Apr, 2007
2 commits
-
Signed-off-by: Stephen Rothwell
Acked-by: Benjamin Herrenschmidt
Signed-off-by: Paul Mackerras -
This just tidies up some of the remains.
Signed-off-by: Stephen Rothwell
Signed-off-by: Paul Mackerras
09 Feb, 2007
5 commits
-
This fixes the problem of getting extra bytes inserted at the
beginning of a recording when using the Apple i2s interface and DBDMA
controller. It turns out that we can't just abort the DMA; we have to
let it stop at the end of a command, and then wait for the S7 bit to
be set before turning off the DBDMA controller. Doing that for
playback doesn't seem to be necessary, but doesn't hurt either.
We use the technique used by the Darwin driver: make each transfer
command branch to a stop command if the S0 status bit is set. Thus we
can ask the DMA controller to stop at the end of the current command
by setting S0.
The interrupt routine now looks at and clears the status word of the
DBDMA command ring. This is necessary so it can know when the DBDMA
controller has seen that S0 is set, and so when it should look for the
DBDMA controller being stopped and S7 being set. This also ended up
simplifying the calculation in i2sbus_pcm_pointer.
Tested on a 15 inch albook.
[Addition by Johannes]
I modified this patch and added the suspend/resume bits to it to get my
powermac into a decent state when playing sound across suspend to disk
that has a different bitrate from what the firmware programs the
hardware to.
I also added the SNDRV_PCM_INFO_JOINT_DUPLEX flag because it seemed the
right thing to do and I was looking at the info stuff.Signed-off-by: Paul Mackerras
Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This just removes two useless printks.
Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This patch removes redundant argument checks for of_node_put() and kfree().
Acked-by: Johannes BergSigned-off-by: Mariusz Kozlowski
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
When the machine resumes the onyx codec might be in a weird state. Hence,
simply fully reset it once (and keep the code to take it out of suspend in
case the suspend of the codec chip survives a reset).Signed-off-by: Johannes Berg
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
create sysfs driver symlink for snd-aoa in /sys/bus/aoa-soundbus/devices/*/
Acked-by: Johannes BergSigned-off-by: Olaf Hering
Signed-off-by: Andrew Morton
Signed-off-by: Jaroslav Kysela