12 Dec, 2014
1 commit
-
Pull libata changes from Tejun Heo:
"The only interesting piece is the support for shingled drives. The
changes in libata layer are minimal. All it does is identifying the
new class of device and report upwards accordingly"* 'for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata:
libata: Remove FIXME comment in atapi_request_sense()
sata_rcar: Document deprecated "renesas,rcar-sata"
sata_rcar: Add clocks to sata_rcar bindings
ahci_sunxi: Make AHCI_HFLAG_NO_PMP flag configurable with a module option
libata-scsi: Update SATL for ZAC drives
libata: Implement ATA_DEV_ZAC
libsas: use ata_dev_classify()
27 Nov, 2014
1 commit
-
The task_collector mode (or "latency_injector", (C) Dan Willians) is an
optional I/O path in libsas that queues up scsi commands instead of
directly sending it to the hardware. It generall increases latencies
to in the optiomal case slightly reduce mmio traffic to the hardware.Only the obsolete aic94xx driver and the mvsas driver allowed to use
it without recompiling the kernel, and most drivers didn't support it
at all.Remove the giant blob of code to allow better optimizations for scsi-mq
in the future.Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Dan Williams
24 Nov, 2014
1 commit
-
All drivers use the implementation for ramping the queue up and down, so
instead of overloading the change_queue_depth method call the
implementation diretly if the driver opts into it by setting the
track_queue_depth flag in the host template.Note that a few drivers validated the new queue depth in their
change_queue_depth method, but as we never go over the queue depth
set during slave_configure or the sysfs file this isn't nessecary
and can safely be removed.Signed-off-by: Christoph Hellwig
Reviewed-by: Mike Christie
Reviewed-by: Hannes Reinecke
Reviewed-by: Venkatesh Srinivas
12 Nov, 2014
1 commit
-
Allow a driver to ask for block layer tags by setting .use_blk_tags in the
host template, in which case it will always see a valid value in
request->tag, similar to the behavior when using blk-mq. This means even
SCSI "untagged" commands will now have a tag, which is especially useful
when using a host-wide tag map.Signed-off-by: Christoph Hellwig
Reviewed-by: Mike Christie
Reviewed-by: Martin K. Petersen
Reviewed-by: Hannes Reinecke
06 Nov, 2014
1 commit
-
Use the ata device class from libata in libsas instead of checking
the supported command set and switch to using ata_dev_classify()
instead of our own method.Cc: Tejun Heo
Cc: Dan Williams
Acked-by: Christoph Hellwig
Signed-off-by: Hannes Reinecke
Signed-off-by: Tejun Heo
17 Sep, 2014
1 commit
-
Instead of using the virt_ptr use request buffer for copying
back the nvmd response data and use the same in request function alsoSigned-off-by: Suresh Thiagarajan
Reviewed-by: Tomas Henzl
Signed-off-by: Christoph Hellwig
16 Aug, 2014
1 commit
-
Pull more SCSI changes from James Bottomley:
"This is a small set of updates which missed the first pull. It's more
msix updates, some iscsi and qla4xxx fixes, we also have some string
null termination fixes a return value fix and a couple of pm8001
firmware fixes.Just a note, we do have a couple of bug fixes coming under separate
cover, but they don't have to be part of the merge window"* tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
iscsi class: Fix freeing of skb in get host error path
scsi: fix u14-34f printk format warnings
pm8001: fix pm8001_store_update_fw
pm8001: Fix erratic calculation in update_flash
pm8001: Update MAINTAINERS list
libiscsi: return new error code when nop times out
iscsi class: fix get_host_stats return code when not supported
iscsi class: fix get_host_stats error handling
qla4xxx: fix get_host_stats error propagation
qla4xxx: check the return value of dma_alloc_coherent()
scsi: qla4xxx: ql4_mbx.c: Cleaning up missing null-terminate in conjunction with strncpy
scsi: qla4xxx: ql4_os.c: Cleaning up missing null-terminate in conjunction with strncpy
qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()
pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix()
09 Aug, 2014
1 commit
-
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches
Cc: Adam Radford
Cc: "James E.J. Bottomley"
Cc: Jayamohan Kallickal
Cc: Dario Ballabio
Cc: Michael Neuffer
Cc: "Stephen M. Cameron"
Cc: Neela Syam Kolli
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
01 Aug, 2014
2 commits
-
The current implementation may mix the negative value returned from
pm8001_set_nvmd with count. -(-ENOMEM) could be interpreted as bytes
programmed, this patch fixes it.Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
Signed-off-by: Christoph Hellwig -
The loopcount is calculated by using some weird magic. Use instead a boring
macro.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Signed-off-by: Christoph Hellwig
30 Jul, 2014
1 commit
-
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.Signed-off-by: Alexander Gordeev
Reviewed-by: Jack Wang
Signed-off-by: Christoph Hellwig
29 Jul, 2014
1 commit
-
When a call to request_irq() failed pm8001_setup_msix()
still returns the success. This udate fixes the described
misbehaviour.Signed-off-by: Alexander Gordeev
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig
26 Jul, 2014
10 commits
-
Instead of copying information to fw_control_context free it.
The task is forgotten thus also the reference to fw_control_context
and the completion thread takes the info from virt_ptr again.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Signed-off-by: Christoph Hellwig -
The driver checks the return valu, but after he tries to wait_for_completion
which might never happen. Also the ioctl buffer is freed at the end of the
function, so the first removal is not needed.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Signed-off-by: Christoph Hellwig -
ccb->fw_control_context is copied to local fw_control_context and
the local variable is never used laterFree ccb->fw_control_context. The task is forgotten thus also the
reference to fw_control_context and the completion thread takes the info
from virt_ptr again.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Signed-off-by: Christoph Hellwig -
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppche
Signed-off-by: Rickard Strandqvist
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig -
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig -
The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.
A memory leak is fixed too.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig -
Patch adds a new spinlock to protect the ccb management.
It may happen that concurrent threads become the same tag value
from the 'alloc' function', the spinlock prevents this situation.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig -
The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig -
In the driver two different functions are used to free the same resource,
this patch makes the code easier to read. In addittion to that, some
minor optimisations were made too.Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig -
During hibernation, the HBA firmware may lose power and forget the device
id info. This causes the HBA to reject IO upon resume. The fix is
to call the libsas power management routines to make the domain device
forgetful.This fixes bug 76681: https://bugzilla.kernel.org/show_bug.cgi?id=76681
Signed-off-by: Bradley Grove
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig
25 Jun, 2014
1 commit
-
The pm8001_get_phy_settings_info() function does not check
the kzalloc() return value and does not free the allocated memory.Signed-off-by: Maurizio Lombardi
Acked-by: Suresh Thiagarajan
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig
12 Jun, 2014
1 commit
-
Pull module updates from Rusty Russell:
"Most of this is cleaning up various driver sysfs permissions so we can
re-add the perm check (we unified the module param and sysfs checks,
but the module ones were stronger so we weakened them temporarily).Param parsing gets documented, and also "--" now forces args to be
handed to init (and ignored by the kernel).Module NX/RO protections get tightened: we now set them before calling
parse_args()"* tag 'modules-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux:
module: set nx before marking module MODULE_STATE_COMING.
samples/kobject/: avoid world-writable sysfs files.
drivers/hid/hid-picolcd_fb: avoid world-writable sysfs files.
drivers/staging/speakup/: avoid world-writable sysfs files.
drivers/regulator/virtual: avoid world-writable sysfs files.
drivers/scsi/pm8001/pm8001_ctl.c: avoid world-writable sysfs files.
drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.
drivers/video/fbdev/sm501fb.c: avoid world-writable sysfs files.
drivers/mtd/devices/docg3.c: avoid world-writable sysfs files.
speakup: fix incorrect perms on speakup_acntsa.c
cpumask.h: silence warning with -Wsign-compare
Documentation: Update kernel-parameters.tx
param: hand arguments after -- straight to init
modpost: Fix resource leak in read_dump()
20 May, 2014
1 commit
-
Checking return value for the memory allocattion and freeing it
while exiting the functionSigned-off-by: Viswas G
Signed-off-by: Suresh Thiagarajan
Reviewed-by: Tomas Henzl
Acked-by: Jack Wang
Signed-off-by: Christoph Hellwig
14 May, 2014
1 commit
-
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.Cc: Lindar Liu
Cc: James Bottomley
Signed-off-by: Rusty Russell
20 Mar, 2014
1 commit
-
It's a NOOP since 2.6.35 and it will be removed one day.
[jejb: remove from missed arm scsi drivers]
Signed-off-by: Michael Opdenacker
Signed-off-by: James Bottomley
16 Mar, 2014
7 commits
-
If a phy device is removed, the device can get error of I/O and HBA maybe
receieve IO_OPEN_CNX_ERROR_IT_NEXUS_LOSS of event which causes pm8001_work_fn
to reset the phy device but in pm8001_task_exec we don't assign a value for
the device field of the ccb and in other case a ccb used have device field
set, when ccb is freed the field device of the ccb don't be set NULL.So there
is possibility of getting another device reset in function mpi_ssp_completion.Signed-off-by: zhuxh
Acked-by: Lindar Liu
Signed-off-by: James Bottomley -
In function pm8001_dev_gone_notify we consume a tag from bitmap resource and
later don't free that tag resource, so the tag resource will never be
freed. In the function we don't need to use any tag to issue command for
unregistering the device .Signed-off-by: XinHong Zhu
Acked-by: Lindar Liu
Signed-off-by: James Bottomley -
spin_lock_irqsave for the HBA lock is called in one function where flag
is local to that function. Another function is called from the first
function where lock has to be released using spin_unlock_irqrestore for
calling task_done of libsas. In the second function also flag is declared
and used. For calling task_done there is no need to enable the irq. So
instead of using spin_lock_irqsave and spin_unlock_irqrestore, spin_lock
and spin_unlock is used now. This also avoids passing the flags across all
the functions where HBA lock is being used. Also removed redundant code.Reported-by: Jason Seba
Signed-off-by: Oleg Nesterov
Signed-off-by: Suresh Thiagarajan
Signed-off-by: Viswas G
Acked-by: Jack Wang
Signed-off-by: James Bottomley -
Signed-off-by: Bradley Grove
Signed-off-by: James Bottomley -
Signed-off-by: Bradley Grove
Signed-off-by: James Bottomley -
pm80xx_get_gsm_dump() was returning "1" in error case
instead of negative error value.Signed-off-by: Viswas G
Reviewed-by: Jack Wang
Reviewed-by: Tomas Henzl
Signed-off-by: James Bottomley -
Removed redundant code snippets in pm8001_hwi.c and
pm8001_ctl.cSigned-off-by: Viswas G
Reviewed-by: Jack Wang
Signed-off-by: James Bottomley
03 Dec, 2013
4 commits
-
When multiple vectors are used, the vector variable is over written,
resulting in unhandled operation for those vectors.
This fix prevents the problem by maitaining HBA instance and
vector values for each irq.[jejb: checkpatch fixes]
Signed-off-by: Nikith.Ganigarakoppal@pmcs.com
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: Jack Wang
Signed-off-by: James Bottomley -
Setting the phy state for hard reset response.
After sending hard reset for a device ,phy down event sets
the phy state to zero but for phy up event it will not set
the phy state again.This will cause problem to successive
hard resets.Signed-off-by: Nikith.Ganigarakoppal@pmcs.com
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: Jack Wang
Signed-off-by: James Bottomley -
In case of direct attached SATA device delay is not enough.
It will give crash for set device state command response and
wait_for_completion is the best solution for this.Signed-off-by: Nikith.Ganigarakoppal@pmcs.com
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: Jack Wang
Signed-off-by: James Bottomley -
Signed-off-by: Nikith.Ganigarakoppal@pmcs.com
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: Jack Wang
Signed-off-by: James Bottomley
16 Nov, 2013
1 commit
-
Pull trivial tree updates from Jiri Kosina:
"Usual earth-shaking, news-breaking, rocket science pile from
trivial.git"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (23 commits)
doc: usb: Fix typo in Documentation/usb/gadget_configs.txt
doc: add missing files to timers/00-INDEX
timekeeping: Fix some trivial typos in comments
mm: Fix some trivial typos in comments
irq: Fix some trivial typos in comments
NUMA: fix typos in Kconfig help text
mm: update 00-INDEX
doc: Documentation/DMA-attributes.txt fix typo
DRM: comment: `halve' -> `half'
Docs: Kconfig: `devlopers' -> `developers'
doc: typo on word accounting in kprobes.c in mutliple architectures
treewide: fix "usefull" typo
treewide: fix "distingush" typo
mm/Kconfig: Grammar s/an/a/
kexec: Typo s/the/then/
Documentation/kvm: Update cpuid documentation for steal time and pv eoi
treewide: Fix common typo in "identify"
__page_to_pfn: Fix typo in comment
Correct some typos for word frequency
clk: fixed-factor: Fix a trivial typo
...
25 Oct, 2013
1 commit
-
Supports below logging facilities,
Inbound outbound queues dump.
Non fatal dump in case of IO failures.
Fatal dump in case of firmware failure.[jejb: checkpatch spacing fixes]
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: Jack Wang
Signed-off-by: James Bottomley
