05 Dec, 2014
3 commits
-
The release_firmware() function was called by the mn88473_init() function even
if a previous function call "request_firmware" failed.
This implementation detail could be improved by the introduction of another
jump label.Signed-off-by: Markus Elfring
Signed-off-by: Mauro Carvalho Chehab -
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Mauro Carvalho Chehab -
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Mauro Carvalho Chehab
02 Dec, 2014
1 commit
-
Querycap shouldn't set the version field (the core does that for you),
but it should set the device_caps field.Signed-off-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Signed-off-by: Mauro Carvalho Chehab
25 Nov, 2014
1 commit
-
The omap2 media driver got removed. Remove a left-over for
tcm825x driver that were also at omap2 tree.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
22 Nov, 2014
2 commits
-
Simple style fix (checkpatch.pl: "space prohibited before that ','").
For the eudyptula challenge (http://eudyptula-challenge.org/).Signed-off-by: Christian F. Resell
Signed-off-by: Mauro Carvalho Chehab -
The omap2 camera driver and the tcm825x sensor driver have been
deprecated for a year and are now being removed. They are unmaintained
and they use an internal API that has long since been superseded by a
much better API. Worse, that internal API has been abused by out-of-kernel
trees (i.MX6).In addition, Sakari stated that these drivers have never been in a
usable state in the mainline kernel due to missing platform data.Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
Cc: David Cohen
Signed-off-by: Mauro Carvalho Chehab
15 Nov, 2014
5 commits
-
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.Reference new definitions in all media drivers residing in staging.
Signed-off-by: Boris Brezillon
Acked-by: Hans Verkuil
Acked-by: Sakari Ailus
Acked-by: Lad, Prabhakar
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Add TODO for mainlining.
Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab -
It is not ready enough to be released on mainline.
Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab -
Add TODO for mainlining.
Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab -
It is not ready enough to be released on mainline.
Signed-off-by: Antti Palosaari
Signed-off-by: Mauro Carvalho Chehab
03 Nov, 2014
3 commits
-
We can use kfifo_initialized() to check if the fifo in lirc_buffer is
initialized or not. There's no need to have a dedicated fifo status
variable in lirc_buffer.[m.chehab@samsung.com: add the same change to lirc_zilog, to avoid
breaking compilation of staging drivers]
Signed-off-by: Martin Kaiser
Signed-off-by: Mauro Carvalho Chehab -
This driver has been replaced by an rc-core driver for the same hardware.
Signed-off-by: Sean Young
Signed-off-by: Mauro Carvalho Chehab -
lirc_imon.c and lirc_sasem.c contain an incoming_packet method that
is using deprecated printk's. Removed blocks replacing with single
dev_info with a %*ph format instead.Signed-off-by: Amber Thrall
Signed-off-by: Mauro Carvalho Chehab
11 Oct, 2014
1 commit
-
Pull media updates from Mauro Carvalho Chehab:
- new IR driver: hix5hd2-ir
- the virtual test driver (vivi) was replaced by vivid, with has an
almost complete set of features to emulate most v4l2 devices and
properly test all sorts of userspace apps- the as102 driver had several bugs fixed and was properly split into a
frontend and a core driver. With that, it got promoted from staging
into mainstream- one new CI driver got added for CIMaX SP2/SP2HF (sp2 driver)
- one new frontend driver for Toshiba ISDB-T/ISDB-S demod (tc90522)
- one new PCI driver for ISDB-T/ISDB-S (pt3 driver)
- saa7134 driver got support for go7007-based devices
- added a new PCI driver for Techwell 68xx chipsets (tw68)
- a new platform driver was added (coda)
- new tuner drivers: mxl301rf and qm1d1c0042
- a new DVB USB driver was added for DVBSky S860 & similar devices
- added a new SDR driver (hackrf)
- usbtv got audio support
- several platform drivers are now compiled with COMPILE_TEST
- a series of compiler fixup patches, making sparse/spatch happier with
the media stuff and removing several warnings, especially on those
platform drivers that didn't use to compile on x86- Support for several new modern devices got added
- lots of other fixes, improvements and cleanups
* tag 'media/v3.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (544 commits)
[media] ir-hix5hd2: fix build on c6x arch
[media] pt3: fix DTV FE I2C driver load error paths
Revert "[media] media: em28xx - remove reset_resume interface"
[media] exynos4-is: fix some warnings when compiling on arm64
[media] usb drivers: use %zu instead of %zd
[media] pci drivers: use %zu instead of %zd
[media] dvb-frontends: use %zu instead of %zd
[media] s5p-mfc: Fix several printk warnings
[media] s5p_mfc_opr: Fix warnings
[media] ti-vpe: Fix typecast
[media] s3c-camif: fix dma_addr_t printks
[media] s5p_mfc_opr_v6: get rid of warnings when compiled with 64 bits
[media] s5p_mfc_opr_v5: Fix lots of warnings on x86_64
[media] em28xx: Fix identation
[media] drxd: remove a dead code
[media] saa7146: remove return after BUG()
[media] cx88: remove return after BUG()
[media] cx88: fix cards table CodingStyle
[media] radio-sf16fmr2: declare some structs as static
[media] radio-sf16fmi: declare pnp_attached as static
...
03 Oct, 2014
4 commits
-
The following patch fixes the checkpatch.pl warning:
drivers/staging/media/omap4iss/iss_csi2.c:811 warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu
Signed-off-by: Greg Kroah-Hartman -
The following patch fixes the checkpatch.pl warning:
drivers/staging/media/omap4iss/iss_ipipe.c:184 warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu
Signed-off-by: Greg Kroah-Hartman -
This patch merges two lines and removes a variable that becomes unused
after merging.Signed-off-by: Mahati Chamarthy
Signed-off-by: Greg Kroah-Hartman -
This reverts commit 7b86477c0e5b7b1406f27da519d4df841f306b92.
It was broken and broke the build :(
Reported-by: kbuild test robot
Reported-by: Stephen Rothwell
Cc: Tapasweni Pathak
Signed-off-by: Greg Kroah-Hartman
29 Sep, 2014
9 commits
-
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning iss_resizer.cSigned-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman -
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning iss_ipipeif.cSigned-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman -
This patch fixes "Missing a blank line after declarations" checkpatch.pl
warning in tcm825x.cSigned-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman -
This patch fixes "Missing a blank line after declarations" checkpatch.pl
warning in omap24xxcam-dma.cSigned-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman -
This patch fixes checkpatch.pl warning in file cxd2099.c
WARNING : msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txtSigned-off-by: Tapasweni Pathak
Signed-off-by: Greg Kroah-Hartman -
This patch removes a variable which has never been used. The following
Coccinelle semantic patch was used to make this transformation:@@
type T;
identifier i;
constant C;
@@- T i;
Signed-off-by: Mahati Chamarthy
Acked-by: Julia Lawall
Signed-off-by: Greg Kroah-Hartman -
The following patch removes the checkpatch.pl warning:
WARNING: possible unnecessary out of memory message.Signed-off-by: Heena Sirwani
Signed-off-by: Greg Kroah-Hartman -
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning lirc_parallel.cSigned-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman -
This patch fixes checkpatch.pl warning in files of media/lirc
WARNING : Missing a blank line after declarationsSigned-off-by: Tapasweni Pathak
Signed-off-by: Greg Kroah-Hartman
24 Sep, 2014
8 commits
-
This fixes the following checkpatch.pl warning:
WARNING: else is not generally useful after a break or returnSigned-off-by: Mahati Chamarthy
Signed-off-by: Greg Kroah-Hartman -
This patch merges an assignment with an immediately following return of
the assigned variable. It also removes a variable that becomes unused due to this transformation.
The following Coccinelle semantic patch was used to make this transformation:@r@
identifier ret;
identifier f;
@@-ret =
+return
f(...);
-return ret;@@
identifier r.ret;
expression e1;
type t;
@@(
-t ret = e1;
|
-t ret;
)
... when != ret
when strictSigned-off-by: Mahati Chamarthy
Acked-by: Julia Lawall
Signed-off-by: Greg Kroah-Hartman -
We call kfree(data_buf) in the error handling and that will oops if this
is an error pointer.Signed-off-by: Dan Carpenter
Signed-off-by: Mauro Carvalho Chehab -
This patch fixes checkpatch.pl warning in lirc_serial.c file
WARNING : break is not useful after goto or returnSigned-off-by: Tapasweni Pathak
Signed-off-by: Greg Kroah-Hartman -
This patch fixes checkpatch.pl warning in file lirc_serial.c
WARNING : else is not generally useful after a break or returnSigned-off-by: Tapasweni Pathak
Signed-off-by: Greg Kroah-Hartman -
This patch fixes "quoted string split across lines" checkpatch.pl
warning in lirc_imon.c.Signed-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman -
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
iss_video.cSigned-off-by: Gulsah Kose
Acked-by: Daniel Baluta
Signed-off-by: Greg Kroah-Hartman -
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
iss_csi2.cSigned-off-by: Gulsah Kose
Acked-by: Daniel Baluta
Signed-off-by: Greg Kroah-Hartman
20 Sep, 2014
3 commits
-
Fix checkpatch.pl issues with missing a blank
line after declarations in cxd2099.cSigned-off-by: Aybuke Ozdemir
Signed-off-by: Greg Kroah-Hartman -
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
lirc_serial.cSigned-off-by: Gulsah Kose
Reviewed-by: Josh Triplett .
Signed-off-by: Greg Kroah-Hartman -
This patch fixes "void function return statements are not generally
useful" checkpatch.pl warning in lirc_zilog.cSigned-off-by: Gulsah Kose
Signed-off-by: Greg Kroah-Hartman
