24 Mar, 2019
2 commits
-
Fixed CID 3411368, Unsigned compared against 0. Removed comparison with
no effect.Signed-off-by: Oliver Brown
(cherry picked from commit 7a90cb82d00109cdd00eea67fbf9d75b6efe6172) -
Fix Covertity CID 18110 Uninitialized scalar variable
Signed-off-by: Oliver Brown
(cherry picked from commit 0f2a05c5cef95dabdbdd1e78531cd42aec24876a)
18 Feb, 2019
1 commit
-
Unlock hw_lock before calling v4l2_m2m_job_finish to avoid deadlock:
v4l2_m2m_job_finish -> v4l2_m2m_try_schedule -> job_ready locks hw_lock
v4l2_m2m_job_finish -> v4l2_m2m_try_run -> device_run locks hw_lockSigned-off-by: Mirela Rabulea
Reviewed-by: Laurentiu Palcu
14 Feb, 2019
4 commits
-
For the number of requested source buffer, driver need one at least.
For the number of requested destination buffer, driver need three at least.Signed-off-by: Guoniu.Zhou
(cherry picked from commit c3d33d6ad971b2e03c034e14696d64549245f918) -
Fix potential dead lock issue
Signed-off-by: Guoniu.Zhou
(cherry picked from commit 322beb5215ea921dd30c0974cd17465de306927b) -
Refer to ISI validataion code, there is no need to enable ISI
mem2mem read done interrupt and driver can handle buffers in
frame received interrupt serviceRemove 50ms delay when enable ISI AXI read, it will improve
performance obviouslySigned-off-by: Guoniu.Zhou
(cherry picked from commit bdabe035cd5c57d713f824e61f120213ed9357ba) -
Checking parameters from userspace befor applying for different format
Signed-off-by: Guoniu.Zhou
(cherry picked from commit 47ff54238f138be015756a45afb0af58b52e5a02)
12 Feb, 2019
33 commits
-
Make sure V4L2_EVENT_SOURCE_CHANGE is only sent at init phase.
It was wrongly sent for every frame, causing gst-launch to DQBUF
only for the first frame.Removed a dev_dbg from mxc_jpeg_try_fmt, too many prints with gst.
Fix for "Driver bug detected, stride (%d) is too small for the width (%d)"
warning in gst-launch. Fixed by providing the stride in bytesperline, in
mxc_jpeg_g_fmt_vid_cap function.Clean-up in mxc_jpeg_qbuf.
Tested with gst-launch and v4l2video0jpegdec plugin:
gst-launch-1.0 filesrc location=mjpeg_64x64_4frames.avi ! jpegparse
! v4l2video0jpegdec ! waylandsinkSigned-off-by: Mirela Rabulea
-
Add notify_eos function to enqueue V4L2_EVENT_EOS for the application.
Call notify_eos after V4L2_DEC_CMD_STOP was received,
or, if there still are source buffers to process, later in dqbuf.
Add mxc_jpeg_dqbuf and send V4L2_EVENT_EOS if needed.Fix for "Driver should never set v4l2_buffer.field to ANY" warning in
gst-launch, by setting V4L2_FIELD_NONE in mxc_jpeg_dqbuf.Tested with gst-launch and v4l2video0jpegdec plugin:
gst-launch-1.0 filesrc location= ! jpegparse ! v4l2video5jpegdec
! waylandsinkSigned-off-by: Mirela Rabulea
-
Android has RGBA format output but V4L2 framework do not have this format
.In order to support this in our mem2mem driver, we need to extend V4L2
format.Signed-off-by: Guoniu.Zhou
-
OV10635_15_FPS/OV10635_30_FPS should be set to 0/1.
to_ov10635_frame_rate is used by ov10635_mode_info_data.
the size of ov10635_mode_info_data is 2.Change-Id: Ie2f19fd4332cd7b59cfdec5acbaa0b595dcf2f46
Signed-off-by: zhang sanshan -
fix potential dereferencing null pointer
Signed-off-by: Guoniu.Zhou
-
Driver does not get the return value of function but the value
as the condition of if statement. It will never true, so fix itSigned-off-by: Guoniu.Zhou
-
Because the address of an object is never null and the if
statement will never true so remove the dead codeSigned-off-by: Guoniu.Zhou
-
fix overwriting to previous value
Signed-off-by: Guoniu.Zhou
-
Because the address of an object is never null and the if
statement will never true so remove the dead codeSigned-off-by: Guoniu.Zhou
-
The variable maybe unassigned but used by function ,so fix potential
uninitialized scalar variableSigned-off-by: Guoniu.Zhou
-
fix unsigned compared against zero, it will no effect
Signed-off-by: Guoniu.Zhou
-
Return int from get_sof (-1 for error), the result is later on
compared with -1 literal.Fix memory leak from print_nbuf_to_eoi, when !mxc_jpeg_tracing.
Signed-off-by: Mirela Rabulea
Reviewed-by: Robert Chiras -
Check camera's running state before suspend for imx8qm/qxp
and don't support suspend when camera's runningSigned-off-by: Guoniu.Zhou
-
The reset pin of ov5640 will power down when system suspend and
it will lead to reset ov5640, so driver need to reinitialize the
sensor before streamingSigned-off-by: Guoniu.Zhou
-
sensors connected is less than the required in dtb
1. create links between entities when the number of sensors
connected is less than the required in dtb
2. unregister the video device which sensors are not connectedSigned-off-by: Guoniu.Zhou
(cherry picked from commit 33234cc31362b5ee23be34ce2a00947e0dc96acb) -
Add QVGA @30fps support for ov5640
Signed-off-by: Robby Cai
-
Add hdmi rx cec running status.
Signed-off-by: Sandor Yu
-
Fix incorrect function return variable type.
Signed-off-by: Sandor Yu
-
Print hdmi rx video mode info.
use dev_xxx instead of pr_xxx in mxc-hdmi-hw.c.Signed-off-by: Sandor Yu
-
The context is released after FRM_DONE interrupt is received,
but for some small images, after FRM_DONE, a HALF_BUF interrupt
keeps coming, and cannot be cleared.
A soft reset helps (resets only the decoder internal state, not registers).Signed-off-by: Mirela Rabulea
-
Register setting for ov5640 30fps is the same with 15fps, so
correct itSigned-off-by: Guoniu.Zhou
-
Add debug function print_nbuf_to_eoi, to print the decoder input frame.
Add module parameter mxc_jpeg_tracing.Signed-off-by: Mirela Rabulea
Reviewed-by: Laurentiu Palcu -
Set allow_zero_bytesused, to let gst-launch work, this lead to the need
to implement V4L2_DEC_CMD_STOP, dummy for now.Implement g_fmt_vid_cap, called by gst-launch before queuing any capture
buffers, this also required some fixes in jpeg_parse and buf_queue,
which wrongly assumed capture buffers are enqueued before output buffers.
So, import the resolution and pixel-format from the output queue,
if the capture queue is not set-up yet.Add release_active_buffers and use it in stop_streaming to properly
clean-up active buffers, this fixes warning at gst-launch stop with Ctrl+CCheck for decoding/encoding error in interrupt handler and print CAST IP
error status, found some yuv422 images with errors in SOS marker.Partially implemented subscribe_event, V4L2_EVENT_EOS is not working yet,
will be addressed in a subsequent fix.Signed-off-by: Mirela Rabulea
Reviewed-by: Laurentiu Palcu -
Driver does not free memory when it's removed or encounter
an error in probe. So fix potential memory leaks.Signed-off-by: Guoniu.Zhou
-
Add hardware reset for max9286 before initialization
Signed-off-by: Guoniu.Zhou
-
Added hdmi cable plugin status check in v4l2 api function.
Signed-off-by: Sandor Yu
-
Add QVGA resolution support for mipi ov5640
Signed-off-by: Guoniu.Zhou
-
If camera is not connected and user try to use mem2mem function,
driver will return error but isi channel0 reference counter is
still increased by one. This will lead to mem2mem driver return
EBUSY error when user open mem2mem device, so correct this bug
in this patch.Signed-off-by: Guoniu.Zhou
-
Enable global alpha insertion for memory to memory function
of ISISigned-off-by: Guoniu.Zhou
-
Enable global alpha insertion feature for camera
Signed-off-by: Guoniu.Zhou
-
Eanble horizonal and vertical flip for memory to memory function
of ISISigned-off-by: Guoniu.Zhou
-
Enable horizonal and vertical flip for camera image
Signed-off-by: Guoniu.Zhou
-
Correct color mapping between V4L2 and ISI
Signed-off-by: Guoniu.Zhou
