Eric Lee / smarc-fsl-linux-kernel

31 Mar, 2011

1 commit

  • 04f482faf   connector: convert to synchronous netlink message processing ... Browse Code »

    Commits 01a16b21 (netlink: kill eff_cap from struct netlink_skb_parms)
    and c53fa1ed (netlink: kill loginuid/sessionid/sid members from struct
    netlink_skb_parms) removed some members from struct netlink_skb_parms
    that depend on the current context, all netlink users are now required
    to do synchronous message processing.

    connector however queues received messages and processes them in a work
    queue, which is not valid anymore. This patch converts connector to do
    synchronous message processing by invoking the registered callback handler
    directly from the netlink receive function.

    In order to avoid invoking the callback with connector locks held, a
    reference count is added to struct cn_callback_entry, the reference
    is taken when finding a matching callback entry on the device's queue_list
    and released after the callback handler has been invoked.

    Signed-off-by: Patrick McHardy
    Acked-by: Evgeniy Polyakov
    Signed-off-by: David S. Miller

    Patrick McHardy
     

24 Feb, 2011

1 commit

25 Oct, 2010

1 commit

  • 6cebb17be   connector: remove lazy workqueue creation ... Browse Code »

    Commit 1a5645bc (connector: create connector workqueue only while
    needed once) implements lazy workqueue creation for connector
    workqueue. With cmwq now in place, lazy workqueue creation doesn't
    make much sense while adding a lot of complexity. Remove it and
    allocate an ordered workqueue during initialization.

    This also removes a call to flush_scheduled_work() which is deprecated
    and scheduled to be removed.

    Signed-off-by: Tejun Heo
    Cc: Frederic Weisbecker
    Signed-off-by: David S. Miller

    Tejun Heo
     

03 Oct, 2009

3 commits

24 Jul, 2009

1 commit

22 Jul, 2009

1 commit

18 Jul, 2009

1 commit

  • 0741241c6   connector: make callback argument type explicit ... Browse Code »

    The connector documentation states that the argument to the callback
    function is always a pointer to a struct cn_msg, but rather than encode it
    in the API itself, it uses a void pointer everywhere. This doesn't make
    much sense to encode the pointer in documentation as it prevents proper C
    type checking from occurring and can easily allow people to use the wrong
    pointer type. So convert the argument type to an explicit struct cn_msg
    pointer.

    Signed-off-by: Mike Frysinger
    Signed-off-by: David S. Miller

    Mike Frysinger
     

03 Feb, 2009

1 commit

  • 1a5645bc9   connector: create connector workqueue only while needed once ... Browse Code »

    The netlink connector uses its own workqueue to relay the datas sent
    from userspace to the appropriate callback. If you launch the test
    from Documentation/connector and change it a bit to send a high flow
    of data, you will see thousands of events coming to the "cqueue"
    workqueue by looking at the workqueue tracer.

    This flow of events can be sent very quickly. So, to not encumber the
    kevent workqueue and delay other jobs, the "cqueue" workqueue should
    remain.

    But this workqueue is pointless most of the time, it will always be
    created (assuming you have built it of course) although only
    developpers with specific needs will use it.

    So avoid this "most of the time useless task", this patch proposes to
    create this workqueue only when needed once. The first jobs to be
    sent to connector callbacks will be sent to kevent while the "cqueue"
    thread creation will be scheduled to kevent too.

    The following jobs will continue to be scheduled to keventd until the
    cqueue workqueue is created, and then the rest of the jobs will
    continue to perform as usual, through this dedicated workqueue.

    Each time I tested this patch, only the first event was sent to
    keventd, the rest has been sent to cqueue which have been created
    quickly.

    Also, this patch fixes some trailing whitespaces on the connector files.

    Signed-off-by: Frederic Weisbecker
    Acked-by: Evgeniy Polyakov
    Signed-off-by: David S. Miller

    Frederic Weisbecker
     

24 Mar, 2008

1 commit

29 Jan, 2008

2 commits

  • 6e32814bc   [CONNECTOR]: Cleanup struct cn_callback_entry ... Browse Code »

    - 'cb' is a fake struct member. In a previous patch struct cn_callback
    was renamed to cn_callback_id, so 'cb' should have been deleted at that
    time.

    - 'nls' isn't used and is redundant, we can retrieve this data through
    cn_callback_entry.pdev->nls.

    - 'seq' and 'group' should be u32, as they are declared to be u32 in
    other places.

    Signed-off-by: Li Zefan
    Signed-off-by: David S. Miller

    Li Zefan
     
  • 96a899655   [CONNECTOR]: Cleanup struct cn_queue_dev ... Browse Code »

    Struct member netlink_groups is never used, and I don't see how it can
    be useful.

    Signed-off-by: Li Zefan
    Signed-off-by: David S. Miller

    Li Zefan
     

09 Jan, 2008

1 commit

18 Dec, 2006

1 commit

22 Nov, 2006

1 commit

18 Jun, 2006

1 commit

  • cec6f7f39   [CONNECTOR]: Fix warning in cn_queue.c ... Browse Code »

    cn_queue.c:130: warning: value computed is not used

    There is no point in testing the atomic value if the result is thrown
    away.

    From Evgeniy:

    It was created to put implicit smp barrier, but it is not needed there.

    Signed-off-by: Andreas Schwab
    Signed-off-by: Evgeniy Polyakov
    Signed-off-by: David S. Miller

    Andreas Schwab
     

27 Sep, 2005

1 commit

  • acd042bb2   [CONNECTOR]: async connector mode. ... Browse Code »

    If input message rate from userspace is too high, do not drop them,
    but try to deliver using work queue allocation.

    Failing there is some kind of congestion control.

    It also removes warn_on on this condition, which scares people.

    Signed-off-by: Evgeniy Polyakov
    Signed-off-by: David S. Miller

    Evgeniy Polyakov
     

12 Sep, 2005

1 commit

  • 7672d0b54   [NET]: Add netlink connector. ... Browse Code »

    Kernel connector - new userspace kernel space easy to use
    communication module which implements easy to use bidirectional
    message bus using netlink as it's backend. Connector was created to
    eliminate complex skb handling both in send and receive message bus
    direction.

    Connector driver adds possibility to connect various agents using as
    one of it's backends netlink based network. One must register
    callback and identifier. When driver receives special netlink message
    with appropriate identifier, appropriate callback will be called.

    From the userspace point of view it's quite straightforward:

    socket();
    bind();
    send();
    recv();

    But if kernelspace want to use full power of such connections, driver
    writer must create special sockets, must know about struct sk_buff
    handling... Connector allows any kernelspace agents to use netlink
    based networking for inter-process communication in a significantly
    easier way:

    int cn_add_callback(struct cb_id *id, char *name, void (*callback) (void *));
    void cn_netlink_send(struct cn_msg *msg, u32 __groups, int gfp_mask);

    struct cb_id
    {
    __u32 idx;
    __u32 val;
    };

    idx and val are unique identifiers which must be registered in
    connector.h for in-kernel usage. void (*callback) (void *) - is a
    callback function which will be called when message with above idx.val
    will be received by connector core.

    Using connector completely hides low-level transport layer from it's
    users.

    Connector uses new netlink ability to have many groups in one socket.

    [ Incorporating many cleanups and fixes by myself and
    Andrew Morton -DaveM ]

    Signed-off-by: Evgeniy Polyakov
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Evgeniy Polyakov