13 Jan, 2012

1 commit

  • Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE
    tables.

    Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const
    and marked as __devinitconst.

    This also fixes some warnings from checkpatch:
    e.g.
    WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
    #1096: FILE: i2c/busses/i2c-intel-mid.c:1096:
    +static struct pci_device_id intel_mid_i2c_ids[] = {

    Signed-off-by: Axel Lin
    Cc: Rudolf Marek
    Cc: Ben Dooks
    Acked-by: Olof Johansson
    Cc: "Mark M. Hoffman"
    Acked-by: Dirk Brandewie
    Cc: Tomoya MORINAGA
    Acked-by: Wolfram Sang
    Cc: Feng Tang
    Cc: Sebastian Andrzej Siewior
    Signed-off-by: Jean Delvare

    Axel Lin
     

31 Mar, 2011

1 commit


15 Dec, 2010

1 commit

  • This gets caught by the new sanity check code. Instead of the slash use a
    different symbol. This was originally found by Major Lee who proposed a
    rather more complex patch which changed the name according to the chip
    type.

    On the basis that we are in a late -rc and making Linus grumpy isn't always
    a good idea (however fun) this is a simple alternative.

    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Alan Cox
     

28 Oct, 2010

1 commit

  • (Updated to address Ben's comments. With regard to the message segment
    restriction it's not something we hit on the actual platform so while
    I will investigate that further I don't think its a blocker to submission.
    At worst its a spot over-restrictive)

    From: Wen Wang

    Initial release of the driver. Updated and verified on hardware.

    Cleaned up as follows

    Alan Cox:
    Squash down the switches into tables, and use the PCI ident field. We
    could perhaps take this further and put the platform and port number into
    this.
    uint32t -> u32
    bracketing of case statements
    spacing and '!' usage
    Check the speed (which is now 0/1/2) is valid and ignore otherwise.
    Fix remaining problems/suggestions from Jean's review
    Fix items from Ben's review

    Arjan van de Ven:
    Initial power management hooks

    Yong Wang :
    Shared IRQ support

    Wen Wang :
    D3 support
    Fixes for OCT test runs
    Interrupt optimisations

    Hong Liu
    The runtime PM code is working on the wrong device (i2c_adapter->dev).
    The correct one should be pci_dev->dev. This breaks attached i2c
    slave devices with runtime PM enabled. Slave device needs to runtime
    resume parent device before runtime resuming itself, but we always get
    error since we don't have pm_runtime callback for i2c_adapter->dev.

    Bin Yang :
    Update speed table

    Saadi Maalem :
    Clear all interrupts in the hardware init

    Celine Chotard :
    Correct ordering of clear/disable of IRQs

    Signed-off-by: Wen Wang
    Signed-off-by: Yong Wang
    Signed-off-by: Hong Liu
    Signed-off-by: Bin Yang
    Signed-off-by: Arjan van de Ven
    Signed-off-by: Alan Cox
    Signed-off-by: Ben Dooks

    Alan Cox