Eric Lee / smarc-fsl-linux-kernel

13 Jan, 2012

1 commit

01 Nov, 2011

1 commit

23 Nov, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

28 Jan, 2010

1 commit

27 Aug, 2009

1 commit

  • 15b8dd53f   ACPICA: Major update for acpi_get_object_info external interface ... Browse Code »

    Completed a major update for the acpi_get_object_info external interface.
    Changes include:
    - Support for variable, unlimited length HID, UID, and CID strings
    - Support Processor objects the same as Devices (HID,UID,CID,ADR,STA, etc.)
    - Call the _SxW power methods on behalf of a device object
    - Determine if a device is a PCI root bridge
    - Change the ACPI_BUFFER parameter to ACPI_DEVICE_INFO.
    These changes will require an update to all callers of this interface.
    See the ACPICA Programmer Reference for details.

    Also, update all invocations of acpi_get_object_info interface

    Signed-off-by: Bob Moore
    Signed-off-by: Lin Ming
    Signed-off-by: Len Brown

    Bob Moore
     

30 Jun, 2009

1 commit

  • 2bf427b25   ide: fix resume for CONFIG_BLK_DEV_IDEACPI=y ... Browse Code »

    commit 2f0d0fd2a605666d38e290c5c0d2907484352dc4 ("ide-acpi: cleanup
    do_drive_get_GTF()") didn't account for the lack of hwif->acpidata
    check in generic_ide_suspend() [ indirect user of do_drive_get_GTF()
    through ide_acpi_exec_tfs() ] resulting in broken resume when ACPI
    support is enabled but ACPI data is unavailable.

    Fix it by adding ide_port_acpi() helper for checking if port needs
    ACPI handling and cleaning generic_ide_{suspend,resume}() to use it
    instead of hiding hwif->acpidata and ide_noacpi checks in IDE ACPI
    helpers (this should help in preventing similar bugs in the future).

    While at it:
    - kill superfluous debugging printks in ide_acpi_{get,push}_timing()

    Reported-and-tested-by: Etienne Basset
    Also-reported-and-tested-by: Jeff Chua
    Signed-off-by: Bartlomiej Zolnierkiewicz
    Signed-off-by: David S. Miller

    Bartlomiej Zolnierkiewicz
     

08 Apr, 2009

2 commits

  • 745483f10   ide: simplify 'struct ide_taskfile' ... Browse Code »

    Make 'struct ide_taskfile' cover only 8 register values and thus put two such
    fields ('tf' and 'hob') into 'struct ide_cmd', dropping unnecessary 'tf_array'
    field from it.

    This required changing the prototype of ide_get_lba_addr() and ide_tf_dump().

    Signed-off-by: Sergei Shtylyov
    [bart: fix setting of ATA_LBA bit for LBA48 commands in __ide_do_rw_disk()]
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Sergei Shtylyov
     
  • 60f85019c   ide: replace IDE_TFLAG_* flags by IDE_VALID_* ... Browse Code »

    Replace IDE_TFLAG_{IN|OUT}_* flags meaning to the taskfile register validity on
    input/output by the IDE_VALID_* flags and introduce 4 symmetric 8-bit register
    validity indicator subfields, 'valid.{input/output}.{tf|hob}', into the 'struct
    ide_cmd' instead of using the 'tf_flags' field for that purpose (this field can
    then be turned from 32-bit into 8-bit one).

    Signed-off-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Sergei Shtylyov
     

27 Mar, 2009

1 commit

  • 22aa4b32a   ide: remove ide_task_t typedef ... Browse Code »

    While at it:
    - rename struct ide_task_s to struct ide_cmd
    - remove stale comments from idedisk_{read_native,set}_max_address()
    - drop unused 'cmd' argument from ide_{cmd,task}_ioctl()
    - drop unused 'task' argument from tx4939ide_tf_load_fixup()
    - rename ide_complete_task() to ide_complete_cmd()
    - use consistent naming for struct ide_cmd variables

    There should be no functional changes caused by this patch.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

25 Mar, 2009

7 commits

03 Feb, 2009

1 commit

09 Jan, 2009

1 commit

07 Jan, 2009

3 commits

  • 2bd24a1cf   ide: add port and host iterators ... Browse Code »

    Add ide_port_for_each_dev() / ide_host_for_each_port() iterators
    and update IDE code to use them.

    While at it:
    - s/unit/i/ variable in ide_port_wait_ready(), ide_probe_port(),
    ide_port_tune_devices(), ide_port_init_devices_data(), do_reset1(),
    ide_acpi_set_state() and scc_dma_end()
    - s/d/i/ variable in ide_proc_port_register_devices()

    There should be no functional changes caused by this patch.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • 5e7f3a466   ide: dynamic allocation of device structures ... Browse Code »

    Allocate device structures dynamically instead of having them embedded
    in ide_hwif_t:

    * Remove needless zeroing of port structure from ide_init_port_data().

    * Add ide_hwif_t.devices[MAX_DRIVES] (table of pointers to the devices).

    * Add ide_port_{alloc,free}_devices() helpers and use them respectively
    in ide_{host,free}_alloc().

    * Convert all users of ->drives[] to use ->devices[] instead.

    While at it:

    * Use drive->dn for the slave device check in scc_pata.c.

    As a nice side-effect this patch cuts ~1kB (x86-32) from the resulting
    code size:

    text data bss dec hex filename
    53963 1244 237 55444 d894 drivers/ide/ide-core.o.before
    52981 1244 237 54462 d4be drivers/ide/ide-core.o.after

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • 898ec223f   ide: remove HWIF() macro ... Browse Code »

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

31 Dec, 2008

1 commit

30 Dec, 2008

1 commit

  • 0e63a588f   ide: fix IDE ACPI regression breaking suspend ... Browse Code »

    Commit 4dde4492d850a4c9bcaa92e5bd7f4eebe3e2f5ab ("ide: make drive->id
    an union (take 2)") accidentally introduced an IDE ACPI regression which
    at least on some machines confuses ACPI and breaks suspend. Fix it.

    Fixes kernel.org bug #12279:
    http://bugzilla.kernel.org/show_bug.cgi?id=12279

    [ Sorry about the bug (IDE ACPI is not used by default so it managed
    to slip in). Still it is kind of surprising that the bug breaks
    suspend as it shouldn't impact anything except IDE ACPI (it seems
    that it uncovered either some ACPI/PM deficiency or a BIOS bug). ]

    Reported-and-bisected-by: David Roka
    Tested-by: David Roka
    Cc: Rafael J. Wysocki
    Cc: Len Brown
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

14 Oct, 2008

1 commit

  • 97100fc81   ide: add device flags ... Browse Code »

    Add 'unsigned long dev_flags' to ide_drive_t and convert bitfields
    to IDE_DFLAG_* flags.

    While at it:
    - IDE_DFLAG_ADDRESSING -> IDE_DFLAG_LBA48
    - fixup some comments
    - remove needless g->flags zeroing from ide*_probe()

    There should be no functional changes caused by this patch.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

11 Oct, 2008

1 commit

  • 4dde4492d   ide: make drive->id an union (take 2) ... Browse Code »

    Make drive->id an unnamed union so id can be accessed either by using
    'u16 *id' or 'struct hd_driveid *driveid'. Then convert all existing
    drive->id users accordingly (using 'u16 *id' when possible).

    This is an intermediate step to make ide 'struct hd_driveid'-free.

    While at it:

    - Add missing KERN_CONTs in it821x.c.

    - Use ATA_ID_WORDS and ATA_ID_*_LEN defines.

    - Remove unnecessary checks for drive->id.

    - s/drive_table/table/ in ide_in_drive_list().

    - Cleanup ide_config_drive_speed() a bit.

    - s/drive1/dev1/ & s/drive0/dev0/ in ide_undecoded_slave().

    v2:
    Fix typo in drivers/ide/ppc/pmac.c. (From Stephen Rothwell)

    There should be no functional changes caused by this patch.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

16 Jul, 2008

1 commit

27 Apr, 2008

2 commits

18 Apr, 2008

1 commit

06 Feb, 2008

1 commit

03 Feb, 2008

3 commits

02 Feb, 2008

1 commit

  • 58f189fcc   ide: delete filenames/versions from comments ... Browse Code »

    Delete filenames/versions from comments.

    I'm leaving decisions about adding DRV_VERSION defines and MODULE_VERSION()-s
    to maintainers of the respective drivers.

    While at it:

    * Remove unused VERSION define from ide.c.

    * Remove unused/stale DRV_VERSION define from au1xxx-ide.c.

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

27 Jan, 2008

1 commit

26 Jan, 2008

3 commits

  • a3bbb9d88   ide: remove unnecessary writes to HOB taskfile registers ... Browse Code »

    * Set taskfile flags for REQ_TYPE_ATA_TASKFILE requests before
    adding the request to the queue.

    * Cleanup execute_drive_cmd().

    * Remove unnecessary writes to HOB taskfile registers when using
    LBA48 disk for the following cases:

    - Power Management requests
    (WIN_FLUSH_CACHE[_EXT], WIN_STANDBYNOW1, WIN_IDLEIMMEDIATE commands)

    - special commands (WIN_SPECIFY, WIN_RESTORE, WIN_SETMULT)

    - Host Protected Area support (WIN_READ_NATIVE_MAX, WIN_SET_MAX)

    - /proc/ide/ SMART support (WIN_SMART with SMART_ENABLE,
    SMART_READ_VALUES and SMART_READ_THRESHOLDS subcommands)

    - write cache enabling/disabling in ide-disk
    (WIN_SETFEATURES with SETFEATURES_{EN,DIS}_WCACHE)

    - write cache flushing in ide-disk (WIN_FLUSH_CACHE[_EXT])

    - acoustic management in ide-disk
    (WIN_SETFEATURES with SETFEATURES_{EN,DIS}_AAM)

    - door (un)locking in ide-disk (WIN_DOORLOCK, WIN_DOORUNLOCK)

    - /proc/ide/hd?/identify support (WIN_IDENTIFY)

    - ACPI _GTF taskfiles

    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • 9a3c49be5   ide: add ide_no_data_taskfile() helper ... Browse Code »

    * Add ide_no_data_taskfile() helper and convert ide_raw_taskfile() w/ NO DATA
    protocol users to use it instead.

    * Set ->data_phase explicitly in ide_no_data_taskfile()
    (TASKFILE_NO_DATA is defined as 0x0000).

    * Unexport task_no_data_intr().

    Acked-by: Sergei Shtylyov
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     
  • 650d841d9   ide: add struct ide_taskfile (take 2) ... Browse Code »

    * Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7]
    in idedisk_set_max_address_ext().

    * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister[]
    and hobRegister[].

    * Remove no longer needed IDE_CONTROL_OFFSET_HOB define.

    * Add #ifndef/#endif __KERNEL__ around definitions of {task,hob}_struct_t.

    While at it:

    * Use ATA_LBA define for LBA bit (0x40) as suggested by Tejun Heo.

    v2:
    * Add missing newlines. (Noticed by Sergei)

    * Use ~ATA_LBA instead of 0xBF. (Noticed by Sergei)

    * Use unnamed unions for error/feature and status/command.
    (Suggested by Sergei).

    There should be no functionality changes caused by this patch.

    Acked-by: Sergei Shtylyov
    Cc: Tejun Heo
    Signed-off-by: Bartlomiej Zolnierkiewicz

    Bartlomiej Zolnierkiewicz
     

12 Jan, 2008

1 commit