Eric Lee / smarc-fsl-linux-kernel

02 Nov, 2010

1 commit

  • b595076a1   tree-wide: fix comment/printk typos ... Browse Code »

    "gadget", "through", "command", "maintain", "maintain", "controller", "address",
    "between", "initiali[zs]e", "instead", "function", "select", "already",
    "equal", "access", "management", "hierarchy", "registration", "interest",
    "relative", "memory", "offset", "already",

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     

08 Jul, 2010

2 commits

18 Apr, 2010

1 commit

  • b91ecb002   gigaset: include cleanup cleanup ... Browse Code »

    Commit 5a0e3ad causes slab.h to be included twice in many of the
    Gigaset driver's source files, first via the common include file
    gigaset.h and then a second time directly. Drop the spares, and
    use the opportunity to clean up a few more similar cases.

    Impact: cleanup, no functional change
    Signed-off-by: Tilman Schmidt
    CC: Tejun Heo
    Acked-by: Tejun Heo
    Signed-off-by: David S. Miller

    Tilman Schmidt
     

26 Feb, 2010

1 commit

  • 1528b18f7   gigaset: reduce syslog clutter ... Browse Code »

    Improve readability of the Gigaset driver's kernel messages by
    removing a few unnecessary messages and limiting the emission
    of some debug messages more narrowly.

    Impact: logging
    Signed-off-by: Tilman Schmidt
    Signed-off-by: David S. Miller

    Tilman Schmidt
     

20 Nov, 2009

1 commit

  • 5452fee23   drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg ... Browse Code »

    Changed function pointer use from non-majority address-of style
    to majority short form without & via:

    grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
    perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
    done

    Compile tested allyesconfig x86

    Signed-off-by: Joe Perches

    drivers/isdn/gigaset/bas-gigaset.c | 4 ++--
    drivers/isdn/gigaset/common.c | 2 +-
    drivers/isdn/gigaset/interface.c | 2 +-
    drivers/isdn/gigaset/ser-gigaset.c | 2 +-
    drivers/isdn/gigaset/usb-gigaset.c | 2 +-
    5 files changed, 6 insertions(+), 6 deletions(-)
    Signed-off-by: David S. Miller

    Joe Perches
     

29 Oct, 2009

1 commit

  • 2032e2c23   usb_gigaset: code cleanup ... Browse Code »

    Reorganize the code of the Gigaset M10x driver to make it more
    readable, less redundant, better aligned to the style of other
    parts of the driver, and cause fewer checkpatch.pl complaints.

    Impact: code reorganization, no functional change
    Signed-off-by: Tilman Schmidt
    Signed-off-by: David S. Miller

    Tilman Schmidt
     

18 May, 2009

1 commit

  • b88bd9565   gigaset: remove UNDOCREQ config option ... Browse Code »

    Drop the kernel config option GIGASET_UNDOCREQ, permanently
    activating the code it controlled, as there have been no reports
    of problems caused by its activation but many problems caused by
    it being disabled.
    Also fix a few bad comments while we're at it.

    Impact: cleanup
    Signed-off-by: Tilman Schmidt
    Signed-off-by: David S. Miller

    Tilman Schmidt
     

10 Mar, 2009

1 commit

  • 3f612132c   gigaset: return -ENOTTY for unimplemented functions ... Browse Code »

    A number of functions in the usb_gigaset module will return -EINVAL if
    CONFIG_GIGASET_UNDOCREQ is not set. Make these return -ENOTTY as it's
    more specific and it might make it easier to see (from userspace) why
    these functions actually fail.

    Impact: some error return codes changed

    Signed-off-by: Paul Bolle
    Signed-off-by: Tilman Schmidt
    Signed-off-by: David S. Miller

    Paul Bolle
     

26 Dec, 2008

1 commit

30 Nov, 2008

1 commit

25 Jul, 2008

1 commit

  • 5002779d3   gigaset: use dev_ macros for messages ... Browse Code »

    The info() / warn() / err() macros from usb.h for generating kernel
    messages are considered inferior to dev_info() / dev_warn() / dev_err()
    from device.h. Replace them where possible. Also correct the severity
    level and improve the text of one message.

    Signed-off-by: Tilman Schmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     

07 Feb, 2008

5 commits

  • e468c0489   Gigaset: permit module unload ... Browse Code »

    Fix the initialization and reference counting of the Gigaset driver modules
    so that they can be unloaded when they are not actually in use.

    Signed-off-by: Tilman Schmidt
    Cc: Hansjoerg Lipp
    Cc: Greg KH
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • 9d4bee2b9   gigaset: atomic cleanup ... Browse Code »

    Convert atomic_t variables that don't actually use atomic_t functionality
    to int.

    Signed-off-by: Tilman Schmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • 1ff0a5296   usb_gigaset: suspend support ... Browse Code »

    Add basic suspend/resume support to the usb_gigaset driver for the Siemens
    Gigaset M105 USB DECT adapter.

    Only the USB aspects are handled so far; the ISDN subsystem is not notified in
    any way, for lack of information about how to do that. The driver does not
    check for active connections before suspending. They will be dropped when the
    device loses USB power.

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • c652cbd8e   gigaset: code cleanups ... Browse Code »

    Some cleanups to the bas-gigaset and usb-gigaset USB ISDN drivers:
    - simplified error handling
    - improved debug messages
    - readability improvements
    - removal of obsolete defines and comments

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • dbd982312   gigaset: clean up urb->status usage ... Browse Code »

    Make there only be one reference to urb->status per URB callback, and none
    outside, in preparation for removal of that field.

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     

17 Oct, 2007

1 commit

09 May, 2007

1 commit

  • 21d364954   usb_gigaset: don't kmalloc(0) ... Browse Code »

    Zero-sized allocations are pointless anyway, and the SLUB allocator
    complains about them, so stop doing that.

    Signed-off-by: Tilman Schmidt
    Signed-off-by: Hansjoerg Lipp
    Cc: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     

26 Apr, 2007

1 commit

29 Mar, 2007

1 commit

08 Dec, 2006

2 commits

02 Dec, 2006

1 commit

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

27 Jun, 2006

1 commit

16 May, 2006

1 commit

11 Apr, 2006

7 commits

27 Mar, 2006

1 commit

  • 07dc1f9f2   [PATCH] isdn4linux: Siemens Gigaset drivers - M105 USB DECT adapter ... Browse Code »

    And: Tilman Schmidt

    This patch adds the connection-specific module "usb_gigaset", the hardware
    driver for Gigaset base stations connected via the M105 USB DECT adapter. It
    contains the code for handling probe/disconnect, AT command/response
    transmission, and call setup and termination, as well as handling asynchronous
    data transfers, PPP framing, byte stuffing, and flow control.

    Signed-off-by: Hansjoerg Lipp
    Signed-off-by: Tilman Schmidt
    Cc: Karsten Keil
    Cc: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hansjoerg Lipp