13 Jan, 2012

1 commit


19 Aug, 2011

1 commit


07 Jan, 2009

1 commit

  • Fix this sparse warnings:

    drivers/video/neofb.c:1456:4: warning: returning void-valued expression
    drivers/video/neofb.c:1464:3: warning: returning void-valued expression

    Signed-off-by: Hannes Eder
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hannes Eder
     

17 Oct, 2008

3 commits


25 Jul, 2008

3 commits

  • Remove the xtimings structure which only stored some values to be used
    later (mostly once). Calculate and use these values in places they are
    needed.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • Drop structure which is only set but never read. Drop variables which are
    only set and never read. Convert one long switch into two shorter ones.

    Add cpu_relax() in busy waiting loop.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     
  • There is nothing to gain by converting value in kHz to fixed point MHz.
    Just calculate everything in kHz.

    A reorder of the loop allows reducing number of iterations (check if
    frequency is not too high already).

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     

07 Feb, 2008

1 commit

  • Fix bug identified by Marcio Buss in
    http://bugzilla.kernel.org/show_bug.cgi?id=9565 - neofb can overwrite a field
    in the fb_info struct.

    This fix will result in truncated device identification strings - perhaps
    fb_innfo.fix.id can be made larger?

    Cc: Marcio Buss
    Cc: "Antonino A. Daplas"
    Cc: Christian Trefzer
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     

17 Oct, 2007

1 commit


31 May, 2007

1 commit


09 May, 2007

1 commit


13 Feb, 2007

2 commits

  • Some of fb drivers uses atomic_t in bad manner, since there are still some
    race-prone gaps. Use mutexes to protect open/close code sections with
    ref_count testing and finally use simple uint.

    Signed-off-by: Jiri Slaby
    Acked-by: Denis Oliver Kropp
    Cc: James Simmons
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • Add a proper prototype for tosh_smm() to include/linux/toshiba.h

    Signed-off-by: Adrian Bunk
    Cc: James Simmons
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     

09 Dec, 2006

1 commit


11 Jul, 2006

1 commit

  • MAX_NR_CONSOLES, fg_console, want_console and last_console are more of a
    function of the VT layer than the TTY one. Moving these to vt.h and vt_kern.h
    allows all of the framebuffer and VT console drivers to remove their
    dependency on tty.h.

    [akpm@osdl.org: fix alpha build]
    Signed-off-by: Jon Smirl
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jon Smirl
     

01 Jul, 2006

1 commit


27 Jun, 2006

1 commit

  • This is a fix for the most annoying problem that remained with neofb:

    After "setterm -powersave powerdown" the console blanker will disable the
    backlight after the given timeout expires. If this happens after the lid
    has been shut, we read "LCD off" from the register and store that in the
    driver. Once the lid is opened, the backlight turns on, but any key press
    that would awaken the blanked console will switch the backlight off again.

    The workaround so far was to use the "display config toggle" Fn key combo -
    once if no external display is attached, otherwise as often as required to
    restore the desired display setup.

    The following patch fixes the issue at least for the LCD-only case, with no
    external monitor attached. Other display setup permutations are pending
    further testing, but so far I can guarantee at least no negative change in
    behaviour, if any at all.

    Signed-off-by: Christian Trefzer
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christian Trefzer
     

28 Mar, 2006

1 commit

  • Use ARRAY_SIZE macro instead of sizeof(x)/sizeof(x[0]) and remove
    duplicates of ARRAY_SIZE. Some coding style and trailing whitespaces are
    also fixed.

    Compile-tested where possible (some are other arch or BROKEN)

    Signed-off-by: Tobias Klauser
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tobias Klauser
     

12 Mar, 2006

1 commit


16 Feb, 2006

1 commit

  • There were two mistakes in the register-read-on-(un)blank approach.

    - First, without proper register (un)locking the value read back will always
    be zero, and this is what I missed entirely until just now. Due to this,
    the logic could not be verified at all and I tried some bogus checks which
    are completely stupid.

    - Second, the LCD status bit will always be set to zero when the backlight
    has been turned off. Reading the value back during unblank will disable the
    LCD unconditionally, regardless of the state it is supposed to be in, since
    we set it to zero beforehand.

    So this is what we do now:

    - create a new variable in struct neofb_par, and use that to determine
    whether to read back registers (initialized to true)

    - before actually blanking the screen, read back the register to sense any
    possible change made through Fn key combo

    - use proper neoUnlock() / neoLock() to actually read something

    - every call to neofb_blank() determines if we read back next time: blanking
    disables readback, unblanking (FB_BLANK_UNBLANK) enables it

    This should give us a nice and clean state machine. Has been thoroughly
    tested on a Dell Latitude CPiA / NM220 Chip docked to a C/Dock2 with attached
    CRT in all possible combinations of LCD/CRT on/off. I changed the config via
    Fn key, let the console blank, unblanked by keypress - works flawlessly.

    Signed-off-by: Christian Trefzer
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christian Trefzer
     

15 Feb, 2006

1 commit

  • Fix issues with the NeoMagic framebuffer driver.

    It nicely complements my previous fix already in linus' tree. The only
    thing missing now is that the external CRT will not be activated at neofb
    init when external-only is selected, either by register read or
    module/kernel parameter.

    Testing was done on a Dell Latitude CPi-A/NM2200 chip.

    Previous behaviour:
    - before booting linux, set the preferred display config X via FN+F8

    - boot linux, neofb stores the register values in a private
    variable

    - change the display config to Y via keystroke

    - leave the machine in peace until display is blanked

    - touching any key will result in display config X being restored

    - booting up, the BIOS will acknowledge config Y, though...

    Current behaviour:
    At the time of unblanking, config Y is honoured because we now read back
    register contents instead of just overwriting them with outdated values.

    Signed-off by: Christian Trefzer
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christian Trefzer
     

15 Jan, 2006

1 commit

  • On a Dell Latitude CPi-A I noticed a strangeness wrt. the handling of an
    external monitor by the neomagic framebuffer driver, namely when the laptop is
    docked in a C/Dock II with the lid shut.

    A cold boot would result in the BIOS configuring the video chip to use the
    "external monitor only" mode, yet neofb would default to "internal LCD only".
    An attempt for a quick fix by using the Fn-F8 keystroke to toggle the display
    combination modes resulted in a reproductible hard lock, powering down being
    the only solution.

    The attached patch makes neofb probe the register for the current display
    mode, using that value as a default if nothing was specified as kernel/module
    parameter.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christian Trefzer
     

11 Jan, 2006

1 commit


07 Nov, 2005

1 commit

  • According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
    drivers that do not support hardware cursors is redundant. The soft_cursor
    function is usable by all drivers because it is just a wrapper around
    fb_imageblit. And because soft_cursor is an fbcon-specific hook, the file is
    moved to the console directory.

    Thus, drivers that do not support hardware cursors can leave the fb_cursor
    field blank. For drivers that do, they can fill up this field with their own
    version.

    The end result is a smaller code size. And if the framebuffer console is not
    loaded, module/kernel size is also reduced because the soft_cursor module will
    also not be loaded.

    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Antonino A. Daplas
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds