03 Sep, 2011

1 commit

  • Following on Herton's patch "fb: avoid possible deadlock caused by
    fb_set_suspend" which moves lock_fb_info() out of fb_set_suspend()
    to its callers, correct sh-mobile's locking around call to
    fb_set_suspend() and the same sort of deaklocks with console_lock()
    due to order of taking the lock.

    console_lock() must be taken while fb_info is already locked and fb_info
    must be locked while calling fb_set_suspend().

    Signed-off-by: Bruno Prémont
    Signed-off-by: Guennadi Liakhovetski
    Signed-off-by: Florian Tobias Schandinat
    Cc: stable@kernel.org

    Bruno Prémont
     

15 Jun, 2011

1 commit

  • A recent modification to the runtime PM code on mach-shmobile made a wrong
    RTPM implementation in the sh_mobile_hdmi driver apparent, which broke
    HDMI hotplug detection support on ap4evb. This patch does not implement a
    proper dynamic RTPM support for sh_mobile_hdmi, instead it restores the
    previous working state by statically enabling it. A more power-efficient
    solution should be implemented for the next kernel version.

    Signed-off-by: Guennadi Liakhovetski
    Signed-off-by: Paul Mundt

    Guennadi Liakhovetski
     

24 May, 2011

1 commit


26 Jan, 2011

1 commit

  • The -rt patches change the console_semaphore to console_mutex. As a
    result, a quite large chunk of the patches changes all
    acquire/release_console_sem() to acquire/release_console_mutex()

    This commit makes things use more neutral function names which dont make
    implications about the underlying lock.

    The only real change is the return value of console_trylock which is
    inverted from try_acquire_console_sem()

    This patch also paves the way to switching console_sem from a semaphore to
    a mutex.

    [akpm@linux-foundation.org: coding-style fixes]
    [akpm@linux-foundation.org: make console_trylock return 1 on success, per Geert]
    Signed-off-by: Torben Hohn
    Cc: Thomas Gleixner
    Cc: Greg KH
    Cc: Ingo Molnar
    Cc: Geert Uytterhoeven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Torben Hohn
     

14 Jan, 2011

2 commits

  • * git://git.kernel.org/pub/scm/linux/kernel/git/lethal/fbdev-2.6: (29 commits)
    video: move SH_MIPI_DSI/SH_LCD_MIPI_DSI to the top of menu
    fbdev: Implement simple blanking in pseudocolor modes for vt8500lcdfb
    video: imx: Update the manufacturer's name
    nuc900fb: don't treat NULL clk as an error
    s3c2410fb: don't treat NULL clk as an error
    video: tidy up modedb formatting.
    video: matroxfb: Correct video option in comments and kernel config help.
    fbdev: sh_mobile_hdmi: simplify pointer handling
    fbdev: sh_mobile_hdmi: framebuffer notifiers have to be registered
    fbdev: sh_mobile_hdmi: add command line option to use the preferred EDID mode
    OMAP: DSS2: Introduce omap_channel as an omap_dss_device parameter, add new overlay manager.
    OMAP: DSS2: Use dss_features to handle DISPC bits removed on OMAP4
    OMAP: DSS2: LCD2 Channel Changes for DISPC
    OMAP: DSS2: Change remaining DISPC functions for new omap_channel argument
    OMAP: DSS2: Introduce omap_channel argument to DISPC functions used by interface drivers
    OMAP: DSS2: Represent DISPC register defines with channel as parameter
    OMAP: DSS2: Add dss_features for omap4 and overlay manager related features
    OMAP: DSS2: Clean up DISPC color mode validation checks
    OMAP: DSS2: Add back authors of panel-generic.c based drivers
    OMAP: DSS2: remove generic DPI panel driver duplicated panel drivers
    ...

    Linus Torvalds
     
  • * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6: (348 commits)
    ALSA: hda - Fix NULL-derefence with a single mic in STAC auto-mic detection
    ALSA: hda - Add missing NID 0x19 fixup for Sony VAIO
    ALSA: hda - Fix ALC275 enable hardware EQ for SONY VAIO
    ALSA: oxygen: fix Xonar DG input
    ALSA: hda - Fix EAPD on Lenovo NB ALC269 to low
    ALSA: hda - Fix missing EAPD for Acer 4930G
    ALSA: hda: Disable 4/6 channels on some NVIDIA GPUs.
    ALSA: hda - Add static_hdmi_pcm option to HDMI codec parser
    ALSA: hda - Don't refer ELD when unplugged
    ASoC: tpa6130a2: Fix compiler warning
    ASoC: tlv320dac33: Add DAPM selection for LOM invert
    ASoC: DMIC codec: Adding a generic DMIC codec
    ALSA: snd-usb-us122l: Fix missing NULL checks
    ALSA: snd-usb-us122l: Fix MIDI output
    ASoC: soc-cache: Fix invalid memory access during snd_soc_lzo_cache_sync()
    ASoC: Fix section mismatch in wm8995.c
    ALSA: oxygen: add S/PDIF source selection for Claro cards
    ALSA: oxygen: fix CD/MIDI for X-Meridian (2G)
    ASoC: fix migor audio build
    ALSA: include delay.h for msleep in Xonar DG support
    ...

    Linus Torvalds
     

13 Jan, 2011

1 commit


11 Jan, 2011

3 commits


06 Jan, 2011

1 commit


29 Dec, 2010

1 commit


22 Dec, 2010

1 commit


15 Nov, 2010

1 commit


10 Nov, 2010

5 commits


29 Oct, 2010

1 commit


15 Oct, 2010

2 commits


14 Sep, 2010

10 commits


10 Sep, 2010

4 commits

  • This patch solve below report from Guennadi

    > /* External video parameter settings */
    > static void hdmi_external_video_param(struct sh_hdmi *hdmi)
    > {
    > @@ -804,6 +862,11 @@ static int __init sh_hdmi_probe(struct platform_device *pdev)
    > return -ENOMEM;
    > }
    >
    > + ret = snd_soc_register_codec(&pdev->dev,
    > + &soc_codec_dev_sh_hdmi, &sh_hdmi_dai, 1);
    > + if (ret < 0)
    > + goto egetclk;
    > +
    > hdmi->dev = &pdev->dev;
    >
    > hdmi->hdmi_clk = clk_get(&pdev->dev, "ick");

    NAK. This breaks the error path and has to be fixed. Firstly, please, use
    a new label like "esndreg," secondly, you have to add

    clk_disable(hdmi->hdmi_clk);
    erate:
    clk_put(hdmi->hdmi_clk);
    egetclk:
    + snd_soc_unregister_codec(&pdev->dev);
    +esndreg:
    mutex_destroy(&hdmi->mutex);
    kfree(hdmi);

    Reported-by: Guennadi Liakhovetski
    Signed-off-by: Kuninori Morimoto
    Reviewed-by: Guennadi Liakhovetski
    Acked-by: Liam Girdwood
    Signed-off-by: Mark Brown

    Kuninori Morimoto
     
  • This patch solve below report from Guennadi

    > +static struct snd_soc_dai_driver sh_hdmi_dai = {
    > + .name = "sh_mobile_hdmi-hifi",
    > + .playback = {
    > + .stream_name = "Playback",
    > + .channels_min = 1,

    Can it actually do mono? Maybe at probe time you could look at audio flags
    from your previous patch and, e.g., for SPDIF set channels_min to 2?

    > + .channels_max = 2,

    That's the "smallest max," yes. With some other interfaces (I2S, DSD) it
    can support up to 8 channels...

    > + .rates = SNDRV_PCM_RATE_8000_48000,

    Hm, in the datasheet I see supported frequencies 32kHz to 192kHz. And if
    you promise support for multiple frequencies, don't you want to implement
    .hw_params? Besides, not all of these frequencies will be available,
    depending on your supplied clock and your willingness to implement
    downsampling.

    Reported-by: Guennadi Liakhovetski
    Signed-off-by: Kuninori Morimoto
    Reviewed-by: Guennadi Liakhovetski
    Acked-by: Liam Girdwood
    Signed-off-by: Mark Brown

    Kuninori Morimoto
     
  • This patch solve below report from Guennadi

    1)

    > +/* Audio source select */
    > +#define HDMI_SRC_MASK (0xF << 0)
    > +#define HDMI_SRC_I2S (0 << 0) /* default */
    > +#define HDMI_SRC_SPDIF (1 << 0)
    > +#define HDMI_SRC_DSD (2 << 0)
    > +#define HDMI_SRC_HBR (3 << 0)

    I would be more specific with these macro names, i.e., include "AUDIO" or
    "SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S.

    2)

    > + case HDMI_SRC_I2S:
    > + data = (0x0 << 3);
    > + break;
    > + case HDMI_SRC_SPDIF:
    > + data = (0x1 << 3);
    > + break;
    > + case HDMI_SRC_DSD:
    > + data = (0x2 << 3);
    > + break;
    > + case HDMI_SRC_HBR:
    > + data = (0x3 << 3);

    In all above cases parenthesis are superfluous.

    Reported-by: Guennadi Liakhovetski
    Signed-off-by: Kuninori Morimoto
    Reviewed-by: Guennadi Liakhovetski
    Acked-by: Liam Girdwood
    Signed-off-by: Mark Brown

    Kuninori Morimoto
     
  • This patch solve below report from Guennadi

    1)

    > - hdmi_write(hdmi, 0x00, HDMI_AUDIO_SETTING_1);
    > + switch (pdata->flags & HDMI_SRC_MASK) {
    > + default:
    > + /* FALL THROUGH */

    I'm not sure I like the capitalisation here - no reason to shout;)

    2)

    > +/************************************************************************
    > +
    > +
    > + HDMI sound
    > +
    > +
    > +************************************************************************/

    I don't think this comment deserves 7 lines of text, besides breaking the
    multiline comment style. If you think, one line like

    /* HDMI sound */

    is not enough how about just

    /*
    * HDMI sound
    */

    3)

    > +/************************************************************************
    > +
    > +
    > + HDMI video
    > +
    > +
    > +************************************************************************/

    See above - 7 lines seem to be an overkill to me.

    Reported-by: Guennadi Liakhovetski
    Signed-off-by: Kuninori Morimoto
    Reviewed-by: Guennadi Liakhovetski
    Acked-by: Liam Girdwood
    Signed-off-by: Mark Brown

    Kuninori Morimoto
     

01 Sep, 2010

2 commits


04 Aug, 2010

1 commit

  • Some SH-Mobile SoCs have an HDMI controller and a PHY, attached to one of their
    LCDC interfaces. This patch adds a preliminary static support for such
    controllers, this means, that only the 720p mode is handled ATM. Support for
    more modes and a dynamic switching between them will be added by a follow up
    patch.

    Signed-off-by: Guennadi Liakhovetski
    Acked-by: Magnus Damm
    Signed-off-by: Paul Mundt

    Guennadi Liakhovetski