27 Sep, 2013
25 commits
-
kvp_daemon does some operations which take an unpredicable amount of
time. In addition the kernel driver gives the kvp_daemon a 5 second
timeout to respond to message from the host. If an operation such as
getaddrinfo takes a long time and the timeout triggers then netlink
errors occour. As a result of such errors the daemon just terminates and
the service becomes unavailable.Idendifying and fixing these shortcomings in the kernel-userland
communication protocol will be done in separate patches. This change
fixes just one obvious timeout bug.Update kvp_get_domain_name to not return a value, better diagnostic for
the consumer of the hostname string, remove trailing newline in error
case, use snprintf to not overrun output buffer, get hostname only once
and return the cached result.Signed-off-by: Olaf Hering
Signed-off-by: Greg Kroah-Hartman -
This fixes up braces coding style issue by using checkpatch script.
Cc: Charles Keepax
Cc: Mark Brown
Signed-off-by: Chanwoo Choi
Signed-off-by: Greg Kroah-Hartman -
This patch remove unnecessary extern declaration (extcon_set_state).
checkpatch found this coding style issue.Signed-off-by: Chanwoo Choi
Signed-off-by: Myungjoo Ham
Signed-off-by: Greg Kroah-Hartman -
This patch fix 80 column coding sytle issues by using checkpatch script.
Cc: Charles Keepax
Cc: Mark Brown
Signed-off-by: Chanwoo Choi
Signed-off-by: Myungjoo Ham
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
Only matching is done via DT, no other details can be passed.
Signed-off-by: Daniel Mack
Signed-off-by: Greg Kroah-Hartman -
This way, the module can be autoloaded by the SPI core.
Signed-off-by: Daniel Mack
Signed-off-by: Greg Kroah-Hartman -
The driver's name can be provided directly, so drop the #define.
Signed-off-by: Daniel Mack
Signed-off-by: Greg Kroah-Hartman -
Providing a module version doesn't add any value, so drop it.
Signed-off-by: Daniel Mack
Signed-off-by: Greg Kroah-Hartman -
This moves the ringbuffer bus attributes to the dev_groups structure,
deletes the now unneeded struct hv_device_info, and removes some now
unused functions, and variables as everything is now moved to the
dev_groups structure, dev_attrs is no longer needed.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
It's no longer needed, and the struct hv_ring_buffer_debug_info
structure shouldn't be "global" so move it to the local .h file instead.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
It's only used once, only contains 2 function calls, so just make those
calls directly, deleting the function, and the now unneeded structure
entirely.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "client_monitor_conn_id" and "server_monitor_conn_id" bus
attributes to the dev_groups structure, removing the need for it to be
in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "client_monitor_latency" and "server_monitor_latency" bus
attributes to the dev_groups structure, removing the need for it to be
in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "client_monitor_pending" and "server_monitor_pending" bus
attributes to the dev_groups structure, removing the need for it to be
in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
monitor_pages was a void pointer, containing an unknown number of arrays that
we just "knew" were a child and parent array of a specific size. Instead of
that implicit knowledge, let's make them a real pointer, allowing us to have
type safety, and a semblance of sane addressing schemes.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "device_id" bus attribute to the dev_groups structure,
removing the need for it to be in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "class_id" bus attribute to the dev_groups structure,
removing the need for it to be in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "state" bus attribute to the dev_groups structure.
Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "state" bus attribute to the dev_groups structure,
removing the need for it to be in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This moves the "state" bus attribute to the dev_groups structure,
removing the need for it to be in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman -
This patch is the first in a series that moves the hv bus code to use the
dev_groups field instead of dev_attrs, as dev_attrs is going away in future
kernel releases.It moves the id sysfs file to the dev_groups structure, and creates the needed
show/store functions, instead of relying on one "universal" function for this.
By doing this, it removes the need for this to be in a temporary structure.Tested-by: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
26 Sep, 2013
15 commits
-
Use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
Cc: Dominik Brodowski
Cc: Bill Pemberton
Cc: Greg Kroah-Hartman
Cc: Eric Miao
Cc: Bjorn Helgaas
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
Use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
Cc: Bill Pemberton
Cc: Eric Miao
Cc: Dominik Brodowski
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
The variable execute_shutdown is only assigned the values true and
false. Change its type to bool.The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):@exists@
type T;
identifier b;
@@
- T
+ bool
b = ...;
... when any
b = \(true\|false\)Signed-off-by: Peter Senna Tschudin
Signed-off-by: Greg Kroah-Hartman -
This change improves code readability & is less error-prone.
For example: case adding more error paths one should remember to call 'mutex_unlock'Signed-off-by: Elad Wexler
Signed-off-by: Greg Kroah-Hartman -
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Greg Kroah-Hartman -
Using devres functions simplify driver error path.
- Use devm_kzalloc
- Use devm_request_irqSigned-off-by: Michal Simek
Reviewed-by: Pavel Machek
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Fengguang Wu
Signed-off-by: Rostislav Lisovy
Signed-off-by: Greg Kroah-Hartman -
fixmem32 is assigned to address of res->data member
so the address is always validActually since we are not checking for res != NULL
static analyzing is complaining about referencing the pointer
and consequent check for null.
The code snippet looks confusing also for human eyes.Cc: Randy Dunlap
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
bmp085_get_of_properties() is called by bmp085_init_client() which is
called by bmp085_probe() which is an EXPORT_SYMBOL_GPL function.bmp085_probe() is really used as a probe function by another modules
(e.g. bmp085-i2c.c, bmp085-spi.c).Except bmp085_get_of_properties(), all functions have no '__init', so
need remove '__init' from bmp085_get_of_properties() too, or at least,
it will report related warning:WARNING: vmlinux.o(.text+0x4c8a07): Section mismatch in reference from the variable .LM171 to the variable .init.text:_bmp085_get_of_properties
The function .LM171() references
the variable __init _bmp085_get_of_properties.
This is often because .LM171 lacks a __init
annotation or the annotation of _bmp085_get_of_properties is wrong.Signed-off-by: Chen Gang
Signed-off-by: Greg Kroah-Hartman
